[PATCH v2 0/2] i3c: dw: Document optional core reset and drop redundant name

[PATCH v2 0/2] i3c: dw: Document optional core reset and drop redundant name

[Shubham Patil]

This series documents the optional core reset for the Synopsys
DesignWare I3C master and updates the driver to match the binding.
The DesignWare I3C master IP has a single core reset input. The
binding never documented this reset, and the driver looked it up by
the "core_rst" name even though a name is redundant for a single
reset line.

This series addresses both:
  - Patch 1 documents the optional 'resets' property in the binding.
    The reset is kept optional because the reset line is
    integration-specific.
  - Patch 2 removes the "core_rst" reset name from the driver and
    looks the reset up by passing NULL, since the name is redundant
    for a single reset.

Changes in v2:
- Updated commit description for binding patch
- Dropped reset-names from the binding
- Added driver patch to remove redundant reset name

Note:
The DesignWare I3C driver support was added by
commit 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").

The original Synopsys DesignWare I3C binding was added by
commit 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
but it did not document the optional core reset.
---
Shubham Patil (2):
  dt-bindings: i3c: dw: Document missing optional core reset
  i3c: master: dw: Drop redundant core reset name

 Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
 drivers/i3c/master/dw-i3c-master.c                            | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)


base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
-- 
2.34.1

[PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset

[Shubham Patil]

The DesignWare I3C master IP supports a core reset input, but the
binding is missing the corresponding reset description.

Document the optional reset property. Keep it optional because the
reset line is integration-specific.

Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
---
Changes in v2:
- Updated commit description
- Dropped reset-name from the binding
---
 Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
index e803457d3f55..dc7ee38001d6 100644
--- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
+++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
@@ -38,6 +38,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  resets:
+    maxItems: 1
+
   power-domains:
     maxItems: 1
 
-- 
2.34.1

[PATCH v2 2/2] i3c: master: dw: Drop redundant core reset name

[Shubham Patil]

The DesignWare I3C master has a single reset line, so a dedicated
reset name is redundant. Look up the reset by index by passing NULL
instead of the "core_rst" name.

Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
---
 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 2f8c0c4683e0..488fb455d3cc 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1584,7 +1584,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 		return PTR_ERR(master->pclk);
 
 	master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
-										"core_rst");
+										NULL);
 	if (IS_ERR(master->core_rst))
 		return PTR_ERR(master->core_rst);
 
-- 
2.34.1

Re: [PATCH v2 2/2] i3c: master: dw: Drop redundant core reset name

[Pandey, Radhey Shyam]

On 7/20/2026 1:05 PM, Shubham Patil wrote:
> The DesignWare I3C master has a single reset line, so a dedicated
> reset name is redundant. Look up the reset by index by passing NULL
> instead of the "core_rst" name.
> 
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!

> ---
>   drivers/i3c/master/dw-i3c-master.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 2f8c0c4683e0..488fb455d3cc 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1584,7 +1584,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
>   		return PTR_ERR(master->pclk);
>   
>   	master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
> -										"core_rst");
> +										NULL);
>   	if (IS_ERR(master->core_rst))
>   		return PTR_ERR(master->core_rst);
>   

Re: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset

[Pandey, Radhey Shyam]

On 7/20/2026 1:05 PM, Shubham Patil wrote:
> The DesignWare I3C master IP supports a core reset input, but the
> binding is missing the corresponding reset description.
> 
> Document the optional reset property. Keep it optional because the
> reset line is integration-specific.
> 
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
> Changes in v2:
> - Updated commit description
> - Dropped reset-name from the binding
> ---
>   Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f55..dc7ee38001d6 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,6 +38,9 @@ properties:
>     interrupts:
>       maxItems: 1
>   
> +  resets:
> +    maxItems: 1
> +
>     power-domains:
>       maxItems: 1
>   

Re: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset

[Frank Li]

On Mon, Jul 20, 2026 at 01:05:09PM +0530, Shubham Patil wrote:
> The DesignWare I3C master IP supports a core reset input, but the
> binding is missing the corresponding reset description.
>
> Document the optional reset property. Keep it optional because the
> reset line is integration-specific.
>
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Changes in v2:
> - Updated commit description
> - Dropped reset-name from the binding
> ---
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f55..dc7ee38001d6 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,6 +38,9 @@ properties:
>    interrupts:
>      maxItems: 1
>
> +  resets:
> +    maxItems: 1
> +
>    power-domains:
>      maxItems: 1
>
> --
> 2.34.1
>

Re: [PATCH v2 2/2] i3c: master: dw: Drop redundant core reset name

[Frank Li]

On Mon, Jul 20, 2026 at 01:05:10PM +0530, Shubham Patil wrote:
> The DesignWare I3C master has a single reset line, so a dedicated
> reset name is redundant. Look up the reset by index by passing NULL
> instead of the "core_rst" name.
>
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/i3c/master/dw-i3c-master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 2f8c0c4683e0..488fb455d3cc 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1584,7 +1584,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
>  		return PTR_ERR(master->pclk);
>
>  	master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
> -										"core_rst");
> +										NULL);
>  	if (IS_ERR(master->core_rst))
>  		return PTR_ERR(master->core_rst);
>
> --
> 2.34.1
>

Re: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset

[Rob Herring (Arm)]

On Mon, 20 Jul 2026 13:05:09 +0530, Shubham Patil wrote:
> The DesignWare I3C master IP supports a core reset input, but the
> binding is missing the corresponding reset description.
> 
> Document the optional reset property. Keep it optional because the
> reset line is integration-specific.
> 
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> ---
> Changes in v2:
> - Updated commit description
> - Dropped reset-name from the binding
> ---
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v2 0/2] i3c: dw: Document optional core reset and drop redundant name

[Alexandre Belloni]

On Mon, 20 Jul 2026 13:05:08 +0530, Shubham Patil wrote:
> This series documents the optional core reset for the Synopsys
> DesignWare I3C master and updates the driver to match the binding.
> The DesignWare I3C master IP has a single core reset input. The
> binding never documented this reset, and the driver looked it up by
> the "core_rst" name even though a name is redundant for a single
> reset line.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: i3c: dw: Document missing optional core reset
      https://git.kernel.org/i3c/c/904473e58db7
[2/2] i3c: master: dw: Drop redundant core reset name
      https://git.kernel.org/i3c/c/283e91b86613

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH v2 0/2] i3c: dw: Document optional core reset and drop redundant name

[Jisheng Zhang]

On Mon, Jul 20, 2026 at 01:05:08PM +0530, Shubham Patil wrote:
> This series documents the optional core reset for the Synopsys
> DesignWare I3C master and updates the driver to match the binding.
> The DesignWare I3C master IP has a single core reset input. The
> binding never documented this reset, and the driver looked it up by
> the "core_rst" name even though a name is redundant for a single
> reset line.

Hi DT maintainers,

AIUI, the dw i3c explicitly says there are three reset signals in
total:
core_rstn, for core
presetn, for apb
dmareset, for dma

and I'm adding apb reset suppport, given this series has been applied,
we have three choices:

1.revert patch2 and document the "core_rst" reset dt-binding. This
equals to v1 of this series.

2.add a patch to add the "core_rst" reset, but allow no reset name

3.add a patch to add the "core" reset, but allow no reset name

Which one do you prefer?

Thanks

> 
> This series addresses both:
>   - Patch 1 documents the optional 'resets' property in the binding.
>     The reset is kept optional because the reset line is
>     integration-specific.
>   - Patch 2 removes the "core_rst" reset name from the driver and
>     looks the reset up by passing NULL, since the name is redundant
>     for a single reset.
> 
> Changes in v2:
> - Updated commit description for binding patch
> - Dropped reset-names from the binding
> - Added driver patch to remove redundant reset name
> 
> Note:
> The DesignWare I3C driver support was added by
> commit 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
> 
> The original Synopsys DesignWare I3C binding was added by
> commit 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
> but it did not document the optional core reset.
> ---
> Shubham Patil (2):
>   dt-bindings: i3c: dw: Document missing optional core reset
>   i3c: master: dw: Drop redundant core reset name
> 
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
>  drivers/i3c/master/dw-i3c-master.c                            | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> 
> base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
> -- 
> 2.34.1
> 
> 
> -- 
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c