[PATCH 0/3] regulator: mpq4210: Address the post-merge review comments

[PATCH 0/3] regulator: mpq4210: Address the post-merge review comments

[Tapio Reijonen]

The MPQ4210 series was applied to for-7.4 as e3c05a881fc9 and 61879d561e91,
and two review comments arrived afterwards. Both are addressed here as
incremental patches against current for-7.4.

Patches 1 and 2 rename mps,fb-voltage-divider to mps,fb-voltage-divider-ohms,
as Krzysztof asked. The split across the binding and the driver leaves one
commit where the two disagree, so they are meant to be applied together. The
suffix is worth more here than the convention alone: mps,mp886x.yaml already
describes a property of the same name whose values are kilo ohms rather than
ohms, so two bindings from the same vendor spelled the resistances
identically while meaning different units. Nothing in tree uses the old name
and it has not appeared in a release, so no fallback is kept.

Patch 3 drops the <linux/mod_devicetable.h> include, as Uwe asked.

Tested on an i.MX6SX board whose MPQ4210 sits behind a gpio i2c mux, with the
device tree updated to the new property name. The regulator registers and the
divider is parsed correctly: the board sets regulator-ramp-delay above every
supported rate, and the core reports "Can't set ramp-delay 3000, setting 2101",
where 2101 uV/us is the fastest reference rate scaled by this board's divider.
That value can only be reached by reading both resistors from the renamed
property.

Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
---
Tapio Reijonen (3):
      regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix
      regulator: mpq4210: Use the -ohms feedback divider property
      regulator: mpq4210: Drop the mod_devicetable.h include

 Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml | 9 ++++-----
 drivers/regulator/mpq4210.c                                  | 6 +++---
 2 files changed, 7 insertions(+), 8 deletions(-)
---
base-commit: a655daad54efa1e3959cd642706eb81c9ebafc66
change-id: 20260913-mpq4210-ohms-fixup-8d4c0757da40

Best regards,
-- 
Tapio Reijonen <tapio.reijonen@vaisala.com>

[PATCH 1/3] regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix

[Tapio Reijonen]

The feedback divider property was added without the standard unit
suffix. Rename mps,fb-voltage-divider to mps,fb-voltage-divider-ohms.

The suffix is worth more here than the convention alone: mps,mp886x.yaml
already describes a property of the exact same name whose values are in
kilo ohms, so two bindings from the same vendor spelled the resistances
identically while meaning different units. The suffix states the unit
where it cannot be missed.

Drop the explicit uint32-array $ref along with the rename. Properties
ending in -ohms are typed by property-units.yaml, which reports the type
error itself, so restating it only produced a duplicate complaint.

The binding has not appeared in a release and has no in-tree users, so
nothing depends on the old name. The driver is updated in the next patch.

Fixes: e3c05a881fc9 ("regulator: dt-bindings: Add MPS MPQ4210")
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll
Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
---
 Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
index e9e7a87e7533d0948927a459e9af711d1e07e572..c1914aa1a9d6236d5dbd4eaad3e05355f758155c 100644
--- a/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
+++ b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
@@ -34,16 +34,15 @@ properties:
       be permanently asserted.
     maxItems: 1
 
-  mps,fb-voltage-divider:
+  mps,fb-voltage-divider-ohms:
     description: An array of two integers containing the resistor values R1
-      and R2 of the output feedback voltage divider in ohms.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
+      and R2 of the output feedback voltage divider.
     maxItems: 2
 
 required:
   - compatible
   - reg
-  - mps,fb-voltage-divider
+  - mps,fb-voltage-divider-ohms
 
 unevaluatedProperties: false
 
@@ -62,7 +61,7 @@ examples:
             regulator-max-microvolt = <20000000>;
             enable-gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
             /* R1 = 82 kOhm, R2 = 9.1 kOhm */
-            mps,fb-voltage-divider = <82000 9100>;
+            mps,fb-voltage-divider-ohms = <82000 9100>;
             /* 50 mV/ms reference ramp x (82000 + 9100) / 9100 */
             regulator-ramp-delay = <500>;
         };

-- 
2.47.3

Re: [PATCH 1/3] regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix

[Krzysztof Kozlowski]

On 13/09/2026 13:40, Tapio Reijonen wrote:
> The feedback divider property was added without the standard unit
> suffix. Rename mps,fb-voltage-divider to mps,fb-voltage-divider-ohms.
> 
> The suffix is worth more here than the convention alone: mps,mp886x.yaml
> already describes a property of the exact same name whose values are in
> kilo ohms, so two bindings from the same vendor spelled the resistances
> identically while meaning different units. The suffix states the unit
> where it cannot be missed.
> 
> Drop the explicit uint32-array $ref along with the rename. Properties
> ending in -ohms are typed by property-units.yaml, which reports the type
> error itself, so restating it only produced a duplicate complaint.
> 
> The binding has not appeared in a release and has no in-tree users, so
> nothing depends on the old name. The driver is updated in the next patch.
> 
> Fixes: e3c05a881fc9 ("regulator: dt-bindings: Add MPS MPQ4210")
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
> ---
>  Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 2/3] regulator: mpq4210: Use the -ohms feedback divider property

[Tapio Reijonen]

Follow the binding rename of mps,fb-voltage-divider to
mps,fb-voltage-divider-ohms.

The old name was never in a release and this driver is its only reader,
so it is dropped rather than kept as a fallback.

Fixes: 61879d561e91 ("regulator: Add MPS MPQ4210 buck-boost regulator driver")
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll
Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
---
 drivers/regulator/mpq4210.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/mpq4210.c b/drivers/regulator/mpq4210.c
index 227136d8225805a759d2d6545637858ea7122b89..315f8e02ff2a117e37b32f8a128c9e0feacfac74 100644
--- a/drivers/regulator/mpq4210.c
+++ b/drivers/regulator/mpq4210.c
@@ -144,11 +144,12 @@ static int mpq4210_i2c_probe(struct i2c_client *client)
 	u32 r[2];
 	int ret;
 
-	ret = of_property_read_u32_array(dev->of_node, "mps,fb-voltage-divider",
+	ret = of_property_read_u32_array(dev->of_node,
+					 "mps,fb-voltage-divider-ohms",
 					 r, ARRAY_SIZE(r));
 	if (ret)
 		return dev_err_probe(dev, ret,
-				     "failed to read mps,fb-voltage-divider\n");
+				     "failed to read mps,fb-voltage-divider-ohms\n");
 
 	if (!r[1])
 		return dev_err_probe(dev, -EINVAL,

-- 
2.47.3

Re: [PATCH 2/3] regulator: mpq4210: Use the -ohms feedback divider property

[Krzysztof Kozlowski]

On 13/09/2026 13:40, Tapio Reijonen wrote:
> Follow the binding rename of mps,fb-voltage-divider to
> mps,fb-voltage-divider-ohms.
> 
> The old name was never in a release and this driver is its only reader,
> so it is dropped rather than kept as a fallback.
> 
> Fixes: 61879d561e91 ("regulator: Add MPS MPQ4210 buck-boost regulator driver")
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
> ---
>  drivers/regulator/mpq4210.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/mpq4210.c b/drivers/regulator/mpq4210.c
> index 227136d8225805a759d2d6545637858ea7122b89..315f8e02ff2a117e37b32f8a128c9e0feacfac74 100644
> --- a/drivers/regulator/mpq4210.c
> +++ b/drivers/regulator/mpq4210.c
> @@ -144,11 +144,12 @@ static int mpq4210_i2c_probe(struct i2c_client *client)
>  	u32 r[2];
>  	int ret;

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 3/3] regulator: mpq4210: Drop the mod_devicetable.h include

[Tapio Reijonen]

<linux/mod_devicetable.h> is meant to go away, and this driver does not
need it: <linux/i2c.h> already supplies struct i2c_device_id and
<linux/of.h> struct of_device_id, and both are included already.

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/aqRMb8q7BT3uZ9iF@monoceros
Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
---
 drivers/regulator/mpq4210.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/mpq4210.c b/drivers/regulator/mpq4210.c
index 315f8e02ff2a117e37b32f8a128c9e0feacfac74..293e7b209a987af133230fa2eb7eab826482b101 100644
--- a/drivers/regulator/mpq4210.c
+++ b/drivers/regulator/mpq4210.c
@@ -10,7 +10,6 @@
 #include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
 #include <linux/math.h>
-#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/regmap.h>

-- 
2.47.3

Re: [PATCH 3/3] regulator: mpq4210: Drop the mod_devicetable.h include

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Hello,

On Sun, Sep 13, 2026 at 11:40:18AM +0000, Tapio Reijonen wrote:
> <linux/mod_devicetable.h> is meant to go away, and this driver does not
> need it: <linux/i2c.h> already supplies struct i2c_device_id and
> <linux/of.h> struct of_device_id, and both are included already.
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Link: https://lore.kernel.org/r/aqRMb8q7BT3uZ9iF@monoceros
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>

thanks for picking up the suggestion.

Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]