mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, upstream@lists.phytec.de
Subject: Re: [PATCH 3/4] ARM: dts: imx6: phycore-som: Convert to generic PHY reset binding
Date: Wed, 30 Sep 2026 10:50:29 -0500	[thread overview]
Message-ID: <ar0vxTCkxOg00jhn@SMW015318> (raw)
In-Reply-To: <20260930102532.2262700-4-primoz.fiser@norik.com>

On Wed, Sep 30, 2026 at 12:25:31PM +0200, Primoz Fiser wrote:
> The phy-reset-gpios property on the FEC node is deprecated by the
> Documentation/devicetree/bindings/net/fsl,fec.yaml in favour of the
> generic reset binding on the PHY node itself, described by the
> Documentation/devicetree/bindings/net/ethernet-phy.yaml.
>
> Move the reset GPIO from &fec to the ethphy child node as reset-gpios.

This movement may impact back compatiblity. Any other user use
phy-reset-gpios under $fec?

Frank

>
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> index 9070388eecb0..88eabc7af6b7 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> @@ -56,7 +56,6 @@ &fec {
>  	phy-handle = <&ethphy>;
>  	phy-mode = "rgmii";
>  	phy-supply = <&vdd_eth_io>;
> -	phy-reset-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
>  	status = "disabled";
>
>  	mdio {
> @@ -65,6 +64,7 @@ mdio {
>
>  		ethphy: ethernet-phy@3 {
>  			reg = <3>;
> +			reset-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
>  			txc-skew-ps = <1680>;
>  			rxc-skew-ps = <1860>;
>  		};
> --
> 2.34.1
>
>

  reply	other threads:[~2026-09-30 15:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 10:25 [PATCH 0/4] ARM: dts: imx6: phycore-som: PMIC and PHY fixes Primoz Fiser
2026-09-30 10:25 ` [PATCH 1/4] ARM: dts: imx6: phycore-som: Set PMIC watchdog alias as default Primoz Fiser
2026-09-30 10:25 ` [PATCH 2/4] ARM: dts: imx6: phycore-som: Increase PMIC max SOC and ARM voltage Primoz Fiser
2026-09-30 10:25 ` [PATCH 3/4] ARM: dts: imx6: phycore-som: Convert to generic PHY reset binding Primoz Fiser
2026-09-30 15:50   ` Frank Li [this message]
2026-10-01  6:00     ` Primoz Fiser
2026-09-30 10:25 ` [PATCH 4/4] ARM: dts: imx6: phycore-som: Add reset-assert-us for PHY reset Primoz Fiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar0vxTCkxOg00jhn@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=primoz.fiser@norik.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®