mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema
@ 2026-09-22 19:55 Rob Herring (Arm)
  2026-09-23 10:43 ` Mark Brown
  2026-09-23 10:43 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-09-22 19:55 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang,
	Flora Fu, Alexandre Mergnat
  Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek

Convert the MediaTek mediatek,mt6380-regulator binding to DT schema
format. It's a straight forward conversion.

The regulators are part of the "pwrap" block, so add a $ref to them.

Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../regulator/mediatek,mt6380-regulator.yaml  | 117 ++++++++++++++++++
 .../bindings/regulator/mt6380-regulator.txt   |  89 -------------
 .../bindings/soc/mediatek/mediatek,pwrap.yaml |   3 +
 3 files changed, 120 insertions(+), 89 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6380-regulator.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt

diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6380-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6380-regulator.yaml
new file mode 100644
index 000000000000..0b3c604da727
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6380-regulator.yaml
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/mediatek,mt6380-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6380 Regulator
+
+maintainers:
+  - Sean Wang <sean.wang@mediatek.com>
+
+properties:
+  compatible:
+    const: mediatek,mt6380-regulator
+
+patternProperties:
+  '^buck-(vcore1?|vrf)$':
+    description: BUCK regulators
+    $ref: regulator.yaml#
+    unevaluatedProperties: false
+
+    required:
+      - regulator-min-microvolt
+      - regulator-max-microvolt
+      - regulator-ramp-delay
+
+  '^ldo-v([mat]|phy|ddr)$':
+    type: object
+    description: LDO regulators
+    $ref: regulator.yaml#
+    unevaluatedProperties: false
+
+    required:
+      - regulator-min-microvolt
+      - regulator-max-microvolt
+      - regulator-ramp-delay
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    regulators {
+        compatible = "mediatek,mt6380-regulator";
+
+        buck-vcore1 {
+            regulator-name = "vcore1";
+            regulator-min-microvolt = <600000>;
+            regulator-max-microvolt = <1393750>;
+            regulator-ramp-delay = <6250>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+
+        buck-vcore {
+            regulator-name = "vcore";
+            regulator-min-microvolt = <600000>;
+            regulator-max-microvolt = <1393750>;
+            regulator-ramp-delay = <6250>;
+        };
+
+        buck-vrf {
+            regulator-name = "vrf";
+            regulator-min-microvolt = <1200000>;
+            regulator-max-microvolt = <1575000>;
+            regulator-ramp-delay = <0>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+
+        ldo-vm {
+            regulator-name = "vm";
+            regulator-min-microvolt = <1050000>;
+            regulator-max-microvolt = <1400000>;
+            regulator-ramp-delay = <0>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+
+        ldo-va {
+            regulator-name = "va";
+            regulator-min-microvolt = <2200000>;
+            regulator-max-microvolt = <3300000>;
+            regulator-ramp-delay = <0>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+
+        ldo-vphy {
+            regulator-name = "vphy";
+            regulator-min-microvolt = <1800000>;
+            regulator-max-microvolt = <1800000>;
+            regulator-ramp-delay = <0>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+
+        ldo-vddr {
+            regulator-name = "vddr";
+            regulator-min-microvolt = <1240000>;
+            regulator-max-microvolt = <1840000>;
+            regulator-ramp-delay = <0>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+
+        ldo-vt {
+            regulator-name = "vt";
+            regulator-min-microvolt = <2200000>;
+            regulator-max-microvolt = <3300000>;
+            regulator-ramp-delay = <0>;
+            regulator-always-on;
+            regulator-boot-on;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
deleted file mode 100644
index 0058441f16d2..000000000000
--- a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
+++ /dev/null
@@ -1,89 +0,0 @@
-MediaTek MT6380 Regulator
-
-All voltage regulators provided by the MT6380 PMIC are described as the
-subnodes of the MT6380 regulators node. Each regulator is named according
-to its regulator type, buck-<name> and ldo-<name>. The definition for each
-of these nodes is defined using the standard binding for regulators at
-Documentation/devicetree/bindings/regulator/regulator.txt.
-
-The valid names for regulators are:
-BUCK:
-  buck-core1, buck-vcore, buck-vrf
-LDO:
-  ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt
-
-Example:
-
-	regulators {
-		compatible = "mediatek,mt6380-regulator";
-
-		mt6380_vcpu_reg: buck-vcore1 {
-			regulator-name = "vcore1";
-			regulator-min-microvolt = < 600000>;
-			regulator-max-microvolt = <1393750>;
-			regulator-ramp-delay = <6250>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		mt6380_vcore_reg: buck-vcore {
-			regulator-name = "vcore";
-			regulator-min-microvolt = <600000>;
-			regulator-max-microvolt = <1393750>;
-			regulator-ramp-delay = <6250>;
-		};
-
-		mt6380_vrf_reg: buck-vrf {
-			regulator-name = "vrf";
-			regulator-min-microvolt = <1200000>;
-			regulator-max-microvolt = <1575000>;
-			regulator-ramp-delay = <0>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		mt6380_vm_reg: ldo-vm {
-			regulator-name = "vm";
-			regulator-min-microvolt = <1050000>;
-			regulator-max-microvolt = <1400000>;
-			regulator-ramp-delay = <0>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		mt6380_va_reg: ldo-va {
-			regulator-name = "va";
-			regulator-min-microvolt = <2200000>;
-			regulator-max-microvolt = <3300000>;
-			regulator-ramp-delay = <0>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		mt6380_vphy_reg: ldo-vphy {
-			regulator-name = "vphy";
-			regulator-min-microvolt = <1800000>;
-			regulator-max-microvolt = <1800000>;
-			regulator-ramp-delay = <0>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		mt6380_vddr_reg: ldo-vddr {
-			regulator-name = "vddr";
-			regulator-min-microvolt = <1240000>;
-			regulator-max-microvolt = <1840000>;
-			regulator-ramp-delay = <0>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		mt6380_vt_reg: ldo-vt {
-			regulator-name = "vt";
-			regulator-min-microvolt = <2200000>;
-			regulator-max-microvolt = <3300000>;
-			regulator-ramp-delay = <0>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-	};
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index e7c4a3984c60..79b755858bad 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
+
 required:
   - compatible
   - reg
-- 
2.53.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema
  2026-09-22 19:55 [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema Rob Herring (Arm)
@ 2026-09-23 10:43 ` Mark Brown
  2026-09-23 12:21   ` Rob Herring
  2026-09-23 10:43 ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2026-09-23 10:43 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang,
	Flora Fu, Alexandre Mergnat, linux-kernel, devicetree,
	linux-arm-kernel, linux-mediatek

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Tue, Sep 22, 2026 at 02:55:01PM -0500, Rob Herring (Arm) wrote:
> Convert the MediaTek mediatek,mt6380-regulator binding to DT schema
> format. It's a straight forward conversion.

> +  '^buck-(vcore1?|vrf)$':
> +    description: BUCK regulators
> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false
> +
> +    required:
> +      - regulator-min-microvolt
> +      - regulator-max-microvolt
> +      - regulator-ramp-delay
> +
> +  '^ldo-v([mat]|phy|ddr)$':
> +    type: object
> +    description: LDO regulators
> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false

The LDO is an object but the buck is not?  I'll apply, but the above
looks weird.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema
  2026-09-22 19:55 [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema Rob Herring (Arm)
  2026-09-23 10:43 ` Mark Brown
@ 2026-09-23 10:43 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-09-23 10:43 UTC (permalink / raw)
  To: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang,
	Flora Fu, Alexandre Mergnat, Rob Herring (Arm)
  Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek

On Tue, 22 Sep 2026 14:55:01 -0500, Rob Herring (Arm) wrote:
> regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.4

Thanks!

[1/1] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema
      https://git.kernel.org/broonie/regulator/c/22fe14c9bcb6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema
  2026-09-23 10:43 ` Mark Brown
@ 2026-09-23 12:21   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2026-09-23 12:21 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang,
	Flora Fu, Alexandre Mergnat, linux-kernel, devicetree,
	linux-arm-kernel, linux-mediatek

On Wed, Sep 23, 2026 at 12:43:26PM +0200, Mark Brown wrote:
> On Tue, Sep 22, 2026 at 02:55:01PM -0500, Rob Herring (Arm) wrote:
> > Convert the MediaTek mediatek,mt6380-regulator binding to DT schema
> > format. It's a straight forward conversion.
> 
> > +  '^buck-(vcore1?|vrf)$':
> > +    description: BUCK regulators
> > +    $ref: regulator.yaml#
> > +    unevaluatedProperties: false
> > +
> > +    required:
> > +      - regulator-min-microvolt
> > +      - regulator-max-microvolt
> > +      - regulator-ramp-delay
> > +
> > +  '^ldo-v([mat]|phy|ddr)$':
> > +    type: object
> > +    description: LDO regulators
> > +    $ref: regulator.yaml#
> > +    unevaluatedProperties: false
> 
> The LDO is an object but the buck is not?  I'll apply, but the above
> looks weird.

I missed dropping 'type: object' here in my review/rewrite of the LLM 
generated conversion. It is not needed because regulator.yaml has it 
(after processing, every schema doc does).

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-23 13:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 19:55 [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema Rob Herring (Arm)
2026-09-23 10:43 ` Mark Brown
2026-09-23 12:21   ` Rob Herring
2026-09-23 10:43 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®