From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jared Wuerzburger <jwuerz@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Samuel Dionne-Riel" <samuel@dionne-riel.com>
Subject: Re: [PATCH v3 1/2] iio: imu: st_lsm6dsx: Drop trailing comma in ACPI match table entries
Date: Mon, 28 Sep 2026 12:09:10 +0300 [thread overview]
Message-ID: <aroutl04Q99mqJor@ashevche-desk.local> (raw)
In-Reply-To: <20260927220559.24169-2-jwuerz@gmail.com>
On Sun, Sep 27, 2026 at 05:05:58PM -0500, Jared Wuerzburger wrote:
> The trailing comma after the last member of an initializer is only
> useful when more members may follow, which is never the case for an
> acpi_device_id entry. Drop it, as suggested during review of an earlier
> version of the next patch.
> Link: https://lore.kernel.org/linux-iio/aVFmec8JA6ZX18il@smile.fi.intel.com/
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Assisted-by: Claude:claude-opus-5-5
Assisted-by: LLM
> Signed-off-by: Jared Wuerzburger <jwuerz@gmail.com>
...
> static const struct acpi_device_id st_lsm6dsx_i2c_acpi_match[] = {
> - { "SMO8B30", ST_LSM6DS3TRC_ID, },
> - { "SMOCF00", ST_LSM6DSO_ID, },
> + { "SMO8B30", ST_LSM6DS3TRC_ID },
> + { "SMOCF00", ST_LSM6DSO_ID },
> { }
> };
Thanks, but while at it, also switch to C99 initialisers to avoid an additional
churn (there is ongoing activity to switch all ID tables to use C99 initialisers).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-28 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 22:05 [PATCH v3 0/2] iio: imu: st_lsm6dsx: Add ACPI ID SMOCF05 (Minisforum V3 / V3 SE) Jared Wuerzburger
2026-09-27 22:05 ` [PATCH v3 1/2] iio: imu: st_lsm6dsx: Drop trailing comma in ACPI match table entries Jared Wuerzburger
2026-09-28 9:09 ` Andy Shevchenko [this message]
2026-09-27 22:05 ` [PATCH v3 2/2] iio: imu: st_lsm6dsx: Add ACPI ID SMOCF05 for LSM6DS3TR-C Jared Wuerzburger
2026-09-28 9:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aroutl04Q99mqJor@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jwuerz@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nuno.sa@analog.com \
--cc=samuel@dionne-riel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®