From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jared Wuerzburger <jwuerz@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Samuel Dionne-Riel" <samuel@dionne-riel.com>
Subject: Re: [PATCH v3 2/2] iio: imu: st_lsm6dsx: Add ACPI ID SMOCF05 for LSM6DS3TR-C
Date: Mon, 28 Sep 2026 12:13:17 +0300 [thread overview]
Message-ID: <arovrVYSgU64DM5o@ashevche-desk.local> (raw)
In-Reply-To: <20260927220559.24169-3-jwuerz@gmail.com>
On Sun, Sep 27, 2026 at 05:05:59PM -0500, Jared Wuerzburger wrote:
> The Minisforum V3 and V3 SE tablets declare their ST LSM6DS3TR-C IMU in
> the DSDT with the hardware ID SMOCF05 instead of SMO8B30, so the driver
> never binds and the accelerometer and gyroscope are missing. The
> Windows driver (version 1.0.4.3) binds the LSM6DS3TR-C to both IDs.
>
> Relevant part of the DSDT, identical on both models (full excerpt in
> the cover letter):
Don't refer to the cover letter in the commit message. Most will not understand
this pointer.
> Scope (_SB.I2CD) { Device (STS) {
> Name (_HID, EisaId ("SMOCF05"))
> Name (_CID, EisaId ("SMOCF05"))
> _CRS: I2cSerialBusV2 (0x006A, ..., "\\_SB.I2CD") vendor data "SLA0"
> I2cSerialBusV2 (0x006A, ..., "\\_SB.I2CD") vendor data "SLG0"
> GpioInt (Edge, ActiveHigh, ..., "\\_SB.GPIO") { 9 } "SLA0"
> Method (SLA0): "-1 0 0", "0 -1 0", "0 0 -1"
> Method (SLG0): "1 0 0", "0 1 0", "0 0 1"
> } }
Just ask maintainer to add a Link tag to the series instead.
> Both I2C resources describe the same address, and the driver uses the
> first one. The vendor-specific SLA0/SLG0 mount matrices are not parsed
> here; the accelerometer orientation is handled in userspace through
> the systemd hwdb, as for SMOCF00.
Hmm... But is that wrong? I mean does ACPI provide the correct data in mount
matrix?
> Tested on:
> - V3 SE (Ryzen 7 7735U, BIOS 1.03) with this change.
> - V3 (Ryzen 7 8840U, BIOS 1.06), kernel 7.2.7, with this change and
> the stock firmware tables. The driver binds to i2c-SMOCF05:00, the
> WHO_AM_I check passes (0x6a), and both lsm6ds3tr-c_accel and
> lsm6ds3tr-c_gyro are registered. Screen auto-rotation works with
> iio-sensor-proxy (checked with the device renamed to SMO8B30 via a
> DSDT override, i.e. the same ST_LSM6DS3TRC_ID driver data).
>
> Link: https://github.com/mudkipme/awesome-minisforum-v3/issues/2
Closes?
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> [Jared Wuerzburger: rewrote the changelog with the DSDT excerpt and test
> results, dropped the mount matrix patch from the series]
> Assisted-by: Claude:claude-opus-5-5
Assisted-by: LLM
> Signed-off-by: Jared Wuerzburger <jwuerz@gmail.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-09-28 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 22:05 [PATCH v3 0/2] iio: imu: st_lsm6dsx: Add ACPI ID SMOCF05 (Minisforum V3 / V3 SE) Jared Wuerzburger
2026-09-27 22:05 ` [PATCH v3 1/2] iio: imu: st_lsm6dsx: Drop trailing comma in ACPI match table entries Jared Wuerzburger
2026-09-28 9:09 ` Andy Shevchenko
2026-09-27 22:05 ` [PATCH v3 2/2] iio: imu: st_lsm6dsx: Add ACPI ID SMOCF05 for LSM6DS3TR-C Jared Wuerzburger
2026-09-28 9:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arovrVYSgU64DM5o@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jwuerz@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nuno.sa@analog.com \
--cc=samuel@dionne-riel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®