mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Yu <yu.c.chen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: <tony.luck@intel.com>, <tglx@kernel.org>, <bp@alien8.de>,
	<mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<hpa@zytor.com>, <fenghuay@nvidia.com>, <babu.moger@amd.com>,
	<hongyu.ning@intel.com>, <chen.yu@linux.dev>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Hongyu Ning" <hongyu.ning@linux.intel.com>
Subject: Re: [PATCH v8 7/9] fs/resctrl: Do not invoke smp_processor_id() in preemptible context
Date: Sun, 4 Oct 2026 13:54:20 +0800	[thread overview]
Message-ID: <asHqDEBauXwTFo0c@chenyu-dev> (raw)
In-Reply-To: <432f616b-314f-4b46-bfa0-28759a493cae@intel.com>

Hi Reinette,

On Mon, Sep 28, 2026 at 02:48:12PM -0700, Reinette Chatre wrote:
> Hi Chenyu,
> 
> On 9/17/26 9:50 PM, Chen Yu wrote:
> > From: Tony Luck <tony.luck@intel.com>
> > 
> > An event flagged with mon_evt::any_cpu is read directly in preemptible task
> > context instead of being dispatched to a CPU of the monitoring domain. Only
> > Intel AET events set this flag, so __mon_event_count() rejects an any_cpu L3
> > event with WARN_ON_ONCE(). The L3 read paths can therefore call
> > smp_processor_id() unconditionally to check that the current CPU belongs to the
> > domain being read.
> > 
> > MMIO-based LLC occupancy counters can be read from any CPU, so the L3 read
> > paths have to tolerate an any_cpu event. Move that check into a helper which
> > returns early for any_cpu events, avoiding smp_processor_id() in preemptible
> > context, and report a wrong CPU via rmid_read::err.
> 
> "report a wrong CPU via rmid_read::err" is obvious from the patch.
>

OK, will remove this.

> >  
> > +/**
> > + * cpu_on_correct_domain() - Check if current CPU is in the correct
> > + *			      domain for the event.
> 
> The domain is not always relevant. When considering "Return: true if the
> current CPU can read this event" ... could something like "cpu_can_read_event()"
> be more descriptive? 
>

Yes, that is more accurate, let me rename it.

thanks,
Chenyu

  reply	other threads:[~2026-10-04  6:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  4:46 [PATCH v8 0/9] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-09-18  4:48 ` [PATCH v8 1/9] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-09-18  4:48 ` [PATCH v8 2/9] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-09-28 21:21   ` Reinette Chatre
2026-09-29 15:03     ` Chen Yu
2026-09-18  4:49 ` [PATCH v8 3/9] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask for RMDD domains Chen Yu
2026-09-28 21:37   ` Reinette Chatre
2026-09-29 10:32     ` Chen Yu
2026-09-29 15:40       ` Reinette Chatre
2026-09-18  4:50 ` [PATCH v8 4/9] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-09-28 21:44   ` Reinette Chatre
2026-09-29 14:52     ` Chen Yu
2026-09-18  4:50 ` [PATCH v8 5/9] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-09-28 21:46   ` Reinette Chatre
2026-10-04  4:34     ` Chen Yu
2026-09-18  4:50 ` [PATCH v8 6/9] x86/resctrl: Refactor the monitor read function Chen Yu
2026-09-18  4:50 ` [PATCH v8 7/9] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-09-28 21:48   ` Reinette Chatre
2026-10-04  5:54     ` Chen Yu [this message]
2026-09-18  4:51 ` [PATCH v8 8/9] x86/resctrl: Introduce erdt_cpu_has() and erdt_support() Chen Yu
2026-09-28 21:49   ` Reinette Chatre
2026-09-18  4:51 ` [PATCH v8 9/9] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
2026-09-28 21:54   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asHqDEBauXwTFo0c@chenyu-dev \
    --to=yu.c.chen@intel.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=chen.yu@linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=hongyu.ning@intel.com \
    --cc=hongyu.ning@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®