* [PATCH] dt-bindings: phy: ti,tcan104x-can: Fixup unapplied constraint to ti,tcan1042 family
@ 2026-09-18 11:01 Krzysztof Kozlowski
2026-09-18 21:31 ` Rob Herring (Arm)
2026-10-05 9:35 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-18 11:01 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul, Neil Armstrong,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Aswath Govindraju, linux-can, linux-phy,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
ti,tcan1042 is also used as fallback for a few devices, thus the check
in "if:" conditional should use "contains" to properly validate these
other devices. The other compatibles used in the changed enum are used
alone, so it does not affect them.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/phy/ti,tcan104x-can.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
index 9f5c37ca6496..0cf5fa21106b 100644
--- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -71,10 +71,11 @@ allOf:
- if:
properties:
compatible:
- enum:
- - nxp,tjr1443
- - ti,tcan1042
- - ti,tcan1043
+ contains:
+ enum:
+ - nxp,tjr1443
+ - ti,tcan1042
+ - ti,tcan1043
then:
properties:
'#phy-cells':
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: phy: ti,tcan104x-can: Fixup unapplied constraint to ti,tcan1042 family
2026-09-18 11:01 [PATCH] dt-bindings: phy: ti,tcan104x-can: Fixup unapplied constraint to ti,tcan1042 family Krzysztof Kozlowski
@ 2026-09-18 21:31 ` Rob Herring (Arm)
2026-10-05 9:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-09-18 21:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Neil Armstrong, Marc Kleine-Budde, linux-phy,
Krzysztof Kozlowski, Manivannan Sadhasivam, Aswath Govindraju,
Vincent Mailhol, linux-kernel, Conor Dooley, Vinod Koul,
linux-can
On Fri, 18 Sep 2026 13:01:17 +0200, Krzysztof Kozlowski wrote:
> ti,tcan1042 is also used as fallback for a few devices, thus the check
> in "if:" conditional should use "contains" to properly validate these
> other devices. The other compatibles used in the changed enum are used
> alone, so it does not affect them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: ti,tcan104x-can: Fixup unapplied constraint to ti,tcan1042 family
2026-09-18 11:01 [PATCH] dt-bindings: phy: ti,tcan104x-can: Fixup unapplied constraint to ti,tcan1042 family Krzysztof Kozlowski
2026-09-18 21:31 ` Rob Herring (Arm)
@ 2026-10-05 9:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-10-05 9:35 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Marc Kleine-Budde, Vincent Mailhol, Neil Armstrong,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Aswath Govindraju, linux-can, linux-phy,
devicetree, linux-kernel
On 18-09-26, 13:01, Krzysztof Kozlowski wrote:
> ti,tcan1042 is also used as fallback for a few devices, thus the check
> in "if:" conditional should use "contains" to properly validate these
> other devices. The other compatibles used in the changed enum are used
> alone, so it does not affect them.
looks duplicate of c7f2322431cb ("dt-bindings: phy: ti,tcan104x-can: Fix
property constrains") ? if not please rebase on this and send
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-05 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 11:01 [PATCH] dt-bindings: phy: ti,tcan104x-can: Fixup unapplied constraint to ti,tcan1042 family Krzysztof Kozlowski
2026-09-18 21:31 ` Rob Herring (Arm)
2026-10-05 9:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®