[PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources

[PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources

[Amit Sunil Dhamne via B4 Relay]

As per Sec. 4.6.2.1 of the Type-C cable & connector spec when the
source advertises Rp-default, the current limit is set as per the
USB 2.0/USB 3.2 specification, BC1.2 specification as applicable or the
PD negotiation.

Reset value for the Input Current Limit register for the MAX77759
charger is 500 mA. Prior to the max77759_charger driver, the battery
would always charge at that limit since it wasn't re-programmed. Since
the driver was introduced, for any non-PD source advertising Rp-default,
the charger turns off as tcpm reports the current limit to be 0. The
max77759_charger driver reads POWER_SUPPLY_PROP_CURRENT_MAX from the
"tcpm-source" power supply that tcpm_set_current_limit() updates, and
programs its input current limit from it. The limit is 0 because the
tcpm doesn't have visibility on the USB data speed or BC1.2 detection.
As a workaround for the Rp-default case, let the Type-C stack report a
USB 2.0 current limit of 500 mA so that the behavior is at parity with
what was before. This is until we implement a conduit for USB core to
communicate with the Type-C stack.

Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
---
Amit Sunil Dhamne (3):
      usb: typec: tcpm: only call get_current_limit() for cc=Rp-def
      usb: typec: tcpci: implement get_current_limit
      usb: typec: tcpci_maxim: implement get_current_limit

 drivers/usb/typec/tcpm/tcpci.c            | 14 ++++++++++++++
 drivers/usb/typec/tcpm/tcpci_maxim_core.c | 15 +++++++++++++++
 drivers/usb/typec/tcpm/tcpm.c             |  7 +++----
 include/linux/usb/tcpci.h                 |  6 ++++++
 4 files changed, 38 insertions(+), 4 deletions(-)
---
base-commit: 551c722f40809618230001baccf219193e22fc5a
change-id: 20260918-max77759-icl-typec-8dfb9f83d712

Best regards,
-- 
Amit Sunil Dhamne <amitsd@google.com>

[PATCH 1/3] usb: typec: tcpm: only call get_current_limit() for cc=Rp-def

[Amit Sunil Dhamne via B4 Relay]

From: Amit Sunil Dhamne <amitsd@google.com>

tcpm_get_current_limit() folds the default label into the
TYPEC_CC_RP_DEF case, so tcpc_dev::get_current_limit() is also called
for CC states that do not advertise Rp, such as TYPEC_CC_OPEN,
TYPEC_CC_RA and TYPEC_CC_RD. Its kerneldoc has always scoped it to
cc=Rp-def:

  @get_current_limit:
          Optional; called by the tcpm core when configured as a snk
          and cc=Rp-def. This allows the tcpm to provide a fallback
          current-limit detection method for the cc=Rp-def case.

A chip driver has nothing to interpret in the other states. Therefore,
split the cases and report 0 when CC is not an Rp.

Assisted-by: LLM
Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
---
 drivers/usb/typec/tcpm/tcpm.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 2d6b14aa20856..2e7371ada8642 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -1268,7 +1268,7 @@ static int tcpm_set_vconn(struct tcpm_port *port, bool enable)
 static u32 tcpm_get_current_limit(struct tcpm_port *port)
 {
 	enum typec_cc_status cc;
-	u32 limit;
+	u32 limit = 0;
 
 	cc = port->polarity ? port->cc2 : port->cc1;
 	switch (cc) {
@@ -1279,11 +1279,10 @@ static u32 tcpm_get_current_limit(struct tcpm_port *port)
 		limit = 3000;
 		break;
 	case TYPEC_CC_RP_DEF:
-	default:
 		if (port->tcpc->get_current_limit)
 			limit = port->tcpc->get_current_limit(port->tcpc);
-		else
-			limit = 0;
+		break;
+	default:
 		break;
 	}
 

-- 
2.56.0.rc1.315.gc6ed9934b7-goog

Re: [PATCH 1/3] usb: typec: tcpm: only call get_current_limit() for cc=Rp-def

[André Draszik]

Hi Amit,

On Thu, 2026-10-01 at 22:51 +0000, Amit Sunil Dhamne via B4 Relay wrote:
> From: Amit Sunil Dhamne <amitsd@google.com>
> 
> tcpm_get_current_limit() folds the default label into the
> TYPEC_CC_RP_DEF case, so tcpc_dev::get_current_limit() is also called
> for CC states that do not advertise Rp, such as TYPEC_CC_OPEN,
> TYPEC_CC_RA and TYPEC_CC_RD. Its kerneldoc has always scoped it to
> cc=Rp-def:
> 
>   @get_current_limit:
>           Optional; called by the tcpm core when configured as a snk
>           and cc=Rp-def. This allows the tcpm to provide a fallback
>           current-limit detection method for the cc=Rp-def case.
> 
> A chip driver has nothing to interpret in the other states. Therefore,
> split the cases and report 0 when CC is not an Rp.
> 
> Assisted-by: LLM
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
>  drivers/usb/typec/tcpm/tcpm.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 2d6b14aa20856..2e7371ada8642 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1268,7 +1268,7 @@ static int tcpm_set_vconn(struct tcpm_port *port, bool enable)
>  static u32 tcpm_get_current_limit(struct tcpm_port *port)
>  {
>  	enum typec_cc_status cc;
> -	u32 limit;
> +	u32 limit = 0;

Greedy init is usually not recommended, as it prevents the compiler from
warning about use of a variable without initialising a useful value.

Cheers,
Andre'

>  
>  	cc = port->polarity ? port->cc2 : port->cc1;
>  	switch (cc) {
> @@ -1279,11 +1279,10 @@ static u32 tcpm_get_current_limit(struct tcpm_port *port)
>  		limit = 3000;
>  		break;
>  	case TYPEC_CC_RP_DEF:
> -	default:
>  		if (port->tcpc->get_current_limit)
>  			limit = port->tcpc->get_current_limit(port->tcpc);
> -		else
> -			limit = 0;
> +		break;
> +	default:
>  		break;
>  	}
>  

[PATCH 2/3] usb: typec: tcpci: implement get_current_limit

[Amit Sunil Dhamne via B4 Relay]

From: Amit Sunil Dhamne <amitsd@google.com>

Implement a callback for tcpc_dev::get_current_limit. This acts like a
conduit to relay the current limit information from chip level tcpc
drivers.

This does not introduce any functional changes for chip level drivers
that do not implement tcpci_data::get_current_limit.

Assisted-by: LLM
Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
---
 drivers/usb/typec/tcpm/tcpci.c | 14 ++++++++++++++
 include/linux/usb/tcpci.h      |  6 ++++++
 2 files changed, 20 insertions(+)

diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
index 6717ac914c6a6..f1bc1ac0a5561 100644
--- a/drivers/usb/typec/tcpm/tcpci.c
+++ b/drivers/usb/typec/tcpm/tcpci.c
@@ -250,6 +250,19 @@ static int tcpci_get_cc(struct tcpc_dev *tcpc,
 	return 0;
 }
 
+static int tcpci_get_current_limit(struct tcpc_dev *tcpc)
+{
+	struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
+	int ret;
+
+	if (!tcpci->data->get_current_limit)
+		return 0;
+
+	ret = tcpci->data->get_current_limit(tcpci, tcpci->data);
+
+	return ret < 0 ? 0 : ret;
+}
+
 static int tcpci_set_polarity(struct tcpc_dev *tcpc,
 			      enum typec_cc_polarity polarity)
 {
@@ -861,6 +874,7 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data)
 	tcpci->tcpc.set_cc = tcpci_set_cc;
 	tcpci->tcpc.apply_rc = tcpci_apply_rc;
 	tcpci->tcpc.get_cc = tcpci_get_cc;
+	tcpci->tcpc.get_current_limit = tcpci_get_current_limit;
 	tcpci->tcpc.set_polarity = tcpci_set_polarity;
 	tcpci->tcpc.set_vconn = tcpci_set_vconn;
 	tcpci->tcpc.start_toggling = tcpci_start_toggling;
diff --git a/include/linux/usb/tcpci.h b/include/linux/usb/tcpci.h
index 9b46a6bc762cc..580fbdac7ede0 100644
--- a/include/linux/usb/tcpci.h
+++ b/include/linux/usb/tcpci.h
@@ -205,6 +205,11 @@ struct tcpci;
  *		swap following Discover Identity on SOP' occurs.
  *		Return true when the TCPM is allowed to request a Vconn swap
  *		after Discovery Identity on SOP.
+ * @get_current_limit:
+ *		Optional; Called when the port is a sink and CC=Rp-def to obtain
+ *		the current limit. Chip level drivers can implement their own
+ *		detection and return the limit in mA, or 0 when it cannot be
+ *		determined.
  * @set_orientation:
  *		Optional; Enable setting the connector orientation
  *		CONFIG_STANDARD_OUTPUT (0x18) bit0.
@@ -228,6 +233,7 @@ struct tcpci_data {
 					     bool capable);
 	void (*check_contaminant)(struct tcpci *tcpci, struct tcpci_data *data);
 	bool (*attempt_vconn_swap_discovery)(struct tcpci *tcpci, struct tcpci_data *data);
+	int (*get_current_limit)(struct tcpci *tcpci, struct tcpci_data *data);
 };
 
 struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data);

-- 
2.56.0.rc1.315.gc6ed9934b7-goog

[PATCH 3/3] usb: typec: tcpci_maxim: implement get_current_limit

[Amit Sunil Dhamne via B4 Relay]

From: Amit Sunil Dhamne <amitsd@google.com>

Implement tcpci_data::get_current_limit for tcpci_maxim driver to report
a value of 500 mA unconditionally. This is the max current a configured
USB 2.0 device may draw per the USB Type-C Cable and Connector
Specification r2.2, Sec. 4.6.2.1. This helps set a current limit and
thus enable charging for the cases when a port is connected to a non-PD
Type-C port partner advertising Rp-def. This is until a mechanism for
USB core to communicate the current limit to the TCPC driver is
implemented.

Assisted-by: LLM
Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
---
 drivers/usb/typec/tcpm/tcpci_maxim_core.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
index 998693a618393..e6f825931ba0b 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
@@ -482,6 +482,20 @@ static bool max_tcpci_attempt_vconn_swap_discovery(struct tcpci *tcpci, struct t
 	return true;
 }
 
+/*
+ * This callback is used by the TCPM to determine the current limit to set when
+ * Rp-def is advertised on the CC pins. The actual current limit comes from
+ * other subsystems such as the USB gadget/host stack (USB 2.0/USB 3.2) and
+ * BC1.2. As a workaround, report the USB 2.0 current limit of 500 mA to enable
+ * charging when the device is connected to a non-PD source advertising Rp-def.
+ * This can be removed once a mechanism for the USB core to communicate the
+ * current limit to this driver is implemented.
+ */
+static int max_tcpci_get_current_limit(struct tcpci *tcpci, struct tcpci_data *tdata)
+{
+	return 500;
+}
+
 static void max_tcpci_unregister_tcpci_port(void *tcpci)
 {
 	tcpci_unregister_port(tcpci);
@@ -523,6 +537,7 @@ static int max_tcpci_probe(struct i2c_client *client)
 	chip->data.check_contaminant = max_tcpci_check_contaminant;
 	chip->data.cable_comm_capable = true;
 	chip->data.attempt_vconn_swap_discovery = max_tcpci_attempt_vconn_swap_discovery;
+	chip->data.get_current_limit = max_tcpci_get_current_limit;
 
 	max_tcpci_init_regs(chip);
 	chip->tcpci = tcpci_register_port(chip->dev, &chip->data);

-- 
2.56.0.rc1.315.gc6ed9934b7-goog

Re: [PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources

[Heikki Krogerus]

On Thu, Oct 01, 2026 at 10:51:12PM +0000, Amit Sunil Dhamne via B4 Relay wrote:
> As per Sec. 4.6.2.1 of the Type-C cable & connector spec when the
> source advertises Rp-default, the current limit is set as per the
> USB 2.0/USB 3.2 specification, BC1.2 specification as applicable or the
> PD negotiation.
> 
> Reset value for the Input Current Limit register for the MAX77759
> charger is 500 mA. Prior to the max77759_charger driver, the battery
> would always charge at that limit since it wasn't re-programmed. Since
> the driver was introduced, for any non-PD source advertising Rp-default,
> the charger turns off as tcpm reports the current limit to be 0. The
> max77759_charger driver reads POWER_SUPPLY_PROP_CURRENT_MAX from the
> "tcpm-source" power supply that tcpm_set_current_limit() updates, and
> programs its input current limit from it. The limit is 0 because the
> tcpm doesn't have visibility on the USB data speed or BC1.2 detection.
> As a workaround for the Rp-default case, let the Type-C stack report a
> USB 2.0 current limit of 500 mA so that the behavior is at parity with
> what was before. This is until we implement a conduit for USB core to
> communicate with the Type-C stack.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
> Amit Sunil Dhamne (3):
>       usb: typec: tcpm: only call get_current_limit() for cc=Rp-def
>       usb: typec: tcpci: implement get_current_limit
>       usb: typec: tcpci_maxim: implement get_current_limit
> 
>  drivers/usb/typec/tcpm/tcpci.c            | 14 ++++++++++++++
>  drivers/usb/typec/tcpm/tcpci_maxim_core.c | 15 +++++++++++++++
>  drivers/usb/typec/tcpm/tcpm.c             |  7 +++----
>  include/linux/usb/tcpci.h                 |  6 ++++++
>  4 files changed, 38 insertions(+), 4 deletions(-)
> ---
> base-commit: 551c722f40809618230001baccf219193e22fc5a
> change-id: 20260918-max77759-icl-typec-8dfb9f83d712
> 
> Best regards,
> -- 
> Amit Sunil Dhamne <amitsd@google.com>

For the series:

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

-- 
heikki

Re: [PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources

[Heikki Krogerus]

On Fri, Oct 09, 2026 at 01:19:44PM +0200, Heikki Krogerus wrote:
> On Thu, Oct 01, 2026 at 10:51:12PM +0000, Amit Sunil Dhamne via B4 Relay wrote:
> > As per Sec. 4.6.2.1 of the Type-C cable & connector spec when the
> > source advertises Rp-default, the current limit is set as per the
> > USB 2.0/USB 3.2 specification, BC1.2 specification as applicable or the
> > PD negotiation.
> > 
> > Reset value for the Input Current Limit register for the MAX77759
> > charger is 500 mA. Prior to the max77759_charger driver, the battery
> > would always charge at that limit since it wasn't re-programmed. Since
> > the driver was introduced, for any non-PD source advertising Rp-default,
> > the charger turns off as tcpm reports the current limit to be 0. The
> > max77759_charger driver reads POWER_SUPPLY_PROP_CURRENT_MAX from the
> > "tcpm-source" power supply that tcpm_set_current_limit() updates, and
> > programs its input current limit from it. The limit is 0 because the
> > tcpm doesn't have visibility on the USB data speed or BC1.2 detection.
> > As a workaround for the Rp-default case, let the Type-C stack report a
> > USB 2.0 current limit of 500 mA so that the behavior is at parity with
> > what was before. This is until we implement a conduit for USB core to
> > communicate with the Type-C stack.
> > 
> > Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> > ---
> > Amit Sunil Dhamne (3):
> >       usb: typec: tcpm: only call get_current_limit() for cc=Rp-def
> >       usb: typec: tcpci: implement get_current_limit
> >       usb: typec: tcpci_maxim: implement get_current_limit
> > 
> >  drivers/usb/typec/tcpm/tcpci.c            | 14 ++++++++++++++
> >  drivers/usb/typec/tcpm/tcpci_maxim_core.c | 15 +++++++++++++++
> >  drivers/usb/typec/tcpm/tcpm.c             |  7 +++----
> >  include/linux/usb/tcpci.h                 |  6 ++++++
> >  4 files changed, 38 insertions(+), 4 deletions(-)
> > ---
> > base-commit: 551c722f40809618230001baccf219193e22fc5a
> > change-id: 20260918-max77759-icl-typec-8dfb9f83d712
> > 
> > Best regards,
> > -- 
> > Amit Sunil Dhamne <amitsd@google.com>
> 
> For the series:
> 
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Sorry, there's v2. Please ignore this ACK.

-- 
heikki