From: Andy Chiu <tchiu@tenstorrent.com>
To: "Radim Krcmár" <radim.krcmar@oss.qualcomm.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Samuel Holland <samuel.holland@sifive.com>,
Andy Chiu <andybnac@gmail.com>, Guodong Xu <guodong@riscstar.com>,
Zong Li <zong.li@sifive.com>,
Charlie Jenkins <thecharlesjenkins@gmail.com>
Subject: Re: [PATCH 2/6] riscv: hwprobe: Report Zicbom and Zicboz only when available
Date: Fri, 16 Oct 2026 16:06:56 -0500 [thread overview]
Message-ID: <atKR8HnbkSf_xZAm@Tao-Chiu's-Mac> (raw)
In-Reply-To: <20261006075303.205216-3-radim.krcmar@oss.qualcomm.com>
On Tue, Oct 06, 2026 at 09:52:59AM +0200, Radim Krcmár wrote:
> User-mode use of Zicbom and Zicboz requires senvcfg.CBCFE and
> senvcfg.CBZE, respectively, which we set only when all harts have the
> extension. hwprobe reports the extensions from the per-hart ISA bitmaps
> alone, so it can advertise extensions that are always disabled in
> user-mode.
>
> Report correct environment to user-mode.
>
> Fixes: 1b57747e978f ("riscv: Enable cbo.zero only when all harts support Zicboz")
> Fixes: eb1003970940 ("RISC-V: hwprobe: Expose Zicbom extension and its block size")
> Signed-off-by: Radim Krcmár <radim.krcmar@oss.qualcomm.com>
Reviewed-by: Andy Chiu <tchiu@tenstorrent.com>
> ---
> arch/riscv/kernel/sys_hwprobe.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hwprobe.c
> index b57ccd116bb1..c74e36e8fcdd 100644
> --- a/arch/riscv/kernel/sys_hwprobe.c
> +++ b/arch/riscv/kernel/sys_hwprobe.c
> @@ -91,6 +91,12 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair,
> if (has_vector() && riscv_isa_extension_available(NULL, V))
> pair->value |= RISCV_HWPROBE_IMA_V;
>
> + if (riscv_isa_extension_available(NULL, ZICBOM))
> + pair->value |= RISCV_HWPROBE_EXT_ZICBOM;
> +
> + if (riscv_isa_extension_available(NULL, ZICBOZ))
> + pair->value |= RISCV_HWPROBE_EXT_ZICBOZ;
> +
> /*
> * Loop through and record extensions that 1) anyone has, and 2) anyone
> * doesn't have.
> @@ -120,9 +126,7 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair,
> EXT_KEY(isainfo->isa, ZCB, pair->value, missing);
> EXT_KEY(isainfo->isa, ZCLSD, pair->value, missing);
> EXT_KEY(isainfo->isa, ZCMOP, pair->value, missing);
> - EXT_KEY(isainfo->isa, ZICBOM, pair->value, missing);
> EXT_KEY(isainfo->isa, ZICBOP, pair->value, missing);
> - EXT_KEY(isainfo->isa, ZICBOZ, pair->value, missing);
> EXT_KEY(isainfo->isa, ZICFILP, pair->value, missing);
> EXT_KEY(isainfo->isa, ZICNTR, pair->value, missing);
> EXT_KEY(isainfo->isa, ZICOND, pair->value, missing);
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-10-16 21:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 7:52 [PATCH 0/6] riscv: hwprobe: do not report disabled extensions Radim Krčmář
2026-10-06 7:52 ` [PATCH 1/6] riscv: hwprobe: Report FP extensions only when available Radim Krčmář
2026-10-06 23:54 ` Charlie Jenkins
2026-10-07 7:46 ` Radim Krčmář
2026-10-07 8:05 ` Charlie Jenkins
2026-10-16 21:04 ` Andy Chiu
2026-10-06 7:52 ` [PATCH 2/6] riscv: hwprobe: Report Zicbom and Zicboz " Radim Krčmář
2026-10-16 4:28 ` Charlie Jenkins
2026-10-16 21:06 ` Andy Chiu [this message]
2026-10-06 7:53 ` [PATCH 3/6] riscv: hwprobe: Report Zicfilp and Zicfiss " Radim Krčmář
2026-10-16 4:28 ` Charlie Jenkins
2026-10-16 21:09 ` Andy Chiu
2026-10-06 7:53 ` [PATCH 4/6] riscv: hwprobe: Report Supm " Radim Krčmář
2026-10-16 4:28 ` Charlie Jenkins
2026-10-16 21:26 ` Andy Chiu
2026-10-16 21:45 ` Andy Chiu
2026-10-06 7:53 ` [PATCH 5/6] riscv: hwprobe: Report XTheadVector " Radim Krčmář
2026-10-06 23:54 ` Charlie Jenkins
2026-10-07 7:59 ` Radim Krčmář
2026-10-07 8:07 ` Charlie Jenkins
2026-10-16 21:48 ` Andy Chiu
2026-10-06 7:53 ` [PATCH 6/6] riscv: hwprobe: Report SiFive vector extensions " Radim Krčmář
2026-10-16 21:55 ` Andy Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='atKR8HnbkSf_xZAm@Tao-Chiu'\''s-Mac' \
--to=tchiu@tenstorrent.com \
--cc=alex@ghiti.fr \
--cc=andybnac@gmail.com \
--cc=guodong@riscstar.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=radim.krcmar@oss.qualcomm.com \
--cc=samuel.holland@sifive.com \
--cc=thecharlesjenkins@gmail.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®