[PATCH] staging: media: atomisp: Fix double blank line

[PATCH] staging: media: atomisp: Fix double blank line

[Lorena Tanase]

Removed blank line to ensure linux kernel coding style. Found using
checkpatch.pl script.

Cc: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Lorena Tanase <tanaselorena3@gmail.com>
---
 .../media/atomisp/pci/hive_isp_css_common/host/input_system.c    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 68b0ad27615d..66311ab4880a 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -6,7 +6,6 @@
 
 #include "system_global.h"
 
-
 #include "input_system.h"
 #include <type_support.h>
 #include "gp_device.h"
-- 
2.43.0

Re: [PATCH] staging: media: atomisp: Fix double blank line

[Andy Shevchenko]

On Fri, Oct 23, 2026 at 03:31:58PM +0300, Lorena Tanase wrote:
> Removed blank line to ensure linux kernel coding style. Found using
> checkpatch.pl script.

Cool, but is this the only problem in the driver?

> Cc: Daniel Baluta <daniel.baluta@nxp.com>

Please, put the Cc list after the '---' line, so it won't pollute commit
message.

> Signed-off-by: Lorena Tanase <tanaselorena3@gmail.com>
> ---

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: media: atomisp: Fix double blank line

[Daniel Baluta]

On 10/23/26 16:55, Andy Shevchenko wrote:
> On Fri, Oct 23, 2026 at 03:31:58PM +0300, Lorena Tanase wrote:
>> Removed blank line to ensure linux kernel coding style. Found using
>> checkpatch.pl script.
> 
> Cool, but is this the only problem in the driver?

Not the only problem but as a first patch for a newcomer we want
to learn the process of submitting a simple patch so we keep it simple.

Then will expand to send patchseries. 

> 
>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> 
> Please, put the Cc list after the '---' line, so it won't pollute commit
> message.

Didn't know about this rule, there are thousands of patches in the Linux kernel log
with the Cc field added there. 

> 
>> Signed-off-by: Lorena Tanase <tanaselorena3@gmail.com>
>> ---
> 

Re: [PATCH] staging: media: atomisp: Fix double blank line

[Dan Carpenter]

On Fri, Oct 23, 2026 at 05:09:55PM +0300, Daniel Baluta wrote:
> On 10/23/26 16:55, Andy Shevchenko wrote:
> > On Fri, Oct 23, 2026 at 03:31:58PM +0300, Lorena Tanase wrote:
> >> Removed blank line to ensure linux kernel coding style. Found using
> >> checkpatch.pl script.
> > 
> > Cool, but is this the only problem in the driver?
> 
> Not the only problem but as a first patch for a newcomer we want
> to learn the process of submitting a simple patch so we keep it simple.
> 
> Then will expand to send patchseries. 
> 
> > 
> >> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > 
> > Please, put the Cc list after the '---' line, so it won't pollute commit
> > message.
> 
> Didn't know about this rule, there are thousands of patches in the Linux kernel log
> with the Cc field added there. 

It's the more modern trend.  It's was never clear to me what the Cc tag
was there fore...

regards,
dan carpenter