Re: [PATCH v6 02/10] drm/panel: Convert Hitachi TX10D07VM0BAA to use MIPI DBI bus

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]

On Fri, Nov 06, 2026 at 04:00:45PM +0200, Svyatoslav Ryhel wrote:
> пт, 6 лист. 2026 р. о 15:19 Thierry Reding <thierry.reding@kernel.org> пише:
> >
> > On Thu, Nov 05, 2026 at 04:05:02PM +0200, Svyatoslav Ryhel wrote:
> > > Switch from a generic platform driver to a dedicated MIPI DBI driver.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > ---
> > >  .../drm/panel/panel-hitachi-tx10d07vm0baa.c   | 167 ++++++++----------
> > >  1 file changed, 78 insertions(+), 89 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c b/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c
> > > index 83c2af1be9755..d5d7ba2096608 100644
> > > --- a/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c
> > > +++ b/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c
> > > @@ -14,6 +14,7 @@
> > >  #include <video/mipi_display.h>
> > >
> > >  #include <drm/drm_mipi_dbi.h>
> > > +#include <drm/drm_mipi_dbi_bus.h>
> > >  #include <drm/drm_modes.h>
> > >  #include <drm/drm_of.h>
> > >  #include <drm/drm_panel.h>
> > > @@ -25,7 +26,7 @@ static const struct regulator_bulk_data hitachi_tx10d07vm0baa_supplies[] = {
> > >
> > >  struct hitachi_tx10d07vm0baa {
> > >       struct drm_panel panel;
> > > -     struct mipi_dbi *dbi;
> > > +     struct mipi_dbi_device *dbi;
> >
> > It's somewhat difficult to exactly see the difference between mipi_dbi
> > and mipi_dbi_device. Maybe that should be explained better in the cover
> > letter of patch 1? Or the documentation added in patch1.
> >
> 
> It is already documented in detail in the drm_mipi_dbi.h

That documents what the struct mipi_dbi is. I'm asking about the
difference between mipi_dbi_device and mipi_dbi and mipi_dbi_dev. It's
not clear to me why we have both mipi_dbi_device *and* mipi_dbi_dev,
especially since they're very similarly named. People are going to
easily confuse where to use which.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]