Re: [PATCH v6 06/10] drm/tegra: Make panel parsing by tegra_output_probe() optional

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]

On Fri, Nov 06, 2026 at 04:09:36PM +0200, Svyatoslav Ryhel wrote:
> пт, 6 лист. 2026 р. о 16:00 Thierry Reding <thierry.reding@kernel.org> пише:
> >
> > On Thu, Nov 05, 2026 at 04:05:06PM +0200, Svyatoslav Ryhel wrote:
> > > The tegra_output_probe() performs panel parsing unconditionally, even for
> > > devices that do not require it (such as HDMI) or that handle panel parsing
> > > on their own (like DSI). Make panel parsing configurable.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > ---
> > >  drivers/gpu/drm/tegra/drm.h    |  2 +-
> > >  drivers/gpu/drm/tegra/dsi.c    |  2 +-
> > >  drivers/gpu/drm/tegra/hdmi.c   |  2 +-
> > >  drivers/gpu/drm/tegra/output.c | 52 ++++++++++++++++++----------------
> > >  drivers/gpu/drm/tegra/rgb.c    |  2 +-
> > >  drivers/gpu/drm/tegra/sor.c    |  2 +-
> > >  6 files changed, 32 insertions(+), 30 deletions(-)
> >
> > Does it break anything to try and parse this even when it's not needed?
> > In all cases we error out early, so there shouldn't be a whole lot of
> > extra overhead either.
> >
> > Adding this extra parameter just adds extra complexity for seemingly no
> > benefit.
> >
> 
> Dual DSI panel fail for Xiaomi Mi Pad. Maybe you should check your
> email a bit more often?

What's with the passive aggressivity?

> https://lore.kernel.org/lkml/20260305161035.64548-1-clamor95@gmail.com/#t

That's a thread from over half a year ago. I don't usually keep track of
email from that long ago.

Also, I asked previously if this broke anything. If it does, then the
commit message should say so to make it obvious that this is an actual
fix. And it should explain the problem so people can think about the
problem and judge whether this is a proper solution or not.

Your commit message doesn't mention any of this and makes it look like
you're trying to micro-optimize for no reason.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]