Re: [PATCH v15 01/16] cxl: Drop stale decoder interleave limit comment

[Alison Schofield <alison.schofield@intel.com>]

On Sun, Oct 11, 2026 at 02:14:07AM +0000, Srirangan Madhavan wrote:
> CXL 2.0 added 16-way memory interleaving, making the comment that the
> specification supports only 8-way interleaving stale. Remove the comment
> without changing CXL_DECODER_MAX_INTERLEAVE.
> 
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Link: https://lore.kernel.org/linux-cxl/20260912003057.3db9335c@jic23-hlaptop/
> Signed-off-by: Srirangan Madhavan <smadhavan@nvidia.com>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Richard Cheng <icheng@nvidia.com>
> Reviewed-by: Li Ming <ming.li@zohomail.com>
> ---
>  drivers/cxl/cxl.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 3ef0810ab86b..9e0500d56866 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -269,10 +269,6 @@ enum cxl_decoder_type {
>  	CXL_DECODER_HOSTONLYMEM = 3,
>  };
>  
> -/*
> - * Current specification goes up to 8, double that seems a reasonable
> - * software max for the foreseeable future
> - */
>  #define CXL_DECODER_MAX_INTERLEAVE 16

How about telling folks where that 16 comes from?
(lest someone think its a software defined limitation)

/* 16 is the largest interleave a decoder can express (CXL 4.0 8.2.4.20.7) */


-- Alison


>  
>  #define CXL_QOS_CLASS_INVALID -1
> -- 
> 2.43.0
>