* [PATCH v1] ATA: ahci: Add Intel PCH-S RAID device ID
@ 2026-10-27 14:12 Roman Gardzinski
2026-10-27 15:29 ` Niklas Cassel
0 siblings, 1 reply; 2+ messages in thread
From: Roman Gardzinski @ 2026-10-27 14:12 UTC (permalink / raw)
To: dlemoal, cassel, szczepan.durawa, szymon.durawa, romanx.gardzinski
Cc: linux-ide, linux-kernel
Add support for SATA devices in RAID mode for Nova Lake.
No functional changes.
Suggested-by: Szczepan Durawa <szczepan.durawa@intel.com>
Reviewed-by: Szymon Durawa <szymon.durawa@linux.intel.com>
Signed-off-by: Roman Gardzinski <romanx.gardzinski@linux.intel.com>
---
drivers/ata/ahci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 9b8c0935001c..c60e7ba24502 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -283,6 +283,10 @@ static const struct pci_device_id ahci_pci_tbl[] = {
/* Comet Lake PCH-H RAID */
PCI_VDEVICE(INTEL, 0x06d6),
.driver_data = board_ahci_pcs_quirk,
+ }, {
+ /* Nova Lake PCH-S RAID */
+ PCI_VDEVICE(INTEL, 0x6e66),
+ .driver_data = board_ahci_pcs_quirk,
}, {
/* ICH6 */
PCI_VDEVICE(INTEL, 0x2652),
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1] ATA: ahci: Add Intel PCH-S RAID device ID
2026-10-27 14:12 [PATCH v1] ATA: ahci: Add Intel PCH-S RAID device ID Roman Gardzinski
@ 2026-10-27 15:29 ` Niklas Cassel
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Cassel @ 2026-10-27 15:29 UTC (permalink / raw)
To: Roman Gardzinski
Cc: dlemoal, szczepan.durawa, szymon.durawa, linux-ide, linux-kernel
Hello Roman,
On Tue, Oct 27, 2026 at 03:12:40PM +0100, Roman Gardzinski wrote:
> Add support for SATA devices in RAID mode for Nova Lake.
> No functional changes.
>
> Suggested-by: Szczepan Durawa <szczepan.durawa@intel.com>
> Reviewed-by: Szymon Durawa <szymon.durawa@linux.intel.com>
> Signed-off-by: Roman Gardzinski <romanx.gardzinski@linux.intel.com>
> ---
> drivers/ata/ahci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 9b8c0935001c..c60e7ba24502 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -283,6 +283,10 @@ static const struct pci_device_id ahci_pci_tbl[] = {
> /* Comet Lake PCH-H RAID */
> PCI_VDEVICE(INTEL, 0x06d6),
> .driver_data = board_ahci_pcs_quirk,
> + }, {
> + /* Nova Lake PCH-S RAID */
> + PCI_VDEVICE(INTEL, 0x6e66),
> + .driver_data = board_ahci_pcs_quirk,
Commit message should probably say something like:
When the Intel Nova Lake SATA controller is configured in RAID mode (rather
than AHCI), the generic entry in ahci_pci_tbl which matches any device with
the PCI class code for AHCI, is not sufficient, since the SATA controller
in RAID mode uses a different PCI class code.
Like Sashiko also said, please also check if this entry (for RAID mode)
should use board_ahci_pcs_quirk or board_ahci.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-27 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-27 14:12 [PATCH v1] ATA: ahci: Add Intel PCH-S RAID device ID Roman Gardzinski
2026-10-27 15:29 ` Niklas Cassel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®