From: Chris Down <chris@chrisdown.name>
To: Petr Mladek <pmladek@suse.com>
Cc: John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Marcos Paulo de Souza <mpdesouza@suse.com>,
Naveen Kumar Chaudhary <naveen.osdev@gmail.com>,
linux-kernel@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v5 11/16] console/braille: Lock console->setup() call during the registration
Date: Thu, 29 Oct 2026 15:15:21 +0800 [thread overview]
Message-ID: <auLyiUrOsr7W8tuo@chrisdown.name> (raw)
In-Reply-To: <20260929120546.328616-12-pmladek@suse.com>
Petr Mladek writes:
>In braille_register_console(), the console->setup() callback must be
>called while holding the console_lock. This prevents a race condition
>with a possible active boot console that might be using the same hardware
>registers.
Acked-by: Chris Down <chris@chrisdown.name>
>index d780f6de303a..11d6b854ee63 100644
>--- a/include/linux/console.h
>+++ b/include/linux/console.h
>@@ -699,6 +699,7 @@ enum con_flush_mode {
> };
>
> extern int add_preferred_console(const char *name, const short idx, char *options);
>+extern int console_call_setup(struct console *newcon, char *options);
Hmm, now that console_call_setup() is global, a short comment saying it is only
meant for the Braille driver might discourage other users if you want. But not
a big deal either way.
next prev parent reply other threads:[~2026-10-29 7:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 12:05 [PATCH v5 00/16] printk: Clean up preferred console handling Petr Mladek
2026-09-29 12:05 ` [PATCH v5 01/16] printk: Rename struct console_cmdline to preferred_console Petr Mladek
2026-10-29 7:03 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 02/16] printk: Rename preferred_console to preferred_dev_console Petr Mladek
2026-09-29 12:05 ` [PATCH v5 03/16] printk: Cleanup _braille_(un)register_console() wrappers Petr Mladek
2026-09-29 12:05 ` [PATCH v5 04/16] printk: Separate code for adding/updating preferred console metadata Petr Mladek
2026-10-27 12:05 ` John Ogness
2026-10-29 7:05 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 05/16] printk: Prefer the console either via name or devname exclusively Petr Mladek
2026-10-27 12:14 ` John Ogness
2026-10-29 7:06 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 06/16] printk: Check that index is not defined when a console is preferred via devname Petr Mladek
2026-10-27 18:08 ` John Ogness
2026-10-29 7:07 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 07/16] printk: Ensure consistent name and devname when updating preferred console Petr Mladek
2026-10-29 7:09 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 08/16] printk: Do not quietly ignore adding entry for a preferred console when there is no space Petr Mladek
2026-10-29 7:10 ` Chris Down
2026-10-29 16:23 ` John Ogness
2026-09-29 12:05 ` [PATCH v5 09/16] printk: Allow to override options via the command line Petr Mladek
2026-10-29 7:13 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 10/16] printk: Allow to debug misuse of add_or_update_preferred_console() Petr Mladek
2026-10-29 7:13 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 11/16] console/braille: Lock console->setup() call during the registration Petr Mladek
2026-10-29 7:15 ` Chris Down [this message]
2026-09-29 12:05 ` [PATCH v5 12/16] printk: Separate code for enabling console Petr Mladek
2026-10-29 7:15 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 13/16] printk: Try to register each console as Braille first Petr Mladek
2026-10-29 7:17 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 14/16] printk: Do not set Braille console as preferred_console Petr Mladek
2026-10-29 7:19 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 15/16] printk: Modify try_enable_default_console() to return error/success Petr Mladek
2026-10-29 7:20 ` Chris Down
2026-09-29 12:05 ` [PATCH v5 16/16] printk: Try enable preferred consoles only when there are any Petr Mladek
2026-10-29 7:20 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auLyiUrOsr7W8tuo@chrisdown.name \
--to=chris@chrisdown.name \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=naveen.osdev@gmail.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sashiko-bot@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®