Re: [PATCH 07/10] irqchip/gic-v5: Use firmware node name in ITS warning

[Lorenzo Pieralisi <lpieralisi@kernel.org>]

On Mon, Nov 02, 2026 at 01:33:00PM +0000, Sascha Bischoff wrote:
> The common ITS initialiser can be called with an ACPI firmware node.
> If firmware leaves the ITS enabled, the warning dereferences the DT
> node pointer, which is NULL on that path.
> 
> Use the firmware node name for the warning and drop the DT-only pointer.
> 
> Fixes: a97efa5ba5946 ("irqchip/gic-v5: Add ACPI ITS probing")
> Signed-off-by: Sascha Bischoff <sascha.bischoff@arm.com>
> ---
>  drivers/irqchip/irq-gic-v5-its.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>

> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index c5d057f713134..8628de326f28d 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -1109,7 +1109,6 @@ static int gicv5_its_init_domain(struct gicv5_its_chip_data *its, struct irq_dom
>  static int __init gicv5_its_init_bases(void __iomem *its_base, struct fwnode_handle *handle,
>  				       struct irq_domain *parent_domain, bool noncoherent)
>  {
> -	struct device_node *np = to_of_node(handle);
>  	struct gicv5_its_chip_data *its_node;
>  	u32 cr0, cr1;
>  	bool enabled;
> @@ -1129,7 +1128,8 @@ static int __init gicv5_its_init_bases(void __iomem *its_base, struct fwnode_han
>  
>  	cr0 = its_readl_relaxed(its_node, GICV5_ITS_CR0);
>  	enabled = FIELD_GET(GICV5_ITS_CR0_ITSEN, cr0);
> -	if (WARN(enabled, "ITS %s enabled, disabling it before proceeding\n", np->full_name)) {
> +	if (WARN(enabled, "ITS %s enabled, disabling it before proceeding\n",
> +		 fwnode_get_name(handle))) {
>  		ret = gicv5_its_disable(its_node);
>  		if (ret)
>  			goto out_free_node;
> 
> -- 
> 2.34.1
>