From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Volodymyr Chapman <volodymyrchapman@gmail.com>
Cc: sakari.ailus@linux.intel.com, mchehab@kernel.org,
dan.scally@ideasonboard.com, hansg@kernel.org, andy@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera)
Date: Wed, 18 Nov 2026 13:37:23 +0200 [thread overview]
Message-ID: <av2N81gHOXYpaV-C@ashevche-desk.local> (raw)
In-Reply-To: <20261117175614.11710-1-volodymyrchapman@gmail.com>
On Tue, Nov 17, 2026 at 05:56:14PM +0000, Volodymyr Chapman wrote:
> Hi Andy,
>
> On Tue, Nov 17, 2026 at 12:08:07PM +0200, Andy Shevchenko wrote:
> > > Not supported: the voice coil motor (the firmware does not name its
> > > type) and the LM3554 flash.
> >
> > Why not flash? It's in the kernel provided by drivers/leds/leds-lm355x.c
>
> I should have mentioned that leds-lm355x cannot be used on this machine as
> it is: it only probes with platform data (it has no ACPI or DT matching,
> and nothing in the tree provides the platform data), it does not drive the
> LM3554's HWEN enable line, which has to be raised here before the chip
> responds, and it registers plain LED class devices rather than a flash
> LED class device.
>
> When atomisp's own LM3554 driver was removed in commit f1aa35ab5943
> ("media: atomisp: Drop the atomisp custom lm3554 flash driver"), the
> commit message said it should be re-implemented with the
> led-class-flash API if it turned out to be needed, so that is what I
> did. The new driver binds to the same ACPI ID (INTCF1C) and uses the
> same GPIO order (0 strobe, 1 torch, 2 enable) as the removed one.
>
> I have sent it to linux-leds:
>
> https://lore.kernel.org/linux-leds/20261116180809.26946-1-volodymyrchapman@gmail.com/
>
> Whether that or extending leds-lm355x is the better way is up to the LED
> maintainers; I will ask on that thread. In v2 of this series, I will reword
> the cover letter to point to it. The VCM has since turned out to be a
> DW9714 at the address listed in _CRS, and I have a follow-up patch for
> it which I can include in v2.
You still can mention that the AtomISP specific LM3554 driver was dropped and
the replacement should be developed from a scratch or using existing LEDS
driver as a base.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-18 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 17:51 Volodymyr Chapman
2026-11-16 17:51 ` [PATCH 1/3] media: i2c: Add Sony IMX175 sensor driver Volodymyr Chapman
2026-11-16 19:25 ` Dave Stevenson
2026-11-16 23:09 ` Volodymyr Chapman
2026-11-17 14:13 ` Uwe Kleine-König
2026-11-16 17:51 ` [PATCH 2/3] media: ipu-bridge: Add Sony IMX175 (INTCF1A) Volodymyr Chapman
2026-11-17 9:57 ` Andy Shevchenko
2026-11-17 17:50 ` Volodymyr Chapman
2026-11-18 11:35 ` Andy Shevchenko
2026-11-16 17:51 ` [PATCH 3/3] media: atomisp: csi2-bridge: Add IMX175 sensor config Volodymyr Chapman
2026-11-17 10:08 ` [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera) Andy Shevchenko
2026-11-17 17:56 ` Volodymyr Chapman
2026-11-18 11:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2N81gHOXYpaV-C@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=volodymyrchapman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®