mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Volodymyr Chapman <volodymyrchapman@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hans de Goede <hansg@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: ipu-bridge: Add Sony IMX175 (INTCF1A)
Date: Wed, 18 Nov 2026 13:35:40 +0200	[thread overview]
Message-ID: <av2NjAA8yTAwwZ7t@ashevche-desk.local> (raw)
In-Reply-To: <CAN1s30pEE5vN7Yuz9Y5_+4M6-TeTNTmHA_hYLR9KLnXj05RWfQ@mail.gmail.com>

On Tue, Nov 17, 2026 at 05:50:12PM +0000, Volodymyr Chapman wrote:

...

> > Since the ACPI HID here is broken (it's actually a PNP ID), can you also
> > provide (as a comment) the excerpt from DSDT to show that device description?
> 
> Of course. From the ThinkPad 10 (20C3, BIOS GWET50WW 1.50) DSDT:

Thanks!

> Device (CAM1)
> {
> Name (_ADR, Zero)
> Name (_HID, "INTCF1A")
> Name (_CID, "INTCF1A")
> Name (_SUB, "221B17AA")
> Name (_DDN, "Sony IMX175")
> Name (_UID, One)
> ...
> 
> I will add that as a comment above the INTCF1A entry.

No, in the code just mention the laptop model, DSDT excerpt is only for cover
letter.

> Should the same comment go to the INTCF1A entry in atomisp_csi2_bridge.c
> (patch 3/3)?

If there are already similar comments for other entries, then yes.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-18 11:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 17:51 [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera) Volodymyr Chapman
2026-11-16 17:51 ` [PATCH 1/3] media: i2c: Add Sony IMX175 sensor driver Volodymyr Chapman
2026-11-16 19:25   ` Dave Stevenson
2026-11-16 23:09     ` Volodymyr Chapman
2026-11-17 14:13   ` Uwe Kleine-König
2026-11-16 17:51 ` [PATCH 2/3] media: ipu-bridge: Add Sony IMX175 (INTCF1A) Volodymyr Chapman
2026-11-17  9:57   ` Andy Shevchenko
2026-11-17 17:50     ` Volodymyr Chapman
2026-11-18 11:35       ` Andy Shevchenko [this message]
2026-11-16 17:51 ` [PATCH 3/3] media: atomisp: csi2-bridge: Add IMX175 sensor config Volodymyr Chapman
2026-11-17 10:08 ` [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera) Andy Shevchenko
2026-11-17 17:56   ` Volodymyr Chapman
2026-11-18 11:37     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2NjAA8yTAwwZ7t@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=volodymyrchapman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®