mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cheng <icheng@nvidia.com>
To: "Gregory Price (Meta)" <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com,  linux-doc@vger.kernel.org,
	driver-core@lists.linux.dev, linux-serial@vger.kernel.org,
	 linux-pm@vger.kernel.org, damon@lists.linux.dev,
	linux-cxl@vger.kernel.org,  akpm@linux-foundation.org,
	david@kernel.org, liam@infradead.org, vbabka@kernel.org,
	 rppt@kernel.org, surenb@google.com, mhocko@suse.com,
	corbet@lwn.net,  skhan@linuxfoundation.org,
	rdunlap@infradead.org, gregkh@linuxfoundation.org,
	 rafael@kernel.org, dakr@kernel.org, johan@kernel.org,
	jirislaby@kernel.org,  kasong@tencent.com, qi.zheng@linux.dev,
	shakeel.butt@linux.dev, baohua@kernel.org,
	 axelrasmussen@google.com, yuanchu@google.com,
	weixugc@google.com, baoquan.he@linux.dev,
	 baolin.wang@linux.alibaba.com, yury.norov@gmail.com,
	linux@rasmusvillemoes.dk, pavel@kernel.org,  lenb@kernel.org,
	hannes@cmpxchg.org, brendan.jackman@linux.dev, ziy@nvidia.com,
	 sj@kernel.org, muchun.song@linux.dev, osalvador@suse.de,
	nico.pache@linux.dev,  ryan.roberts@arm.com, dev.jain@arm.com,
	lance.yang@linux.dev, usama.arif@linux.dev,  kas@kernel.org,
	xu.xin@linux.dev, chengming.zhou@linux.dev,
	 joshua.hahnjy@gmail.com, rakie.kim@sk.com,
	ying.huang@linux.alibaba.com,  matthew.brost@intel.com,
	byungchul@sk.com, apopple@nvidia.com, rientjes@google.com
Subject: Re: [PATCH 03/22] mm: introduce the common-memory node state
Date: Wed, 18 Nov 2026 23:24:51 +0800	[thread overview]
Message-ID: <av2_8Z2sdM_9zUEL@MWDK4CY14F> (raw)
In-Reply-To: <20261114070959.3490008-4-gourry@gourry.net>

On Sat, Nov 14, 2026 at 02:09:40AM +0800, Gregory Price (Meta) wrote:
> N_MEMORY is overloaded with two meanings:
>   1) a node has memory.
>   2) a node's memory is reachable via ordinary allocation or
>      an arbitrary MM service may use that memory.
> 
> Allow N_MEMORY to mean #1, and introduce N_MEMORY_COMMON to mean #2.
> 
> N_MEMORY_COMMON nodes contain "common memory" capable of being managed
> arbitrarily by the kernel MM based solely on zone membership. Following
> commits convert relevant N_MEMORY users to N_MEMORY_COMMON.
> 
> Add folio_is_common_memory() and page_is_common_memory() for MM services
> that walk folios. Following commits convert folio_is_zone_device() and
> page_is_zone_device() callers accordingly.
> 
> Expose the state via `has_common_memory` so userspace can identify
> the memory available to ordinary allocations and common MM services.
> 
> Add has_memory to the docs while we're here.
> 
> Every node with memory is common, so N_MEMORY_COMMON equals N_MEMORY
> and there is no behavioral change.
>

This sentense kind of blurred me, you state that N_MEMORY_COMMON is meant
to isolate the concept of #2 from N_MEMORY, I expect something
making clear distinction between common memory and private memory ?

 
> Signed-off-by: Gregory Price (Meta) <gourry@gourry.net>
> ---
>  Documentation/ABI/stable/sysfs-devices-node | 16 ++++++++++++++++
>  Documentation/mm/physical_memory.rst        |  8 +++++++-
>  drivers/base/node.c                         |  2 ++
>  include/linux/nodemask.h                    |  9 ++++++++-
>  mm/internal.h                               | 15 +++++++++++++++
>  mm/page_alloc.c                             |  3 +++
>  6 files changed, 51 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node
> index 2d0e023f22a71..a93de328f8fe8 100644
> --- a/Documentation/ABI/stable/sysfs-devices-node
> +++ b/Documentation/ABI/stable/sysfs-devices-node
> @@ -10,6 +10,15 @@ Contact:	Linux Memory Management list <linux-mm@kvack.org>
>  Description:
>  		Nodes that are online.
>  
> +What:		/sys/devices/system/node/has_memory
> +Date:		December 2012
> +Contact:	Linux Memory Management list <linux-mm@kvack.org>
> +Description:
> +		Nodes that have memory.
> +
> +		This memory may or may not be reachable via standard
> +		allocations, see has_common_memory for details.
> +
>  What:		/sys/devices/system/node/has_normal_memory
>  Date:		October 2002
>  Contact:	Linux Memory Management list <linux-mm@kvack.org>
> @@ -29,6 +38,13 @@ Description:
>  		Nodes that have regular or high memory.
>  		Depends on CONFIG_HIGHMEM.
>  
> +What:		/sys/devices/system/node/has_common_memory
> +Date:		November 2026
> +Contact:	Linux Memory Management list <linux-mm@kvack.org>
> +Description:
> +		Nodes whose memory ordinary allocations may use without
> +		requesting the node explicitly.
> +
>  What:		/sys/devices/system/node/nodeX
>  Date:		October 2002
>  Contact:	Linux Memory Management list <linux-mm@kvack.org>
> diff --git a/Documentation/mm/physical_memory.rst b/Documentation/mm/physical_memory.rst
> index 2e67e8b23a994..fd5c5d136180f 100644
> --- a/Documentation/mm/physical_memory.rst
> +++ b/Documentation/mm/physical_memory.rst
> @@ -168,7 +168,12 @@ nodes with particular properties as defined by ``enum node_states``:
>    The node has regular or high memory. When ``CONFIG_HIGHMEM`` is disabled
>    aliased to ``N_NORMAL_MEMORY``.
>  ``N_MEMORY``
> -  The node has memory(regular, high, movable)
> +  The node has online memory (regular, high, movable).  This is a topology and
> +  accounting state. Presence in this mask does not mean ordinary allocations
> +  can use the node's memory; see ``N_MEMORY_COMMON``.
> +``N_MEMORY_COMMON``
> +  The node is on the page allocator's fallback zonelists, so an allocation
> +  that named no node can be satisfied from it.
>  ``N_CPU``
>    The node has one or more CPUs
>  ``N_GENERIC_INITIATOR``
> @@ -184,6 +189,7 @@ For example, for node 2 with normal memory and CPUs, bit 2 will be set in ::
>    node_states[N_NORMAL_MEMORY]
>    node_states[N_HIGH_MEMORY]
>    node_states[N_MEMORY]
> +  node_states[N_MEMORY_COMMON]
>    node_states[N_CPU]
>  
>  For various operations possible with nodemasks please refer to
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index dcdc8626627a8..cc6696d1390f3 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -965,6 +965,7 @@ static struct node_attr node_state_attr[] = {
>  	[N_HIGH_MEMORY] = _NODE_ATTR(has_high_memory, N_HIGH_MEMORY),
>  #endif
>  	[N_MEMORY] = _NODE_ATTR(has_memory, N_MEMORY),
> +	[N_MEMORY_COMMON] = _NODE_ATTR(has_common_memory, N_MEMORY_COMMON),
>  	[N_CPU] = _NODE_ATTR(has_cpu, N_CPU),
>  	[N_GENERIC_INITIATOR] = _NODE_ATTR(has_generic_initiator,
>  					   N_GENERIC_INITIATOR),
> @@ -978,6 +979,7 @@ static struct attribute *node_state_attrs[] = {
>  	&node_state_attr[N_HIGH_MEMORY].attr.attr,
>  #endif
>  	&node_state_attr[N_MEMORY].attr.attr,
> +	&node_state_attr[N_MEMORY_COMMON].attr.attr,
>  	&node_state_attr[N_CPU].attr.attr,
>  	&node_state_attr[N_GENERIC_INITIATOR].attr.attr,
>  	NULL
> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
> index 28a456c3f5964..7ace610bdd654 100644
> --- a/include/linux/nodemask.h
> +++ b/include/linux/nodemask.h
> @@ -402,7 +402,14 @@ enum node_states {
>  #else
>  	N_HIGH_MEMORY = N_NORMAL_MEMORY,
>  #endif
> -	N_MEMORY,		/* The node has memory(regular, high, movable) */
> +	/*
> +	 * N_MEMORY indicates online memory exists on the node - it is used
> +	 * to manage per-node meta-data and topology decisions.
> +	 * N_MEMORY_COMMON indicates whether the node can satisfy arbitrary
> +	 * allocations and whether a service should manage that node's folios.
> +	 */
> +	N_MEMORY,		/* the node has memory */
> +	N_MEMORY_COMMON,	/* common pool (fallback zonelist) */
>  	N_CPU,		/* The node has one or more cpus */
>  	N_GENERIC_INITIATOR,	/* The node has one or more Generic Initiators */
>  	NR_NODE_STATES
> diff --git a/mm/internal.h b/mm/internal.h
> index 608a83c34c224..af6fc27a9fc98 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -65,6 +65,21 @@ void folio_mark_lazyfree(struct folio *folio);
>  void node_set_memory_state(int nid, bool high, bool normal);
>  void node_clear_memory_state(int nid);
>  
> +/*
> + * Common memory is available to generic MM services. ZONE_DEVICE folios do
> + * not qualify even when their NUMA node is common.
> + */
> +static inline bool folio_is_common_memory(struct folio *folio)
> +{
> +	return !folio_is_zone_device(folio) &&
> +	       node_state(folio_nid(folio), N_MEMORY_COMMON);
> +}
> +
> +static inline bool page_is_common_memory(struct page *page)
> +{
> +	return folio_is_common_memory(page_folio(page));
> +}
> +
>  /* mm/vmscan.c */
>  unsigned long zone_reclaimable_pages(struct zone *zone);
>  unsigned long try_to_free_pages(struct zonelist *zonelist, int order,
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 834d199ff8429..6ffa972811462 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -203,6 +203,7 @@ nodemask_t node_states[NR_NODE_STATES] __read_mostly = {
>  	[N_HIGH_MEMORY] = { { [0] = 1UL } },
>  #endif
>  	[N_MEMORY] = { { [0] = 1UL } },
> +	[N_MEMORY_COMMON] = { { [0] = 1UL } },
>  	[N_CPU] = { { [0] = 1UL } },
>  #endif	/* NUMA */
>  };
> @@ -215,10 +216,12 @@ void __meminit node_set_memory_state(int nid, bool high, bool normal)
>  		node_set_state(nid, N_HIGH_MEMORY);
>  	if (normal)
>  		node_set_state(nid, N_NORMAL_MEMORY);
> +	node_set_state(nid, N_MEMORY_COMMON);
>  }
>  
>  void __meminit node_clear_memory_state(int nid)
>  {
> +	node_clear_state(nid, N_MEMORY_COMMON);
>  	node_clear_state(nid, N_NORMAL_MEMORY);
>  	node_clear_state(nid, N_MEMORY);
>  }
> -- 
> 2.53.1-Meta
> 
> 

  reply	other threads:[~2026-11-18 15:25 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  7:09 [PATCH 00/22] mm: introduce N_MEMORY_COMMON Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 01/22] mm: add node-state-filtered zone and node iterators Gregory Price (Meta)
2026-11-18  8:29   ` Richard Cheng
2026-11-18 15:17     ` Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 02/22] mm: publish and clear node memory states via helpers Gregory Price (Meta)
2026-11-18  7:53   ` Richard Cheng
2026-11-18 15:20     ` Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 03/22] mm: introduce the common-memory node state Gregory Price (Meta)
2026-11-18 15:24   ` Richard Cheng [this message]
2026-11-18 15:51     ` Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 04/22] mm/page_alloc: build zonelists from common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 05/22] mm/mempolicy: keep interleave and tmpfs mount policies on " Gregory Price (Meta)
2026-11-18 15:30   ` Richard Cheng
2026-11-18 15:56     ` Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 06/22] mm: base hash distribution on common memory nodes Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 07/22] mm/memory_hotplug: migrate offlined pages to common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 08/22] mm/memory-tiers: restrict demotion topology " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 09/22] mm/ksm: restrict merging " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 10/22] mm/khugepaged: restrict collapse " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 11/22] mm/mempolicy: don't NUMA-hint folios outside " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 12/22] mm/damon: restrict DAMON-native folio operations to " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 13/22] mm/hugetlb: restrict pool growth " Gregory Price (Meta)
2026-11-18  7:32   ` Richard Cheng
2026-11-18 15:25     ` Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 14/22] mm/page_alloc: count common memory nodes for kswapd recovery Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 15/22] mm/oom_kill: compare OOM constraints against common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 16/22] tty/sysrq: use common memory for the manual OOM zonelist Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 17/22] mm/vmscan: restrict reclaim to common memory Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 18/22] mm/compaction: restrict compaction " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 19/22] mm/migrate: restrict move_pages() destinations " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 20/22] PM: hibernate: size the image from " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 21/22] mm/khugepaged: base the recommended min_free_kbytes on " Gregory Price (Meta)
2026-11-14  7:09 ` [PATCH 22/22] nodemask: remove the now-unused first_memory_node/next_memory_node Gregory Price (Meta)
2026-11-18  7:01 ` [PATCH 00/22] mm: introduce N_MEMORY_COMMON Richard Cheng
2026-11-18 15:13   ` Gregory Price (Meta)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2_8Z2sdM_9zUEL@MWDK4CY14F \
    --to=icheng@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=brendan.jackman@linux.dev \
    --cc=byungchul@sk.com \
    --cc=chengming.zhou@linux.dev \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gourry@gourry.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kas@kernel.org \
    --cc=kasong@tencent.com \
    --cc=kernel-team@meta.com \
    --cc=lance.yang@linux.dev \
    --cc=lenb@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=osalvador@suse.de \
    --cc=pavel@kernel.org \
    --cc=qi.zheng@linux.dev \
    --cc=rafael@kernel.org \
    --cc=rakie.kim@sk.com \
    --cc=rdunlap@infradead.org \
    --cc=rientjes@google.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shakeel.butt@linux.dev \
    --cc=sj@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=xu.xin@linux.dev \
    --cc=ying.huang@linux.alibaba.com \
    --cc=yuanchu@google.com \
    --cc=yury.norov@gmail.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®