mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes
Date: Thu, 19 Nov 2026 12:17:04 +0200	[thread overview]
Message-ID: <av7MoMqutd2-lftk@ashevche-desk.local> (raw)
In-Reply-To: <20261118100605.34002-1-kapoorarnav43@gmail.com>

On Wed, Nov 18, 2026 at 03:36:05PM +0530, Arnav Kapoor wrote:
> On Wed, Nov 18, 2026 at 09:01:11AM +0200, Andy Shevchenko wrote:
> > For the sake of the correctness the whole set of 64k has to be checked. And in
> > most cases the + 1 there will be wrong. The only correction we need is on the
> > edges of the full squares, id est when val == r² - 1.
> 
> I ran the v2 logic (reject val < 0, int_sqrt(2 * val + 1) for val > 1,
> reject results above 0xff) over every val from 0 to 65535. Values up to
> 32767 are accepted, and for each of them, apart from val == 0:
> 
> 	code = largest r such that r * r / 2 <= val
> 
> val == 0 stays at code 0, which reads back as 0 like code 1 does.
> 
> The + 1 only changes the result where you say the correction is needed.
> int_sqrt(2 * val + 1) differs from int_sqrt(2 * val) for 127 values of
> val, and those are exactly the ones with 2 * val == r² - 1 for an odd r
> (val = 4, 12, 24, ..., 32512). For every other val both give the same
> code, so the + 1 has no effect there.
> 
> The reason is that, in integer arithmetic:
> 
> 	r * r / 2 <= val  <=>  r * r < 2 * val + 2  <=>  r * r <= 2 * val + 1

Yes, for r > 1.

> > At bare minimum the commit message needs to be corrected and explained
> > these aspects that while the + 1 gives wrong result for most of the cases,
> > it's still okay to use as we work only in integer arithmetics. Also the formula
> > (r² - 1) / 2  has to be dropped as it's incorrect from mathematics point of
> > view. The floor() happens on / 2 and has nothing to do with (- 1) correction.
> 
> Agreed on dropping the formula. For v2 I plan to replace that part of
> the commit message with:
> 
>     read_thresh() reports code r as r * r / 2, and the division rounds
>     down for odd r. write_thresh() inverts that with int_sqrt(2 * val),
>     which is one code too low when 2 * val == r * r - 1, so writing back
>     the value read from an odd code lowers the code by one.
> 
>     Use int_sqrt(2 * val + 1), which gives the largest code whose
>     threshold does not exceed val: in integer arithmetic,
>     r * r / 2 <= val is the same as r * r <= 2 * val + 1. The result only
>     differs from int_sqrt(2 * val) on those edges.

s/code/value/g ?

> The same goes for 5/6. Does that cover what you had in mind?

Yes. This is much clearer, thanks!

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-19 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:53 [PATCH 0/6] iio: proximity: sx93xx: fix raw reads, thresholds, hysteresis and gain Arnav Kapoor
2026-11-16 20:53 ` [PATCH 1/6] iio: proximity: sx_common: fix raw reads while the trigger is in use Arnav Kapoor
2026-11-16 20:53 ` [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes Arnav Kapoor
2026-11-17 18:59   ` Andy Shevchenko
2026-11-17 19:10     ` Arnav Kapoor
2026-11-18  7:01       ` Andy Shevchenko
2026-11-18 10:06         ` Arnav Kapoor
2026-11-19 10:17           ` Andy Shevchenko [this message]
2026-11-16 20:53 ` [PATCH 3/6] iio: proximity: sx9324: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:09   ` Andy Shevchenko
2026-11-17 19:15     ` Arnav Kapoor
2026-11-16 20:53 ` [PATCH 4/6] iio: proximity: sx9360: fix hardware gain encoding Arnav Kapoor
2026-11-16 20:53 ` [PATCH 5/6] iio: proximity: sx9360: fix proximity threshold writes Arnav Kapoor
2026-11-17 19:11   ` Andy Shevchenko
2026-11-16 20:53 ` [PATCH 6/6] iio: proximity: sx9360: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:12   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7MoMqutd2-lftk@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®