mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks
@ 2026-11-19  5:56 Christian Ludloff
  2026-11-19 14:46 ` Sean Christopherson
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Ludloff @ 2026-11-19  5:56 UTC (permalink / raw)
  To: Chang S. Bae
  Cc: seanjc, jmattson, pbonzini, kvm, x86, linux-kernel, zhao1.liu

> Since APX repurposes the XSAVE area previously used by MPX in the
> non-compacted format, add a check to ensure that MPX state is not set
> when APX is enabled.

For the sake of completeness...

EVO processors do support simultaneously
enabled MPX and APX, with state that does
not overlap. (And several MSR control bits.)

--
C.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks
  2026-11-19  5:56 [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Christian Ludloff
@ 2026-11-19 14:46 ` Sean Christopherson
  0 siblings, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2026-11-19 14:46 UTC (permalink / raw)
  To: Christian Ludloff
  Cc: Chang S. Bae, jmattson, pbonzini, kvm, x86, linux-kernel, zhao1.liu

On Wed, Nov 18, 2026, Christian Ludloff wrote:
> > Since APX repurposes the XSAVE area previously used by MPX in the
> > non-compacted format, add a check to ensure that MPX state is not set
> > when APX is enabled.
> 
> For the sake of completeness...

For the sake of my sanity, fix your mail client to set In-Reply-To properly.
It's not a gmail problem.  I don't see this issue with mails from anyone else,
and I just tested that sending a mail through the gmail web interface sets the
header as expected.

> EVO processors do support simultaneously
> enabled MPX and APX, with state that does
> not overlap. (And several MSR control bits.)

Until EVO processors are officially supported in KVM selftests, I don't care.  I
am a-ok supporting EVO processors, but if you want upstream to care about them,
then someone needs to take the time to enable support.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks
  2026-11-17 18:02 [PATCH v9 00/20] KVM: x86: Enable APX for guest Chang S. Bae
@ 2026-11-17 18:03 ` Chang S. Bae
  0 siblings, 0 replies; 3+ messages in thread
From: Chang S. Bae @ 2026-11-17 18:03 UTC (permalink / raw)
  To: seanjc, jmattson
  Cc: pbonzini, kvm, x86, linux-kernel, zhao1.liu, chang.seok.bae

Now that KVM exposes the APX feature to guests, extend some existing
selftests to validate XCR0 configuration and state management.

Since APX repurposes the XSAVE area previously used by MPX in the
non-compacted format, add a check to ensure that MPX state is not set
when APX is enabled.

Also, load non-init APX state data in the guest so that XSTATE_BV[APX] is
set and the save/restore of APX state is exercised.

Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
---
V8 -> V9: uint64_t -> u64 (Jim Mattson)
---
 tools/testing/selftests/kvm/x86/state_test.c  |  3 +++
 .../selftests/kvm/x86/xcr0_cpuid_test.c       | 19 +++++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/tools/testing/selftests/kvm/x86/state_test.c b/tools/testing/selftests/kvm/x86/state_test.c
index 500b09762555..22fe0784dbc0 100644
--- a/tools/testing/selftests/kvm/x86/state_test.c
+++ b/tools/testing/selftests/kvm/x86/state_test.c
@@ -164,6 +164,9 @@ static void __attribute__((__flatten__)) guest_code(void *arg)
 			asm volatile ("vmovupd %0, %%zmm16" :: "m" (buffer));
 		}
 
+		if (supported_xcr0 & XFEATURE_MASK_APX)
+			write_egpr(16, 0xcccccccc);
+
 		if (this_cpu_has(X86_FEATURE_MPX)) {
 			u64 bounds[2] = { 10, 0xffffffffull };
 			u64 output[2] = { };
diff --git a/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c b/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c
index 40dc9e6b3fad..adf665f483c1 100644
--- a/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c
+++ b/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c
@@ -46,6 +46,20 @@ do {									\
 		       __supported, (xfeatures));			\
 } while (0)
 
+/*
+ * Verify that mutually exclusive architectural features do not overlap.
+ * For example, APX and MPX must never be reported as supported together.
+ */
+#define ASSERT_XFEATURE_CONFLICT(supported_xcr0, xfeatures, conflicts)			\
+do {											\
+	u64 __supported = (supported_xcr0) & ((xfeatures) | (conflicts));		\
+											\
+	__GUEST_ASSERT((__supported & (xfeatures)) != (xfeatures) ||			\
+		       !(__supported & (conflicts)),					\
+		       "supported = 0x%lx, xfeatures = 0x%llx, conflicts = 0x%llx",	\
+		       __supported, (xfeatures), (conflicts));				\
+} while (0)
+
 static void guest_code(void)
 {
 	u64 initial_xcr0;
@@ -79,6 +93,11 @@ static void guest_code(void)
 	ASSERT_ALL_OR_NONE_XFEATURE(supported_xcr0,
 				    XFEATURE_MASK_XTILE);
 
+	/* Check APX by ensuring MPX is not exposed concurrently */
+	ASSERT_XFEATURE_CONFLICT(supported_xcr0,
+				 XFEATURE_MASK_APX,
+				 XFEATURE_MASK_BNDREGS | XFEATURE_MASK_BNDCSR);
+
 	vector = xsetbv_safe(0, XFEATURE_MASK_FP);
 	__GUEST_ASSERT(!vector,
 		       "Expected success on XSETBV(FP), got %s",
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19 14:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19  5:56 [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Christian Ludloff
2026-11-19 14:46 ` Sean Christopherson
  -- strict thread matches above, loose matches on Subject: below --
2026-11-17 18:02 [PATCH v9 00/20] KVM: x86: Enable APX for guest Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Chang S. Bae

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®