* Re: [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks
@ 2026-11-19 5:56 Christian Ludloff
2026-11-19 14:46 ` Sean Christopherson
0 siblings, 1 reply; 3+ messages in thread
From: Christian Ludloff @ 2026-11-19 5:56 UTC (permalink / raw)
To: Chang S. Bae
Cc: seanjc, jmattson, pbonzini, kvm, x86, linux-kernel, zhao1.liu
> Since APX repurposes the XSAVE area previously used by MPX in the
> non-compacted format, add a check to ensure that MPX state is not set
> when APX is enabled.
For the sake of completeness...
EVO processors do support simultaneously
enabled MPX and APX, with state that does
not overlap. (And several MSR control bits.)
--
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks
2026-11-19 5:56 [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Christian Ludloff
@ 2026-11-19 14:46 ` Sean Christopherson
0 siblings, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2026-11-19 14:46 UTC (permalink / raw)
To: Christian Ludloff
Cc: Chang S. Bae, jmattson, pbonzini, kvm, x86, linux-kernel, zhao1.liu
On Wed, Nov 18, 2026, Christian Ludloff wrote:
> > Since APX repurposes the XSAVE area previously used by MPX in the
> > non-compacted format, add a check to ensure that MPX state is not set
> > when APX is enabled.
>
> For the sake of completeness...
For the sake of my sanity, fix your mail client to set In-Reply-To properly.
It's not a gmail problem. I don't see this issue with mails from anyone else,
and I just tested that sending a mail through the gmail web interface sets the
header as expected.
> EVO processors do support simultaneously
> enabled MPX and APX, with state that does
> not overlap. (And several MSR control bits.)
Until EVO processors are officially supported in KVM selftests, I don't care. I
am a-ok supporting EVO processors, but if you want upstream to care about them,
then someone needs to take the time to enable support.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v9 00/20] KVM: x86: Enable APX for guest
@ 2026-11-17 18:02 Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Chang S. Bae
0 siblings, 1 reply; 3+ messages in thread
From: Chang S. Bae @ 2026-11-17 18:02 UTC (permalink / raw)
To: seanjc, jmattson
Cc: pbonzini, kvm, x86, linux-kernel, zhao1.liu, chang.seok.bae
Hi all,
This revision incorporates feedback from Jim Mattson. Thanks for the
review! While he provided review tags for some patches, he also caught
something. Here's a summary of changes in each part:
Part1: Establish EGPR state management
Since EGPR storage resides outside the guest fpstate, there were two
gotchas to address:
* VCPU reset (patch3) and
* The XSTATE_BV[APX]=0 behavior in the KVM API (patch4), with a
corresponding test added in patch19. This also influenced [4].
Part2: Update VMX handlers for EGPR indices
While rebasing onto recent VMX changes, the VMX instruction
information extension needs to be hidden when using eVMCS (patch 9
and 17/18), rather than leaving it untouched.
Part3: Support emulator for REX2
There were a few smaller corrections, but one outstanding was masking
higher register bits before accessing {X,Y}MM registers (patch 12).
Another point was whether to report #UD or an emulation failure. I
took that distinguishing the two is reasonable in the front end,
although an emulation failure eventually be #UD injection in the back
end.
Part4: Expose APX features and test
The rationale for CPUID filtering to ensure forward compatibility was
bought. Then consolidated feature exposure into patch 18. There were
also a few minor test-code updates, along with a new test for
clearing APX state based on the feedback from Part1.
With these changes, I think the series in much better shape, hopefully
leaving fewer issues for Sashiko to catch. Let me check if there is
anything else.
Thanks,
Chang
References:
[1] Repository: git://github.com/intel/apx.git apx-kvm_v9 (based on github.com/kvm-x86 next)
[2] KVM unit test: https://lore.kernel.org/20260420212355.507827-1-chang.seok.bae@intel.com
[3] Previous posting, V8: https://lore.kernel.org/20260930210750.1487547-1-chang.seok.bae@intel.com
[4] x86 xstate ptrace test: https://lore.kernel.org/20261110031603.698635-1-chang.seok.bae@intel.com
Chang S. Bae (19):
KVM: x86: Extend VCPU registers for EGPRs
KVM: VMX: Save guest EGPRs in VCPU cache
KVM: x86: Support EGPRs on VCPU RESET/INIT events
KVM: x86: Support APX state for XSAVE ABI
KVM: VMX: Refactor VMX instruction information access
KVM: VMX: Refactor instruction information decoding
KVM: VMX: Remove unused control-register access defines
KVM: VMX: Refactor register index retrieval from exit qualification
KVM: VMX: Support instruction information extension
KVM: nVMX: Propagate extended instruction information
KVM: x86: Support EGPR accessing and tracking for emulator
KVM: x86: Handle EGPR index and REX2-incompatible opcodes
KVM: x86: Support REX2-prefixed opcode decode
KVM: x86: Document EVEX-prefix not implemented
KVM: x86: Guard valid XCR0.APX settings
KVM: x86: Add APX to supported XCR0
KVM: x86: Expose APX feature to userspace
KVM: selftests: Add APX state and ABI test
KVM: selftests: Add APX state handling and XCR0 sanity checks
Sean Christopherson (1):
KVM: x86: Move KVM_SUPPORTED_{XCR0,XSS} into kvm_x86_vendor_init()
arch/x86/Kconfig.assembler | 5 +
arch/x86/include/asm/cpuid/api.h | 1 +
arch/x86/include/asm/kvm_host.h | 19 ++
arch/x86/include/asm/kvm_vcpu_regs.h | 50 +++++
arch/x86/include/asm/vmx.h | 22 +-
arch/x86/kvm/Kconfig | 4 +
arch/x86/kvm/cpuid.c | 33 ++-
arch/x86/kvm/cpuid.h | 2 +
arch/x86/kvm/emulate.c | 132 ++++++++---
arch/x86/kvm/kvm_emulate.h | 21 +-
arch/x86/kvm/reverse_cpuid.h | 6 +
arch/x86/kvm/svm/svm.c | 8 +-
arch/x86/kvm/vmenter.h | 1 +
arch/x86/kvm/vmx/common.h | 5 +
arch/x86/kvm/vmx/nested.c | 72 +++---
arch/x86/kvm/vmx/nested.h | 2 +-
arch/x86/kvm/vmx/vmcs12.c | 4 +
arch/x86/kvm/vmx/vmcs12.h | 3 +-
arch/x86/kvm/vmx/vmenter.S | 31 ++-
arch/x86/kvm/vmx/vmx.c | 36 ++-
arch/x86/kvm/vmx/vmx.h | 63 +++++-
arch/x86/kvm/vmx/vmx_ops.h | 9 +
arch/x86/kvm/x86.c | 144 +++++++++---
tools/testing/selftests/kvm/Makefile.kvm | 1 +
.../selftests/kvm/include/x86/processor.h | 120 ++++++++++
tools/testing/selftests/kvm/x86/apx_test.c | 209 ++++++++++++++++++
tools/testing/selftests/kvm/x86/state_test.c | 3 +
.../selftests/kvm/x86/xcr0_cpuid_test.c | 19 ++
28 files changed, 877 insertions(+), 148 deletions(-)
create mode 100644 tools/testing/selftests/kvm/x86/apx_test.c
base-commit: cbe54fc3462b3949ab27b9ae81fb9ddb509040c7
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks
2026-11-17 18:02 [PATCH v9 00/20] KVM: x86: Enable APX for guest Chang S. Bae
@ 2026-11-17 18:03 ` Chang S. Bae
0 siblings, 0 replies; 3+ messages in thread
From: Chang S. Bae @ 2026-11-17 18:03 UTC (permalink / raw)
To: seanjc, jmattson
Cc: pbonzini, kvm, x86, linux-kernel, zhao1.liu, chang.seok.bae
Now that KVM exposes the APX feature to guests, extend some existing
selftests to validate XCR0 configuration and state management.
Since APX repurposes the XSAVE area previously used by MPX in the
non-compacted format, add a check to ensure that MPX state is not set
when APX is enabled.
Also, load non-init APX state data in the guest so that XSTATE_BV[APX] is
set and the save/restore of APX state is exercised.
Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
---
V8 -> V9: uint64_t -> u64 (Jim Mattson)
---
tools/testing/selftests/kvm/x86/state_test.c | 3 +++
.../selftests/kvm/x86/xcr0_cpuid_test.c | 19 +++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/tools/testing/selftests/kvm/x86/state_test.c b/tools/testing/selftests/kvm/x86/state_test.c
index 500b09762555..22fe0784dbc0 100644
--- a/tools/testing/selftests/kvm/x86/state_test.c
+++ b/tools/testing/selftests/kvm/x86/state_test.c
@@ -164,6 +164,9 @@ static void __attribute__((__flatten__)) guest_code(void *arg)
asm volatile ("vmovupd %0, %%zmm16" :: "m" (buffer));
}
+ if (supported_xcr0 & XFEATURE_MASK_APX)
+ write_egpr(16, 0xcccccccc);
+
if (this_cpu_has(X86_FEATURE_MPX)) {
u64 bounds[2] = { 10, 0xffffffffull };
u64 output[2] = { };
diff --git a/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c b/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c
index 40dc9e6b3fad..adf665f483c1 100644
--- a/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c
+++ b/tools/testing/selftests/kvm/x86/xcr0_cpuid_test.c
@@ -46,6 +46,20 @@ do { \
__supported, (xfeatures)); \
} while (0)
+/*
+ * Verify that mutually exclusive architectural features do not overlap.
+ * For example, APX and MPX must never be reported as supported together.
+ */
+#define ASSERT_XFEATURE_CONFLICT(supported_xcr0, xfeatures, conflicts) \
+do { \
+ u64 __supported = (supported_xcr0) & ((xfeatures) | (conflicts)); \
+ \
+ __GUEST_ASSERT((__supported & (xfeatures)) != (xfeatures) || \
+ !(__supported & (conflicts)), \
+ "supported = 0x%lx, xfeatures = 0x%llx, conflicts = 0x%llx", \
+ __supported, (xfeatures), (conflicts)); \
+} while (0)
+
static void guest_code(void)
{
u64 initial_xcr0;
@@ -79,6 +93,11 @@ static void guest_code(void)
ASSERT_ALL_OR_NONE_XFEATURE(supported_xcr0,
XFEATURE_MASK_XTILE);
+ /* Check APX by ensuring MPX is not exposed concurrently */
+ ASSERT_XFEATURE_CONFLICT(supported_xcr0,
+ XFEATURE_MASK_APX,
+ XFEATURE_MASK_BNDREGS | XFEATURE_MASK_BNDCSR);
+
vector = xsetbv_safe(0, XFEATURE_MASK_FP);
__GUEST_ASSERT(!vector,
"Expected success on XSETBV(FP), got %s",
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 5:56 [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Christian Ludloff
2026-11-19 14:46 ` Sean Christopherson
-- strict thread matches above, loose matches on Subject: below --
2026-11-17 18:02 [PATCH v9 00/20] KVM: x86: Enable APX for guest Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Chang S. Bae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®