From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: Emanuele Rocca <ema@debian.org>
Cc: "Clark Williams" <clrkwllms@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"John Ogness" <john.ogness@linutronix.de>,
"Derek Barbosa" <debarbos@redhat.com>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@amutable.com>,
"Daan De Meyer" <daan.j.demeyer@gmail.com>,
"Luca Boccassi" <luca.boccassi@gmail.com>,
linux-rt-devel@lists.linux.dev, debian-kernel@lists.debian.org,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 02/10] kconfig-checker: Introduce PREEMPT_RT configuration rules
Date: Thu, 19 Nov 2026 18:09:04 +0100 [thread overview]
Message-ID: <av8tMAE3LXz8QwH5@lx-t490> (raw)
In-Reply-To: <avxFRmhBrlKLtQ97@ariel.home>
Hi Emanuele,
On Tue, 17 Nov 2026, Emanuele Rocca wrote:
>
> thanks for this useful tool!
>
Thanks!
> > + - name: CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> > + expected: y
> > + severity: high
> > + docs_hint: config
>
> The docs mention the following for CPU_FREQ_DEFAULT_GOV_PERFORMANCE:
>
> | This is not an absolute rule. Some setups might prefer to clock the
> | CPU to lower speeds due to thermal packaging or other requirements. The
> | key is that the CPU frequency remains constant once set.
>
> Yet having the rule "severity: high" will presumably make
> kconfig-checker require CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y in order for
> validation to pass?
>
Yeah, the expectation is that the RT policy profile recommends the
"absolute best" kind of configuration. If the system integrators knows
what they are doing, then they can override that setting in a rule overlay
and explain their rationale there.
> > + - name_pattern: CONFIG_CPU_FREQ_GOV_(CONSERVATIVE|ONDEMAND|POWERSAVE|USERSPACE)
> > + expected: n
> > + severity: medium
> > + docs_hint: non-performance-cpu-frequency-governors
>
> Similarly, by reading your docs, it seems to me that the worst choice
> for RT workloads is ONDEMAND.
>
> | The ONDEMAND governor should not be enabled on a real-time system. Its
> | frequency changes depend on workload behavior and can significantly harm
> | determinism.
>
> Shouldn't the severity for the CPU_FREQ_GOV_ONDEMAND rule be higher,
> then?
That's a very good point, thanks! I'll separate the recommendations
severity into:
- CONSERVATIVE and ONDEMAND: these are the worst, as they do change the
frequency during the system's lifetime. Thus, rule severity is high.
- POWERSAVE: Frequency is low, but it does not change during the system
lifetime. Thus, rule severity is medium.
- USERSPACE: Fine if the user-space program that knows what it's doing and
does not switch frequencies haphazardly. Thus, rule severity is medium
as well.
Sounds good?
--
Kind regards,
Ahmed S. Darwish
Linutronix GmbH
next prev parent reply other threads:[~2026-11-19 17:09 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 9:19 [PATCH v1 00/10] tools: Introduce a kernel configuration checker Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 01/10] kconfig-checker: Add schema for rule files Ahmed S. Darwish
2026-11-08 18:59 ` Julian Braha
2026-11-09 12:40 ` Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 02/10] kconfig-checker: Introduce PREEMPT_RT configuration rules Ahmed S. Darwish
2026-11-07 9:20 ` sashiko-bot
2026-11-09 18:09 ` Ahmed S. Darwish
2026-11-17 12:15 ` Emanuele Rocca
2026-11-19 17:09 ` Ahmed S. Darwish [this message]
2026-11-06 9:19 ` [PATCH v1 03/10] kconfig-checker: Add the configuration checker code Ahmed S. Darwish
2026-11-07 9:20 ` sashiko-bot
2026-11-09 19:29 ` Ahmed S. Darwish
2026-11-08 18:59 ` Julian Braha
2026-11-09 13:00 ` Ahmed S. Darwish
2026-11-12 22:56 ` Julian Braha
2026-11-16 10:52 ` Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 04/10] kconfig: Introduce checkconfig target Ahmed S. Darwish
2026-11-07 9:20 ` sashiko-bot
2026-11-09 20:07 ` Ahmed S. Darwish
2026-11-12 15:53 ` Ahmed S. Darwish
2026-11-08 18:59 ` Julian Braha
2026-11-09 0:39 ` Nathan Chancellor
2026-11-09 13:18 ` Ahmed S. Darwish
2026-11-11 6:38 ` Nicolas Schier
2026-11-12 11:32 ` Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 05/10] Documentation: Describe kconfig-checker usage and design Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 06/10] kconfig-checker: Split schema to support component reuse Ahmed S. Darwish
2026-11-07 9:20 ` sashiko-bot
2026-11-09 18:22 ` Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 07/10] kconfig-checker: Introduce overlays schema Ahmed S. Darwish
2026-11-07 9:20 ` sashiko-bot
2026-11-09 16:47 ` Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 08/10] kconfig-checker: Add support for rule overlays Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 09/10] Documentation: Describe kconfig-checker overlays Ahmed S. Darwish
2026-11-07 9:20 ` sashiko-bot
2026-11-09 16:50 ` Ahmed S. Darwish
2026-11-06 9:19 ` [PATCH v1 10/10] kconfig: Introduce OVERLAY= for make checkconfig Ahmed S. Darwish
2026-11-11 6:38 ` Nicolas Schier
2026-11-12 11:45 ` Ahmed S. Darwish
2026-11-12 21:31 ` Ahmed S. Darwish
2026-11-16 15:47 ` Nicolas Schier
2026-11-08 18:59 ` [PATCH v1 00/10] tools: Introduce a kernel configuration checker Julian Braha
2026-11-09 0:37 ` Nathan Chancellor
2026-11-09 16:15 ` Ahmed S. Darwish
2026-11-09 16:52 ` Nathan Chancellor
2026-11-09 17:04 ` Ahmed S. Darwish
2026-11-09 15:49 ` Ahmed S. Darwish
2026-11-10 18:18 ` Julian Braha
2026-11-10 20:33 ` Ahmed S. Darwish
2026-11-11 6:38 ` Nicolas Schier
2026-11-12 12:36 ` Ahmed S. Darwish
2026-11-12 17:50 ` Nathan Chancellor
2026-11-12 19:14 ` Ahmed S. Darwish
2026-11-12 21:44 ` Nathan Chancellor
2026-11-12 23:14 ` Julian Braha
2026-11-16 16:04 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8tMAE3LXz8QwH5@lx-t490 \
--to=darwi@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=corbet@lwn.net \
--cc=daan.j.demeyer@gmail.com \
--cc=debarbos@redhat.com \
--cc=debian-kernel@lists.debian.org \
--cc=ema@debian.org \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=luca.boccassi@gmail.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=rostedt@goodmis.org \
--cc=zbyszek@amutable.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®