mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Kryštof Černý" <cleverline1mc@gmail.com>
Cc: "James Hilliard" <james.hilliard1@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v8 00/11] serial: 8250_dw: share RX trigger setup and describe Allwinner UARTs
Date: Tue, 10 Nov 2026 12:45:59 +0200	[thread overview]
Message-ID: <avL1521B9qlNh8iO@ashevche-desk.local> (raw)
In-Reply-To: <873c22a2-fd3f-4927-a06f-16a73c30de86@gmail.com>

On Tue, Nov 10, 2026 at 10:54:40AM +0100, Kryštof Černý wrote:
> > Based on tty-next at 6628e7d4c6b2 with the posted RX trigger callback-lifetime
> > fix [0] and DW BUSY-safe divisor fix v4 [1]. Platform setup runs before
> > installing the BUSY-safe divisor setter.
> > 
> > [0] https://lore.kernel.org/r/20261024-submit-serial-8250-rxtrig-lifetime-v1-v1-1-731b78d5003d@gmail.com
> > [1] https://lore.kernel.org/r/20261027-submit-serial-8250-dw-divisor-v1-v4-1-41714a75e15a@gmail.com
> Hello,
> thanks for the work, I wanted to upstream my changes [0], but got redirected
> here instead. This fixes the issues I have had in a better way.
> I have tested the whole series, so I reply to the cover letter, didn't make
> sense to me to reply to all messages with tested by, but I am not sure if
> that is the right way.

You are doing fine, thanks!

> Tested on Unipi G110 controllers (Rockchip RK3328, CPR-described
> 64-byte FIFOs, ttyS1 and ttyS2) on top of tty-next 6628e7d4c6b2 with
> the two prerequisites. rx_trig_bytes now reports 32 instead of 8 by
> default, and 1/16/32/62 select the matching hardware levels, checked by
> chunk sizes in internal loopback and over a real RS-485 bus between the
> two ports at 9600 and 115200 baud. Changing the level mid-transfer
> kept all data, and the level survives termios changes and is kept when
> set while the port is closed.
> 
> Tested-by: Kryštof Černý <cleverline1mc@gmail.com> # RK3328
> 
> [0] https://lore.kernel.org/all/20261109-8250-select-u6-64bit-v1-0-04bc8332fa34@gmail.com/

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-11-10 10:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 20:52 James Hilliard
2026-11-05 20:52 ` [PATCH v8 01/11] serial: 8250_dw: allow port setup to report errors James Hilliard
2026-11-09 23:05   ` Andy Shevchenko
2026-11-09 23:06     ` Andy Shevchenko
2026-11-05 20:52 ` [PATCH v8 02/11] serial: 8250_dw: select port setup through platform data James Hilliard
2026-11-05 20:52 ` [PATCH v8 03/11] serial: 8250: widen RX trigger byte counts to 16 bits James Hilliard
2026-11-05 20:52 ` [PATCH v8 04/11] serial: 8250: share the RX trigger conversion helper James Hilliard
2026-11-05 20:52 ` [PATCH v8 05/11] serial: 8250: expose RX trigger controls for custom callbacks James Hilliard
2026-11-05 20:52 ` [PATCH v8 06/11] serial: 8250_dw: derive RX trigger thresholds from the FIFO depth James Hilliard
2026-11-09 23:10   ` Andy Shevchenko
2026-11-05 20:52 ` [PATCH v8 07/11] dt-bindings: serial: snps-dw-apb-uart: add Allwinner H616 James Hilliard
2026-11-05 20:52 ` [PATCH v8 08/11] serial: 8250_dw: configure the Allwinner H616 UART James Hilliard
2026-11-05 20:52 ` [PATCH v8 09/11] dt-bindings: serial: snps-dw-apb-uart: add Allwinner A523 James Hilliard
2026-11-05 20:52 ` [PATCH v8 10/11] serial: 8250_dw: discover Allwinner A523 FIFO depths through FCC James Hilliard
2026-11-05 20:52 ` [PATCH v8 11/11] serial: 8250_dw: configure RX trigger thresholds for Octeon James Hilliard
2026-11-10  9:54 ` [PATCH v8 00/11] serial: 8250_dw: share RX trigger setup and describe Allwinner UARTs Kryštof Černý
2026-11-10 10:45   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avL1521B9qlNh8iO@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=cleverline1mc@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=james.hilliard1@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®