mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Sagi Shahar <sagis@google.com>, Lisa Wang <wyihan@google.com>,
	 Binbin Wu <binbin.wu@linux.intel.com>,
	Ackerley Tng <ackerleytng@google.com>
Subject: Re: [PATCH v16.1] KVM: selftests: Add support for TDX ucalls, via TDVMCALL_REPORT_FATAL_ERROR
Date: Wed, 11 Nov 2026 07:22:23 -0800	[thread overview]
Message-ID: <avSILzc_aB4PVapm@seanjc-mac.roam.internal> (raw)
In-Reply-To: <81872925-d1e7-4f34-a3c3-fea26adc6735@intel.com>

On Wed, Nov 11, 2026, Xiaoyao Li wrote:
> On 11/7/2026 12:47 AM, Sean Christopherson wrote:

...

> > +#define UCALL_PIO_PORT		((u16)0x1000)
> > +#define UCALL_TDX_MAGIC		0xabacadabaULL
> It's 0xa baca dabaULL. I think it should be a typo.

It's not a typo, just a bad (or awesome, depending on your viewpoint) "dad" joke.
The value is a 64-bit value, i.e. there's no truncation.

/* If a toddler were to say "abracadabra". */
#define KVM_EXCEPTION_MAGIC 0xabacadabaULL

  reply	other threads:[~2026-11-11 15:22 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 23:46 [PATCH v16 00/20] TDX KVM selftests Lisa Wang
2026-11-05 23:46 ` [PATCH v16 01/20] KVM: selftests: Add macros to simplify creating VM shapes for non-default types Lisa Wang
2026-11-05 23:46 ` [PATCH v16 02/20] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Lisa Wang
2026-11-09 16:00   ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 03/20] KVM: selftests: Initialize the TDX VM Lisa Wang
2026-11-09  5:58   ` Binbin Wu
2026-11-09 19:36   ` Ackerley Tng
2026-11-10 18:57     ` Sean Christopherson
2026-11-10 21:39       ` Ackerley Tng
2026-11-11  4:50   ` Xiaoyao Li
2026-11-05 23:46 ` [PATCH v16 04/20] KVM: selftests: Expose segment definitions to assembly files Lisa Wang
2026-11-05 23:46 ` [PATCH v16 05/20] tools: include: Add kbuild.h for assembly structure offsets Lisa Wang
2026-11-05 23:46 ` [PATCH v16 06/20] KVM: selftests: Introduce structures for TDX guest boot parameters Lisa Wang
2026-11-05 23:46 ` [PATCH v16 07/20] KVM: selftests: Add TDX boot code Lisa Wang
2026-11-05 23:46 ` [PATCH v16 08/20] KVM: selftests: Expose functions to get default sregs values Lisa Wang
2026-11-09 19:40   ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 09/20] KVM: selftests: Set up TDX boot code region Lisa Wang
2026-11-09 19:55   ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 10/20] KVM: selftests: Set up TDX boot parameters region Lisa Wang
2026-11-05 23:46 ` [PATCH v16 11/20] KVM: selftests: Require guest_memfd for TDX VMs Lisa Wang
2026-11-09 19:56   ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 12/20] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu Lisa Wang
2026-11-09  9:11   ` Binbin Wu
2026-11-09 19:59   ` Ackerley Tng
2026-11-11  6:02   ` Xiaoyao Li
2026-11-05 23:46 ` [PATCH v16 13/20] KVM: selftests: Load per-vCPU guest stack in TDX boot parameters Lisa Wang
2026-11-05 23:46 ` [PATCH v16 14/20] KVM: selftests: Set entry point for TDX guest code Lisa Wang
2026-11-09 20:01   ` Ackerley Tng
2026-11-05 23:46 ` [PATCH v16 15/20] KVM: selftests: Add helpers to init TDX memory and finalize VM Lisa Wang
2026-11-05 23:47 ` [PATCH v16 16/20] KVM: selftests: Load private memory and finalize TDX VM in kvm_arch_vm_finalize_vcpus() Lisa Wang
2026-11-09 20:02   ` Ackerley Tng
2026-11-05 23:47 ` [PATCH v16 17/20] KVM: selftests: Add a helper to issue TDVMCALLs from the TDX vm Lisa Wang
2026-11-05 23:47 ` [PATCH v16 18/20] KVM: selftests: Add support for per-VM ucall ops on x86 Lisa Wang
2026-11-06 16:47   ` [PATCH v16.1] KVM: selftests: Add support for TDX ucalls, via TDVMCALL_REPORT_FATAL_ERROR Sean Christopherson
2026-11-09  8:53     ` Binbin Wu
2026-11-09 16:55     ` Sagi Shahar
2026-11-09 20:16     ` Ackerley Tng
2026-11-10 18:53       ` Sean Christopherson
2026-11-11  7:29     ` Xiaoyao Li
2026-11-11 15:22       ` Sean Christopherson [this message]
2026-11-05 23:47 ` [PATCH v16 19/20] " Lisa Wang
2026-11-05 23:47 ` [PATCH v16 20/20] KVM: selftests: Add TDX lifecycle test Lisa Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avSILzc_aB4PVapm@seanjc-mac.roam.internal \
    --to=seanjc@google.com \
    --cc=ackerleytng@google.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sagis@google.com \
    --cc=wyihan@google.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®