mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] soc: qcom: Add SoC ID for SM7550
@ 2026-11-12 10:30 Aditya Choudhury
  2026-11-12 10:30 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Aditya Choudhury
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Aditya Choudhury @ 2026-11-12 10:30 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Aditya Choudhury

Add the SoC ID for the Qualcomm SM7550 (codename "crow" in downstream) to the
dt-bindings header and the socinfo table.

This is the first set of patches for SM7550 upstream support. More
patches will follow later.

---
Aditya Choudhury (2):
      dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
      soc: qcom: socinfo: Add SoC ID for SM7550

 drivers/soc/qcom/socinfo.c         | 1 +
 include/dt-bindings/arm/qcom,ids.h | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
change-id: 20261112-sm7550-soc-id-v1-c9fed53e91b4

Best regards,
--  
Aditya Choudhury <mail@inferno0230.in>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
  2026-11-12 10:30 [PATCH 0/2] soc: qcom: Add SoC ID for SM7550 Aditya Choudhury
@ 2026-11-12 10:30 ` Aditya Choudhury
  2026-11-13  8:13   ` Konrad Dybcio
  2026-11-13 11:17   ` Krzysztof Kozlowski
  2026-11-12 10:30 ` [PATCH 2/2] soc: qcom: socinfo: " Aditya Choudhury
  2026-11-13  8:12 ` [PATCH 0/2] soc: qcom: " Konrad Dybcio
  2 siblings, 2 replies; 12+ messages in thread
From: Aditya Choudhury @ 2026-11-12 10:30 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Aditya Choudhury

Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.

Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index d89d3b5dd00c..80e6fb741def 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -283,6 +283,7 @@
 #define QCOM_ID_IPQ5302			595
 #define QCOM_ID_QCS8550			603
 #define QCOM_ID_QCM8550			604
+#define QCOM_ID_SM7550			608
 #define QCOM_ID_SM8750			618
 #define QCOM_ID_IPQ5300			624
 #define QCOM_ID_SM7635			636

-- 
2.56.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 2/2] soc: qcom: socinfo: Add SoC ID for SM7550
  2026-11-12 10:30 [PATCH 0/2] soc: qcom: Add SoC ID for SM7550 Aditya Choudhury
  2026-11-12 10:30 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Aditya Choudhury
@ 2026-11-12 10:30 ` Aditya Choudhury
  2026-11-13 11:17   ` Krzysztof Kozlowski
  2026-11-13  8:12 ` [PATCH 0/2] soc: qcom: " Konrad Dybcio
  2 siblings, 1 reply; 12+ messages in thread
From: Aditya Choudhury @ 2026-11-12 10:30 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Aditya Choudhury

Add the SoC ID table entry for SM7550.

Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
---
 drivers/soc/qcom/socinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 68148defb508..35a9a98f39bd 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -524,6 +524,7 @@ static const struct soc_id soc_id[] = {
 	{ qcom_board_id(IPQ5302) },
 	{ qcom_board_id(QCS8550) },
 	{ qcom_board_id(QCM8550) },
+	{ qcom_board_id(SM7550) },
 	{ qcom_board_id(SM8750)  },
 	{ qcom_board_id(IPQ5300) },
 	{ qcom_board_id(SM7635) },

-- 
2.56.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 0/2] soc: qcom: Add SoC ID for SM7550
  2026-11-12 10:30 [PATCH 0/2] soc: qcom: Add SoC ID for SM7550 Aditya Choudhury
  2026-11-12 10:30 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Aditya Choudhury
  2026-11-12 10:30 ` [PATCH 2/2] soc: qcom: socinfo: " Aditya Choudhury
@ 2026-11-13  8:12 ` Konrad Dybcio
  2026-11-13 14:36   ` Aditya Choudhury
  2 siblings, 1 reply; 12+ messages in thread
From: Konrad Dybcio @ 2026-11-13  8:12 UTC (permalink / raw)
  To: Aditya Choudhury, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 11/12/26 11:30 AM, Aditya Choudhury wrote:
> Add the SoC ID for the Qualcomm SM7550 (codename "crow" in downstream) to the
> dt-bindings header and the socinfo table.

Please use the real codename of Camano for the following
submissions

Konrad

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
  2026-11-12 10:30 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Aditya Choudhury
@ 2026-11-13  8:13   ` Konrad Dybcio
  2026-11-13 11:17   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 12+ messages in thread
From: Konrad Dybcio @ 2026-11-13  8:13 UTC (permalink / raw)
  To: Aditya Choudhury, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 11/12/26 11:30 AM, Aditya Choudhury wrote:
> Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.
> 
> Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
  2026-11-12 10:30 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Aditya Choudhury
  2026-11-13  8:13   ` Konrad Dybcio
@ 2026-11-13 11:17   ` Krzysztof Kozlowski
  2026-11-13 14:30     ` Aditya Choudhury
  1 sibling, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-13 11:17 UTC (permalink / raw)
  To: Aditya Choudhury
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Thu, Nov 12, 2026 at 10:30:26AM +0000, Aditya Choudhury wrote:
> Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.

From where did you get internal codename? Downstream does not use the
proper codenames.

> 
> Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
> ---
>  include/dt-bindings/arm/qcom,ids.h | 1 +
>  1 file changed, 1 insertion(+)

Where is any user of this? Why do we need such SoC patches separate from
the actual new SoC?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] soc: qcom: socinfo: Add SoC ID for SM7550
  2026-11-12 10:30 ` [PATCH 2/2] soc: qcom: socinfo: " Aditya Choudhury
@ 2026-11-13 11:17   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-13 11:17 UTC (permalink / raw)
  To: Aditya Choudhury
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Thu, Nov 12, 2026 at 10:30:27AM +0000, Aditya Choudhury wrote:
> Add the SoC ID table entry for SM7550.
> 
> Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
> ---
>  drivers/soc/qcom/socinfo.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
  2026-11-13 11:17   ` Krzysztof Kozlowski
@ 2026-11-13 14:30     ` Aditya Choudhury
  2026-11-13 14:57       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 12+ messages in thread
From: Aditya Choudhury @ 2026-11-13 14:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Fri, Nov 13, 2026 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 12, 2026 at 10:30:26AM +0000, Aditya Choudhury wrote:
> > Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.
> 
> >From where did you get internal codename? Downstream does not use the
> proper codenames.
> 
crow is the codename used in downstream sources. I assumed it was the
internal codename since SM7550 is publicly known as Snapdragon 7 Gen 3.
I was also unsure about this because SM7635 uses milos upstream instead
of volcano downstream.

> > 
> > Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
> > ---
> >  include/dt-bindings/arm/qcom,ids.h | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Where is any user of this? Why do we need such SoC patches separate from
> the actual new SoC?
> 
I sent these patches first because I expected a possible codename
change, just like what happened with SM7635. I wanted to settle the name
before sending the actual SoC support patches, so it wouldn't need to
be changed everywhere later.

There will be follow-up patches to add SM7550 support and support for
the OnePlus Nord CE 4, which is based on SM7550.

> Best regards,
> Krzysztof
> 

Best regards,
Aditya Choudhury


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 0/2] soc: qcom: Add SoC ID for SM7550
  2026-11-13  8:12 ` [PATCH 0/2] soc: qcom: " Konrad Dybcio
@ 2026-11-13 14:36   ` Aditya Choudhury
  2026-11-13 14:42     ` Konrad Dybcio
  0 siblings, 1 reply; 12+ messages in thread
From: Aditya Choudhury @ 2026-11-13 14:36 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Fri, Nov 13, 2026 at 09:12:24AM +0100, Konrad Dybcio wrote:
> On 11/12/26 11:30 AM, Aditya Choudhury wrote:
> > Add the SoC ID for the Qualcomm SM7550 (codename "crow" in downstream) to the
> > dt-bindings header and the socinfo table.
> 
> Please use the real codename of Camano for the following
> submissions

Thanks for letting me know. I'll adapt my patches to use 
camano instead.

Should I also send a v2 of this series with the codename
corrected from crow to Camano?

> 
> Konrad

Best Regards,
Aditya Choudhury


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 0/2] soc: qcom: Add SoC ID for SM7550
  2026-11-13 14:36   ` Aditya Choudhury
@ 2026-11-13 14:42     ` Konrad Dybcio
  0 siblings, 0 replies; 12+ messages in thread
From: Konrad Dybcio @ 2026-11-13 14:42 UTC (permalink / raw)
  To: Aditya Choudhury
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On 11/13/26 3:36 PM, Aditya Choudhury wrote:
> On Fri, Nov 13, 2026 at 09:12:24AM +0100, Konrad Dybcio wrote:
>> On 11/12/26 11:30 AM, Aditya Choudhury wrote:
>>> Add the SoC ID for the Qualcomm SM7550 (codename "crow" in downstream) to the
>>> dt-bindings header and the socinfo table.
>>
>> Please use the real codename of Camano for the following
>> submissions
> 
> Thanks for letting me know. I'll adapt my patches to use 
> camano instead.
> 
> Should I also send a v2 of this series with the codename
> corrected from crow to Camano?

The current commit message on this patch is accurate - downstream
calls it crow

Konrad

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
  2026-11-13 14:30     ` Aditya Choudhury
@ 2026-11-13 14:57       ` Krzysztof Kozlowski
  2026-11-13 15:59         ` Aditya Choudhury
  0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-13 14:57 UTC (permalink / raw)
  To: Aditya Choudhury
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On 13/11/2026 15:30, Aditya Choudhury wrote:
> On Fri, Nov 13, 2026 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
>> On Thu, Nov 12, 2026 at 10:30:26AM +0000, Aditya Choudhury wrote:
>>> Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.
>>
>> >From where did you get internal codename? Downstream does not use the
>> proper codenames.
>>
> crow is the codename used in downstream sources. I assumed it was the
> internal codename since SM7550 is publicly known as Snapdragon 7 Gen 3.
> I was also unsure about this because SM7635 uses milos upstream instead
> of volcano downstream.

As you can easily check, names in downstream are not codenames and have
no meaning. Don't use them.

> 
>>>
>>> Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
>>> ---
>>>  include/dt-bindings/arm/qcom,ids.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Where is any user of this? Why do we need such SoC patches separate from
>> the actual new SoC?
>>
> I sent these patches first because I expected a possible codename
> change, just like what happened with SM7635. I wanted to settle the name
> before sending the actual SoC support patches, so it wouldn't need to
> be changed everywhere later.

But this does not settle the name! You only sent SoC ID, without the
actual name. Organize your work in proper chunks, not split without
proper reason. This only limits the view and makes review unnecessarily
difficult.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550
  2026-11-13 14:57       ` Krzysztof Kozlowski
@ 2026-11-13 15:59         ` Aditya Choudhury
  0 siblings, 0 replies; 12+ messages in thread
From: Aditya Choudhury @ 2026-11-13 15:59 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Fri, Nov 13, 2026 at 03:57:17PM +0100, Krzysztof Kozlowski wrote:
> On 13/11/2026 15:30, Aditya Choudhury wrote:
> > On Fri, Nov 13, 2026 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
> >> On Thu, Nov 12, 2026 at 10:30:26AM +0000, Aditya Choudhury wrote:
> >>> Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.
> >>
> >> >From where did you get internal codename? Downstream does not use the
> >> proper codenames.
> >>
> > crow is the codename used in downstream sources. I assumed it was the
> > internal codename since SM7550 is publicly known as Snapdragon 7 Gen 3.
> > I was also unsure about this because SM7635 uses milos upstream instead
> > of volcano downstream.
> 
> As you can easily check, names in downstream are not codenames and have
> no meaning. Don't use them.
> 
> > 
> >>>
> >>> Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
> >>> ---
> >>>  include/dt-bindings/arm/qcom,ids.h | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>
> >> Where is any user of this? Why do we need such SoC patches separate from
> >> the actual new SoC?
> >>
> > I sent these patches first because I expected a possible codename
> > change, just like what happened with SM7635. I wanted to settle the name
> > before sending the actual SoC support patches, so it wouldn't need to
> > be changed everywhere later.
> 
> But this does not settle the name! You only sent SoC ID, without the
> actual name. Organize your work in proper chunks, not split without
> proper reason. This only limits the view and makes review unnecessarily
> difficult.
> 
Sorry about that. I sent only the SoC IDs because I had seen it done
that way in the git history, and I hoped it would also get the codename
sorted out first.

I can either send a v2 of this series with crow reworded to Camano, or
send the whole SoC bring-up with the SoC ID patches included in it.

If I send the whole bring-up, should it go out as v2 of this series, or
as a new series?

Either works for me, whichever you prefer.

> Best regards,
> Krzysztof

Best regards,
Aditya Choudhury

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-11-13 15:59 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-12 10:30 [PATCH 0/2] soc: qcom: Add SoC ID for SM7550 Aditya Choudhury
2026-11-12 10:30 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Aditya Choudhury
2026-11-13  8:13   ` Konrad Dybcio
2026-11-13 11:17   ` Krzysztof Kozlowski
2026-11-13 14:30     ` Aditya Choudhury
2026-11-13 14:57       ` Krzysztof Kozlowski
2026-11-13 15:59         ` Aditya Choudhury
2026-11-12 10:30 ` [PATCH 2/2] soc: qcom: socinfo: " Aditya Choudhury
2026-11-13 11:17   ` Krzysztof Kozlowski
2026-11-13  8:12 ` [PATCH 0/2] soc: qcom: " Konrad Dybcio
2026-11-13 14:36   ` Aditya Choudhury
2026-11-13 14:42     ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®