From: Christian Ruppert <arc@gmx.li>
To: Will Porter <mrwillporter@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Andrews <neil@androos.io>
Subject: Re: [RFC V4 PATCH 00/19] Re: ALSA: mixer_audient: Cache rework and simplifications
Date: Mon, 16 Nov 2026 23:19:19 +0100 [thread overview]
Message-ID: <avuBLGsTUysMqcr6@khmer.arcnet> (raw)
In-Reply-To: <20261116025336.3718463-1-mrwillporter@gmail.com>
Hi Will,
On Sun, Nov 15, 2026 at 08:53:36PM -0600, Will Porter wrote:
> [...]
> Patch 19
> --------
>
> I like it. One thing: the FU 12 type has INIT_HW and CACHE, but not
> GET_BROKEN. On the iD14, GET CUR on FU 12 does not return the FU 12
> value. It returns a reply buffer that the device shares with other
> units.
Ah, OK. I had understood this is only a problem before the value is
first written/initialized.
> If the probe write of a Cue channel fails, that channel has no cache
> entry, so the next get or put sends this GET and caches the reply.
> The control can then show a value that is not the value of that
> channel. A later put whose device value matches that reply sends no
> SET for the channel: for example, a stale 0 dB shows as 127, and a put
> of 127 sends nothing. A stale value below -127 dB can also show as a
> negative control value.
>
> So FU 12 looks to me like a write-only control with an init value.
> With GET_BROKEN, an unknown channel reads as init (mute), and every
> put sends all four channels, as the comment above ID14_FU12_* says.
>
> I checked this with a test build that skips the probe write of Cue L.
> With V4, the first access after the load sent one GET for Cue L. The
> reply was 0x8000, matching the value just written to Cue R, so Cue L
> showed 0. Puts of the shown values then sent no SET, also not for Cue
> L, which the driver had never written. With the diff, the driver sent
> no GET, Cue L showed 0, and each put sent all four channels.
>
> Does that match how you read the flags?
Yes, if the read doesn't work we should not rely on it so let's mark it as
broken.
> > We could even get rid of the FU12 specific value type if the iD14
> > accepts -127 * 256 as a volume setting
>
> The device accepts a SET of -127 dB without a stall, but I tested
> that only on Main L, which the firmware ignores. On Cue, -126 dB and
> mute (0x8000) both measure at the same small residual level that the
> headphone output keeps. I have not tested a SET of -127 dB on Cue.
> The type also has to stay for now, because it holds Main at 0 dB. So
> I would keep value 0 as mute in this series. Could we do the plain
> integer together with your don't-touch channel mask as a follow-up?
agreed. let's push this into the follow-up.
> Patch 18
> --------
>
> The old gets read only the channels below hwchannels and filled in the
> rest. The new get reads every channel and then ignores the value of
> the channels at or above hwchannels, so an error on such a channel
> fails the whole get. I think this affects only the EVO4 "Mic Playback
> Switch" (4 channels, 2 on the device): it now also sends GET for CN 2
> and 3. Does the EVO4 answer those? Either way, the diff skips the
> transfer for those channels and keeps the values they show now.
yes, the channels marked as sw-only are actually read-only. Probably
something to address in the follow-up if we want to make it properly
clean. but your patch is fine for now, this way the behaviour is
consistent with what we had before.
> Small things, also in the diff:
>
> - raw_get_one() and raw_set_one() accept cidx == MAX_CHANNELS, but
> cache_val[] has MAX_CHANNELS entries. No table reaches it (the
> highest channel is 55), so ">=" is only a guard.
> - Two comments from patch 10 still say FORCE_SET.
> - Patch 19 removes extra_init but keeps its comment.
Great, thanks for reviewing and fixing these. I tested the diff on 7.3.4
and everything works like before.
> Next steps
> ----------
>
> After patch 19, nothing of patch 16's own FU 12 code is left. So I
> would drop patch 16 and send one FU 12 patch after patch 18: the
> control as patch 16 describes it, built on the unified get and put
> with your code from patch 19. Would you like to be its author, with a
> Co-developed-by for me, or the other way round?
I think it's best if you're the author if you agree. My patch 19 was
little more than a sketch, definitely not intended for submission, and if
you want to replace patch 16 altogether I suspect you'll have to rework it
anyway.
> A note on trailers: V4 dropped "Assisted-by: Claude:claude-opus-5-5"
> from patches 8, 11 and 12 to 16. I put it back on them, and I added it
> to patch 10, because patch 10 now holds code from my cache patch.
Yes, these tags don't pass checkpatch on recent kernels anymore and all
mention of it was removed from the documentation in commit 1e035297ffdadf.
I don't know any more details than the commit message but apparently it
wasn't respected and thus useless.
> May I fold the diff into your patches 10, 18 and 19 for the final
> series? I would send it as a normal series, not as another RFC.
> Should it wait for Takashi's answer on your four mixer_evo fixes, or
> carry them at the front?
Yes, please do so and add your tags to the commit messages. I don't think
there's a need for another iteration unless if final testing discovers a
major flaw on either hardware. Concerning the four fixes let's give
Takashi another week or two and then submit with or without them,
depending on what he says. There should still be enough time before the
merge window.
Thanks,
Christian
next prev parent reply other threads:[~2026-11-16 22:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <sashiko-outbox-201869@kernel.org>
2026-11-06 20:29 ` [RFC PATCH 13/16] ALSA: mixer_audient: Add enumerated controls Will Porter
2026-11-09 22:30 ` Christian Ruppert
2026-11-10 2:13 ` Will Porter
2026-11-10 20:57 ` Christian Ruppert
2026-11-12 2:37 ` [RFC PATCH 0/6] ALSA: mixer_audient: Cache rework and simplifications Will Porter
2026-11-12 2:37 ` [RFC PATCH 1/6] ALSA: mixer_audient: Fold in the review changes to patches 12-16 Will Porter
2026-11-12 2:37 ` [RFC PATCH 2/6] ALSA: mixer_audient: Use the cache of usb_mixer_elem_info Will Porter
2026-11-12 2:37 ` [RFC PATCH 3/6] ALSA: mixer_audient: Replace three flags with an access mode Will Porter
2026-11-12 2:37 ` [RFC PATCH 4/6] ALSA: mixer_audient: Fill the cache on first use Will Porter
2026-11-12 2:37 ` [RFC PATCH 5/6] ALSA: mixer_audient: Use one get and one put for all control types Will Porter
2026-11-12 2:37 ` [RFC PATCH 6/6] ALSA: mixer_audient: Use the same cache for the iD14 MkI FU 12 control Will Porter
2026-11-15 21:43 ` [RFC V4 PATCH 00/19] Re: ALSA: mixer_audient: Cache rework and simplifications Christian Ruppert
2026-11-16 2:53 ` Will Porter
2026-11-16 22:19 ` Christian Ruppert [this message]
2026-11-15 21:43 ` [RFC V4 PATCH 01/19] ALSA: rename mixer_evo to mixer_audient Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 02/19] ALSA: mixer_audient: explicitly define full control names Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 03/19] ALSA: mixer_audient: clarify USB control message definition Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 04/19] ALSA: mixer_audient: Add length check to USB transfer Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 05/19] ALSA: mixer_audient: make USB control transfer size configurable Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 06/19] ALSA: mixer_audient: Allow arbitrary boolean control values Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 07/19] ALSA: mixer_audient: Add integer range checks Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 08/19] ALSA: mixer_audient: Add control initialization at probe Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 09/19] ALSA: mixer_audient: Add readback-free parameter set Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 10/19] ALSA: mixer_audient: add control value caching Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 11/19] ALSA: mixer_audient: Create matrix programmatically Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 12/19] ALSA: mixer_audient: Add a step size to integer controls Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 13/19] ALSA: mixer_audient: Add enumerated controls Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 14/19] ALSA: usb-audio: Give the Audient iD14 MkI its own mixer map Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 15/19] ALSA: mixer_audient: Add Audient iD14 MkI controls Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 16/19] ALSA: mixer_audient: Replace the Audient iD14 MkI FU 12 control Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 17/19] ALSA: mixer_audient: Fold in the review changes to patches 12-16 Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 18/19] ALSA: mixer_audient: Unify snd_audient_*_set/get functions for different types Christian Ruppert
2026-11-15 21:43 ` [RFC V4 PATCH 19/19] ALSA: mixer_audient: Refactor FU12 special cases into generic set/get functions Christian Ruppert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avuBLGsTUysMqcr6@khmer.arcnet \
--to=arc@gmx.li \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mrwillporter@gmail.com \
--cc=neil@androos.io \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®