From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: "Philip, Avinash" <avinashphilip@ti.com>,
Vaibhav Bedia <vaibhav.bedia@ti.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 7/8] pwm: tiehrpwm: Enable runtime PM before registering PWM chip
Date: Fri, 20 Nov 2026 13:06:10 +0100 [thread overview]
Message-ID: <awA3Cfrm8lHE2uLH@monoceros> (raw)
In-Reply-To: <20261105143847.2559586-8-lee@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]
Hello,
On Thu, Nov 05, 2026 at 02:38:09PM +0000, Lee Jones wrote:
> ehrpwm_pwm_probe() calls pwmchip_add() before setting driver data and
> enabling runtime PM. Because pwmchip_add() immediately exposes the PWM
> channels to consumers, a consumer can invoke ehrpwm_pwm_apply() before
> pm_runtime_enable() runs, causing registers to be accessed while the
> device remains runtime-suspended.
Is this correct? Until pm_runtime_enable() is called the device doesn't
go into suspend, does it?
> Set driver data and enable runtime PM before calling pwmchip_add(), and
> disable runtime PM on the error path.
>
> Fixes: 19891b20e7c2 ("pwm: pwm-tiehrpwm: PWM driver support for EHRPWM")
> Closes: https://sashiko.dev/#/bug/linux-28b36a80-e4a9-4bb6-97bc-7ca02895570a
> Cc: stable@vger.kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> drivers/pwm/pwm-tiehrpwm.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index e3407d0a1f7f..f9dd3b91c73a 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -461,18 +461,19 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = pwmchip_add(chip);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
> - goto err_clk_unprepare;
> - }
> -
> platform_set_drvdata(pdev, chip);
> pm_runtime_enable(&pdev->dev);
>
> + ret = pwmchip_add(chip);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
> + goto err_pm_disable;
> + }
> +
If you switch the order here, it would be awesome to also switch in the
.remove() callback to have the order match.
> return 0;
>
> -err_clk_unprepare:
> +err_pm_disable:
> + pm_runtime_disable(&pdev->dev);
> clk_unprepare(pc->tbclk);
>
> return ret;
> Cc: "Philip, Avinash" <avinashphilip@ti.com>
> --
> 2.56.0.398.g882cbad275-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-20 12:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:38 [PATCH 0/8] pwm: Fix various bugs reported by Sashiko Lee Jones
2026-11-05 14:38 ` [PATCH 1/8] pwm: tegra: Prevent 32-bit period truncation and division by zero Lee Jones
2026-11-05 15:46 ` Uwe Kleine-König
2026-11-18 17:16 ` Lee Jones
2026-11-19 14:44 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 2/8] pwm: mxs: Return early when disabling and fix error-path clock leak Lee Jones
2026-11-05 16:50 ` Frank Li
2026-11-20 12:12 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 3/8] pwm: loongson: Fix 32-bit control register truncation in pwm_loongson_set_polarity() Lee Jones
2026-11-05 14:38 ` [PATCH 4/8] pwm: axi-pwmgen: Enable clocks before accessing hardware registers in probe() Lee Jones
2026-11-05 15:48 ` Uwe Kleine-König
2026-11-05 18:26 ` Lee Jones
2026-11-05 18:26 ` Lee Jones
2026-11-06 13:01 ` Nuno Sá
2026-11-05 14:38 ` [PATCH 5/8] pwm: fsl-ftm: Enable ipg_clk around regcache_sync() during resume Lee Jones
2026-11-20 12:02 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 6/8] pwm: omap-dmtimer: Handle negative error codes from get_pwm_status() Lee Jones
2026-11-20 11:57 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 7/8] pwm: tiehrpwm: Enable runtime PM before registering PWM chip Lee Jones
2026-11-20 12:06 ` Uwe Kleine-König [this message]
2026-11-05 14:38 ` [PATCH 8/8] pwm: img: Unregister PWM chip before disabling runtime PM and clocks Lee Jones
2026-11-20 12:10 ` Uwe Kleine-König
2026-11-20 12:17 ` [PATCH 0/8] pwm: Fix various bugs reported by Sashiko Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awA3Cfrm8lHE2uLH@monoceros \
--to=ukleinek@kernel.org \
--cc=avinashphilip@ti.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®