* [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
@ 2026-11-20 17:40 ` Daniel Golle
2026-11-20 20:19 ` Diederik de Haas
2026-11-21 13:12 ` Krzysztof Kozlowski
2026-11-20 17:40 ` [PATCH v5 2/5] media: rkvdec: Add support for the VDPU346 variant Daniel Golle
` (5 subsequent siblings)
6 siblings, 2 replies; 13+ messages in thread
From: Daniel Golle @ 2026-11-20 17:40 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Christian Hewitt,
Marc Zyngier, linux-media, linux-rockchip, devicetree,
linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
From: Christian Hewitt <christianshewitt@gmail.com>
The video decoder in RK356X (vdpu346) is described in the same way as
the one in RK3588 (vdpu381). A new compatible is added as the decoder
capabilities are a subset of the vdpu381 capabilities.
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Tested-by: Diederik de Haas <diederik@cknow-tech.com> # PineTab2, Quartz64-A, NanoPi R5S
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v5: no changes
v4: add Tested-by from Diederik de Haas
---
Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
index 4f38a0ef29d84..ea5386e84f17e 100644
--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -18,6 +18,7 @@ properties:
oneOf:
- const: rockchip,rk3288-vdec
- const: rockchip,rk3399-vdec
+ - const: rockchip,rk3568-vdec
- const: rockchip,rk3576-vdec
- const: rockchip,rk3588-vdec
- items:
@@ -110,6 +111,7 @@ allOf:
compatible:
contains:
enum:
+ - rockchip,rk3568-vdec
- rockchip,rk3576-vdec
- rockchip,rk3588-vdec
then:
--
2.56.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings
2026-11-20 17:40 ` [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings Daniel Golle
@ 2026-11-20 20:19 ` Diederik de Haas
2026-11-20 20:24 ` Daniel Golle
2026-11-21 13:12 ` Krzysztof Kozlowski
1 sibling, 1 reply; 13+ messages in thread
From: Diederik de Haas @ 2026-11-20 20:19 UTC (permalink / raw)
To: Daniel Golle, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Shawn Lin, Michael Riesch,
David Heidelberg, Christian Hewitt, Marc Zyngier, linux-media,
linux-rockchip, devicetree, linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
On Fri Nov 20, 2026 at 6:40 PM CET, Daniel Golle wrote:
> From: Christian Hewitt <christianshewitt@gmail.com>
>
> The video decoder in RK356X (vdpu346) is described in the same way as
> the one in RK3588 (vdpu381). A new compatible is added as the decoder
> capabilities are a subset of the vdpu381 capabilities.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Tested-by: Diederik de Haas <diederik@cknow-tech.com> # PineTab2, Quartz64-A, NanoPi R5S
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> v5: no changes
> v4: add Tested-by from Diederik de Haas
I don't think a Tested-by tag is appropriate for a DT binding patch?
>
> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 4f38a0ef29d84..ea5386e84f17e 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -18,6 +18,7 @@ properties:
> oneOf:
> - const: rockchip,rk3288-vdec
> - const: rockchip,rk3399-vdec
> + - const: rockchip,rk3568-vdec
> - const: rockchip,rk3576-vdec
> - const: rockchip,rk3588-vdec
> - items:
> @@ -110,6 +111,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - rockchip,rk3568-vdec
> - rockchip,rk3576-vdec
> - rockchip,rk3588-vdec
> then:
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings
2026-11-20 20:19 ` Diederik de Haas
@ 2026-11-20 20:24 ` Daniel Golle
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Golle @ 2026-11-20 20:24 UTC (permalink / raw)
To: Diederik de Haas
Cc: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Christian Hewitt,
Marc Zyngier, linux-media, linux-rockchip, devicetree,
linux-arm-kernel, linux-kernel, Nicolas Dufresne, Hans Verkuil,
Jonas Karlman, Dang Huynh, Piotr Oniszczuk
On Fri, Nov 20, 2026 at 09:19:24PM +0100, Diederik de Haas wrote:
> On Fri Nov 20, 2026 at 6:40 PM CET, Daniel Golle wrote:
> > From: Christian Hewitt <christianshewitt@gmail.com>
> >
> > The video decoder in RK356X (vdpu346) is described in the same way as
> > the one in RK3588 (vdpu381). A new compatible is added as the decoder
> > capabilities are a subset of the vdpu381 capabilities.
> >
> > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> > Acked-by: Rob Herring (Arm) <robh@kernel.org>
> > Tested-by: Diederik de Haas <diederik@cknow-tech.com> # PineTab2, Quartz64-A, NanoPi R5S
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > v5: no changes
> > v4: add Tested-by from Diederik de Haas
>
> I don't think a Tested-by tag is appropriate for a DT binding patch?
Yes, and I was planning to drop that, but then messed up...
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings
2026-11-20 17:40 ` [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings Daniel Golle
2026-11-20 20:19 ` Diederik de Haas
@ 2026-11-21 13:12 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-21 13:12 UTC (permalink / raw)
To: Daniel Golle, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Shawn Lin, Michael Riesch,
David Heidelberg, Christian Hewitt, Marc Zyngier, linux-media,
linux-rockchip, devicetree, linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
On 20/11/2026 18:40, Daniel Golle wrote:
> From: Christian Hewitt <christianshewitt@gmail.com>
>
> The video decoder in RK356X (vdpu346) is described in the same way as
> the one in RK3588 (vdpu381). A new compatible is added as the decoder
> capabilities are a subset of the vdpu381 capabilities.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Tested-by: Diederik de Haas <diederik@cknow-tech.com> # PineTab2, Quartz64-A, NanoPi R5S
You just ignored my feedback.
NAK
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v5 2/5] media: rkvdec: Add support for the VDPU346 variant
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
2026-11-20 17:40 ` [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings Daniel Golle
@ 2026-11-20 17:40 ` Daniel Golle
2026-11-20 17:41 ` [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches Daniel Golle
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Daniel Golle @ 2026-11-20 17:40 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Christian Hewitt,
Marc Zyngier, linux-media, linux-rockchip, devicetree,
linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
From: Christian Hewitt <christianshewitt@gmail.com>
VDPU346 is similar to VDPU381 but with a single core and limited
to 4K60 media. It is also limited to H264 L5.1 and omits AV1 and
AVS2 capabilities. VDPU346 is used with RK3566 and RK3568.
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Tested-by: Dang Huynh <dang.huynh@mainlining.org> # Pinetab2
Tested-by: Diederik de Haas <diederik@cknow-tech.com> # PineTab2, Quartz64-A, NanoPi R5S
[daniel: EXT SPS RPS dims 64 and 32 as of commit f0b9d7e5be06]
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v5: fold in "media: rkvdec: vdpu346: Limit HEVC EXT SPS RPS dimensions",
registering the EXT SPS RPS controls with 64 and 32 elements
v4: add Tested-by from Diederik de Haas
---
.../media/platform/rockchip/rkvdec/rkvdec.c | 103 ++++++++++++++++++
1 file changed, 103 insertions(+)
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
index 5250dd59df2ec..ba61e373b4342 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
@@ -236,6 +236,62 @@ static const struct rkvdec_ctrls rkvdec_hevc_ctrls = {
.num_ctrls = ARRAY_SIZE(rkvdec_hevc_ctrl_descs),
};
+static const struct rkvdec_ctrl_desc vdpu346_hevc_ctrl_descs[] = {
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_DECODE_PARAMS,
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_SPS,
+ .cfg.ops = &rkvdec_ctrl_ops,
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_PPS,
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_SCALING_MATRIX,
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_DECODE_MODE,
+ .cfg.min = V4L2_STATELESS_HEVC_DECODE_MODE_FRAME_BASED,
+ .cfg.max = V4L2_STATELESS_HEVC_DECODE_MODE_FRAME_BASED,
+ .cfg.def = V4L2_STATELESS_HEVC_DECODE_MODE_FRAME_BASED,
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_START_CODE,
+ .cfg.min = V4L2_STATELESS_HEVC_START_CODE_ANNEX_B,
+ .cfg.def = V4L2_STATELESS_HEVC_START_CODE_ANNEX_B,
+ .cfg.max = V4L2_STATELESS_HEVC_START_CODE_ANNEX_B,
+ },
+ {
+ .cfg.id = V4L2_CID_MPEG_VIDEO_HEVC_PROFILE,
+ .cfg.min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
+ .cfg.max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
+ .cfg.menu_skip_mask =
+ BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
+ .cfg.def = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
+ },
+ {
+ .cfg.id = V4L2_CID_MPEG_VIDEO_HEVC_LEVEL,
+ .cfg.min = V4L2_MPEG_VIDEO_HEVC_LEVEL_1,
+ .cfg.max = V4L2_MPEG_VIDEO_HEVC_LEVEL_5_1,
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_EXT_SPS_ST_RPS,
+ .cfg.ops = &rkvdec_ctrl_ops,
+ .cfg.dims = { 64 },
+ },
+ {
+ .cfg.id = V4L2_CID_STATELESS_HEVC_EXT_SPS_LT_RPS,
+ .cfg.ops = &rkvdec_ctrl_ops,
+ .cfg.dims = { 32 },
+ },
+};
+
+static const struct rkvdec_ctrls vdpu346_hevc_ctrls = {
+ .ctrls = vdpu346_hevc_ctrl_descs,
+ .num_ctrls = ARRAY_SIZE(vdpu346_hevc_ctrl_descs),
+};
+
static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = {
{
.cfg.id = V4L2_CID_STATELESS_HEVC_DECODE_PARAMS,
@@ -510,6 +566,41 @@ static const struct rkvdec_coded_fmt_desc rk3288_coded_fmts[] = {
}
};
+static const struct rkvdec_coded_fmt_desc vdpu346_coded_fmts[] = {
+ {
+ .fourcc = V4L2_PIX_FMT_HEVC_SLICE,
+ .frmsize = {
+ .min_width = 64,
+ .max_width = 4096,
+ .step_width = 64,
+ .min_height = 64,
+ .max_height = 2304,
+ .step_height = 16,
+ },
+ .ctrls = &vdpu346_hevc_ctrls,
+ .ops = &rkvdec_vdpu381_hevc_fmt_ops,
+ .num_decoded_fmts = ARRAY_SIZE(rkvdec_hevc_decoded_fmts),
+ .decoded_fmts = rkvdec_hevc_decoded_fmts,
+ .subsystem_flags = VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_H264_SLICE,
+ .frmsize = {
+ .min_width = 64,
+ .max_width = 4096,
+ .step_width = 64,
+ .min_height = 64,
+ .max_height = 2304,
+ .step_height = 16,
+ },
+ .ctrls = &rkvdec_h264_ctrls,
+ .ops = &rkvdec_vdpu381_h264_fmt_ops,
+ .num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_decoded_fmts),
+ .decoded_fmts = rkvdec_h264_decoded_fmts,
+ .subsystem_flags = VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF,
+ },
+};
+
static const struct rkvdec_coded_fmt_desc vdpu381_coded_fmts[] = {
{
.fourcc = V4L2_PIX_FMT_HEVC_SLICE,
@@ -1704,6 +1795,14 @@ static const struct rkvdec_variant_ops vdpu381_variant_ops = {
.flatten_matrices = transpose_and_flatten_matrices,
};
+static const struct rkvdec_variant vdpu346_variant = {
+ .coded_fmts = vdpu346_coded_fmts,
+ .num_coded_fmts = ARRAY_SIZE(vdpu346_coded_fmts),
+ .rcb_sizes = vdpu381_rcb_sizes,
+ .num_rcb_sizes = ARRAY_SIZE(vdpu381_rcb_sizes),
+ .ops = &vdpu381_variant_ops,
+};
+
static const struct rkvdec_variant vdpu381_variant = {
.coded_fmts = vdpu381_coded_fmts,
.num_coded_fmts = ARRAY_SIZE(vdpu381_coded_fmts),
@@ -1752,6 +1851,10 @@ static const struct of_device_id of_rkvdec_match[] = {
.compatible = "rockchip,rk3399-vdec",
.data = &rk3399_rkvdec_variant,
},
+ {
+ .compatible = "rockchip,rk3568-vdec",
+ .data = &vdpu346_variant,
+ },
{
.compatible = "rockchip,rk3588-vdec",
.data = &vdpu381_variant,
--
2.56.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
2026-11-20 17:40 ` [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings Daniel Golle
2026-11-20 17:40 ` [PATCH v5 2/5] media: rkvdec: Add support for the VDPU346 variant Daniel Golle
@ 2026-11-20 17:41 ` Daniel Golle
2026-11-20 21:20 ` Nicolas Dufresne
2026-11-20 17:41 ` [PATCH v5 4/5] arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X Daniel Golle
` (3 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Golle @ 2026-11-20 17:41 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Christian Hewitt,
Marc Zyngier, linux-media, linux-rockchip, devicetree,
linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
The VDPU381 and VDPU346 have three read caches, configured through the
"cache" register block. The driver leaves them in their reset state,
and on the RK3568 some streams then decode with wrong output.
Configure and clear the caches before each H.264 and HEVC run, the way
the vendor kernel driver does. The "cache" block, which the binding
requires, is now mapped at probe for every variant with named register
blocks; the VDPU383 does not use it.
On the RK3568 this fixes the HEVC conformance vectors RAP_B_Bossen_2,
WPP_D_ericsson_MAIN_2, WPP_D_ericsson_MAIN10_2 and
WPP_E_ericsson_MAIN_2 and the H.264 vectors CAPM3_Sony_D, MR8_BT_B,
MR9_BT_B and NRF_MW_E.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v5: shorten the commit message, state that the cache block is mapped
for the VDPU383 as well; no code changes
v4: new patch
---
.../rockchip/rkvdec/rkvdec-vdpu381-h264.c | 2 ++
.../rockchip/rkvdec/rkvdec-vdpu381-hevc.c | 2 ++
.../rockchip/rkvdec/rkvdec-vdpu381-regs.h | 9 +++++++++
.../media/platform/rockchip/rkvdec/rkvdec.c | 18 ++++++++++++++++++
.../media/platform/rockchip/rkvdec/rkvdec.h | 2 ++
5 files changed, 33 insertions(+)
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-h264.c b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-h264.c
index b961fddc8583a..40db8ba3856a7 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-h264.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-h264.c
@@ -445,6 +445,8 @@ static int rkvdec_h264_run(struct rkvdec_ctx *ctx)
rkvdec_schedule_watchdog(rkvdec, h264_ctx->regs.common.reg032_timeout_threshold);
+ rkvdec_vdpu381_config_cache(rkvdec);
+
/* Start decoding! */
writel(VDPU381_DEC_E_BIT, rkvdec->regs + VDPU381_REG_DEC_E);
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-hevc.c b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-hevc.c
index e1936e87f45be..8afb13866d0bb 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-hevc.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-hevc.c
@@ -617,6 +617,8 @@ static int rkvdec_hevc_run(struct rkvdec_ctx *ctx)
rkvdec_schedule_watchdog(rkvdec, hevc_ctx->regs.common.reg032_timeout_threshold);
+ rkvdec_vdpu381_config_cache(rkvdec);
+
/* Start decoding! */
writel(VDPU381_DEC_E_BIT, rkvdec->regs + VDPU381_REG_DEC_E);
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
index 6da36031df2dc..b23b47217d43b 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
@@ -41,6 +41,15 @@
#define VDPU381_STA_INT_TIMEOUT BIT(5)
#define VDPU381_STA_INT_SOFTRESET_RDY BIT(9)
+/* base: "cache" register block */
+#define VDPU381_CACHE_COUNT 3
+#define VDPU381_REG_CACHE_CLR(i) (0x010 + (i) * 0x40)
+#define VDPU381_CACHE_CLR BIT(0)
+#define VDPU381_REG_CACHE_SIZE(i) (0x01c + (i) * 0x40)
+#define VDPU381_CACHE_PERMIT_CACHEABLE_ACCESS BIT(0)
+#define VDPU381_CACHE_PERMIT_READ_ALLOCATE BIT(1)
+#define VDPU381_CACHE_LINE_SIZE_64_BYTES BIT(4)
+
/* base: OFFSET_COMMON_REGS */
struct rkvdec_vdpu381_regs_common {
struct {
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
index ba61e373b4342..5673c5205bfcd 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
@@ -1249,6 +1249,20 @@ void rkvdec_schedule_watchdog(struct rkvdec_dev *rkvdec, u32 timeout_threshold)
schedule_delayed_work(&rkvdec->watchdog_work, msecs_to_jiffies(watchdog_time));
}
+void rkvdec_vdpu381_config_cache(struct rkvdec_dev *rkvdec)
+{
+ u32 cfg = VDPU381_CACHE_PERMIT_CACHEABLE_ACCESS |
+ VDPU381_CACHE_PERMIT_READ_ALLOCATE |
+ VDPU381_CACHE_LINE_SIZE_64_BYTES;
+ unsigned int i;
+
+ for (i = 0; i < VDPU381_CACHE_COUNT; i++)
+ writel(cfg, rkvdec->cache + VDPU381_REG_CACHE_SIZE(i));
+
+ for (i = 0; i < VDPU381_CACHE_COUNT; i++)
+ writel(VDPU381_CACHE_CLR, rkvdec->cache + VDPU381_REG_CACHE_CLR(i));
+}
+
static void rkvdec_device_run(void *priv)
{
struct rkvdec_ctx *ctx = priv;
@@ -1910,6 +1924,10 @@ static int rkvdec_probe(struct platform_device *pdev)
rkvdec->link = devm_platform_ioremap_resource_byname(pdev, "link");
if (IS_ERR(rkvdec->link))
return PTR_ERR(rkvdec->link);
+
+ rkvdec->cache = devm_platform_ioremap_resource_byname(pdev, "cache");
+ if (IS_ERR(rkvdec->cache))
+ return PTR_ERR(rkvdec->cache);
}
ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.h b/drivers/media/platform/rockchip/rkvdec/rkvdec.h
index a24be6638b6b7..54e6f50c0ff9f 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec.h
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.h
@@ -136,6 +136,7 @@ struct rkvdec_dev {
struct clk *axi_clk;
void __iomem *regs;
void __iomem *link;
+ void __iomem *cache;
struct mutex vdev_lock; /* serializes ioctls */
struct delayed_work watchdog_work;
struct gen_pool *sram_pool;
@@ -180,6 +181,7 @@ void rkvdec_run_preamble(struct rkvdec_ctx *ctx, struct rkvdec_run *run);
void rkvdec_run_postamble(struct rkvdec_ctx *ctx, struct rkvdec_run *run);
void rkvdec_memcpy_toio(void __iomem *dst, void *src, size_t len);
void rkvdec_schedule_watchdog(struct rkvdec_dev *rkvdec, u32 timeout_threshold);
+void rkvdec_vdpu381_config_cache(struct rkvdec_dev *rkvdec);
void rkvdec_quirks_disable_qos(struct rkvdec_ctx *ctx);
--
2.56.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches
2026-11-20 17:41 ` [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches Daniel Golle
@ 2026-11-20 21:20 ` Nicolas Dufresne
0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Dufresne @ 2026-11-20 21:20 UTC (permalink / raw)
To: Daniel Golle, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Shawn Lin, Michael Riesch,
David Heidelberg, Christian Hewitt, Marc Zyngier, linux-media,
linux-rockchip, devicetree, linux-arm-kernel, linux-kernel
Cc: Hans Verkuil, Jonas Karlman, Diederik de Haas, Dang Huynh,
Piotr Oniszczuk
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
Le vendredi 20 novembre 2026 à 17:41 +0000, Daniel Golle a écrit :
> The VDPU381 and VDPU346 have three read caches, configured through the
> "cache" register block. The driver leaves them in their reset state,
> and on the RK3568 some streams then decode with wrong output.
>
> Configure and clear the caches before each H.264 and HEVC run, the way
> the vendor kernel driver does. The "cache" block, which the binding
> requires, is now mapped at probe for every variant with named register
> blocks; the VDPU383 does not use it.
>
> On the RK3568 this fixes the HEVC conformance vectors RAP_B_Bossen_2,
> WPP_D_ericsson_MAIN_2, WPP_D_ericsson_MAIN10_2 and
> WPP_E_ericsson_MAIN_2 and the H.264 vectors CAPM3_Sony_D, MR8_BT_B,
> MR9_BT_B and NRF_MW_E.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v5 4/5] arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
` (2 preceding siblings ...)
2026-11-20 17:41 ` [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches Daniel Golle
@ 2026-11-20 17:41 ` Daniel Golle
2026-11-20 17:42 ` [PATCH v5 5/5] arm64: dts: rockchip: rk356x: Clock the vdec at 400 MHz Daniel Golle
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Daniel Golle @ 2026-11-20 17:41 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Christian Hewitt,
Marc Zyngier, linux-media, linux-rockchip, devicetree,
linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
From: Christian Hewitt <christianshewitt@gmail.com>
Add the vdpu346 Video Decoders to the rk356x-base devicetree to
enable support on RK3566 and RK3568 boards. Also add the needed
sram and vdec_mmu nodes.
Suggested-by: Diederik de Haas <diederik@cknow-tech.com>
Suggested-by: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Tested-by: Diederik de Haas <diederik@cknow-tech.com> # PineTab2, Quartz64-A, NanoPi R5S
[daniel: link, function, cache reg order, codec-sram node name]
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v5: fold in "arm64: dts: rockchip: rk356x: Order vdec regs by address",
name the SRAM pool node codec-sram as on the RK3588
v4: add Tested-by from Diederik de Haas
---
arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 49 +++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
index 1a4562df20ee5..411c9ed62d4ac 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
@@ -402,6 +402,19 @@ usb2phy1_grf: syscon@fdca8000 {
reg = <0x0 0xfdca8000 0x0 0x8000>;
};
+ sram@fdcc0000 {
+ compatible = "mmio-sram";
+ reg = <0x0 0xfdcc0000 0x0 0xb000>;
+ ranges = <0x0 0x0 0xfdcc0000 0xb000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ vdec_sram: codec-sram@0 {
+ reg = <0x0 0xb000>;
+ pool;
+ };
+ };
+
pmucru: clock-controller@fdd00000 {
compatible = "rockchip,rk3568-pmucru";
reg = <0x0 0xfdd00000 0x0 0x1000>;
@@ -638,6 +651,42 @@ vepu_mmu: iommu@fdee0800 {
#iommu-cells = <0>;
};
+ vdec: video-codec@fdf80100 {
+ compatible = "rockchip,rk3568-vdec";
+ reg = <0x0 0xfdf80100 0x0 0x100>,
+ <0x0 0xfdf80200 0x0 0x500>,
+ <0x0 0xfdf80700 0x0 0x100>;
+ reg-names = "link", "function", "cache";
+ interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_RKVDEC>, <&cru HCLK_RKVDEC>,
+ <&cru CLK_RKVDEC_CA>, <&cru CLK_RKVDEC_CORE>,
+ <&cru CLK_RKVDEC_HEVC_CA>;
+ clock-names = "axi", "ahb", "cabac", "core", "hevc_cabac";
+ assigned-clocks = <&cru ACLK_RKVDEC>,
+ <&cru CLK_RKVDEC_CORE>,
+ <&cru CLK_RKVDEC_CA>,
+ <&cru CLK_RKVDEC_HEVC_CA>;
+ assigned-clock-rates = <297000000>, <297000000>,
+ <297000000>, <600000000>;
+ iommus = <&vdec_mmu>;
+ power-domains = <&power RK3568_PD_RKVDEC>;
+ resets = <&cru SRST_A_RKVDEC>, <&cru SRST_H_RKVDEC>,
+ <&cru SRST_RKVDEC_CA>, <&cru SRST_RKVDEC_CORE>,
+ <&cru SRST_RKVDEC_HEVC_CA>;
+ reset-names = "axi", "ahb", "cabac", "core", "hevc_cabac";
+ sram = <&vdec_sram>;
+ };
+
+ vdec_mmu: iommu@fdf80800 {
+ compatible = "rockchip,rk3568-iommu";
+ reg = <0x0 0xfdf80800 0x0 0x40>, <0x0 0xfdf80840 0x0 0x40>;
+ interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_RKVDEC>, <&cru HCLK_RKVDEC>;
+ clock-names = "aclk", "iface";
+ power-domains = <&power RK3568_PD_RKVDEC>;
+ #iommu-cells = <0>;
+ };
+
vicap: video-capture@fdfe0000 {
compatible = "rockchip,rk3568-vicap";
reg = <0x0 0xfdfe0000 0x0 0x200>;
--
2.56.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH v5 5/5] arm64: dts: rockchip: rk356x: Clock the vdec at 400 MHz
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
` (3 preceding siblings ...)
2026-11-20 17:41 ` [PATCH v5 4/5] arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X Daniel Golle
@ 2026-11-20 17:42 ` Daniel Golle
2026-11-20 20:16 ` [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Diederik de Haas
2026-11-22 7:44 ` Christian Hewitt
6 siblings, 0 replies; 13+ messages in thread
From: Daniel Golle @ 2026-11-20 17:42 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Christian Hewitt,
Marc Zyngier, linux-media, linux-rockchip, devicetree,
linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
The decoder AXI, core and CABAC clocks are assigned 297 MHz, the rate
the vendor kernel derives as a quarter of its 1188 MHz GPLL. This dtsi
runs the GPLL at 1200 MHz, from which the closest rate below 297 MHz
is 240 MHz.
Assign 400 MHz, a third of the GPLL. The vendor kernel clocks the
decoder at a third of its GPLL for streams above 1920x1088 and lists
400 MHz at 900 mV as the highest decoder operating point. The rkvdec
driver scales neither the clocks nor the supply, so the rate applies
to every stream.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v5: state that the rate applies to all streams; no changes to the dtsi
v4: new patch
---
arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
index 411c9ed62d4ac..6305a57258b4c 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
@@ -666,8 +666,8 @@ vdec: video-codec@fdf80100 {
<&cru CLK_RKVDEC_CORE>,
<&cru CLK_RKVDEC_CA>,
<&cru CLK_RKVDEC_HEVC_CA>;
- assigned-clock-rates = <297000000>, <297000000>,
- <297000000>, <600000000>;
+ assigned-clock-rates = <400000000>, <400000000>,
+ <400000000>, <600000000>;
iommus = <&vdec_mmu>;
power-domains = <&power RK3568_PD_RKVDEC>;
resets = <&cru SRST_A_RKVDEC>, <&cru SRST_H_RKVDEC>,
--
2.56.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
` (4 preceding siblings ...)
2026-11-20 17:42 ` [PATCH v5 5/5] arm64: dts: rockchip: rk356x: Clock the vdec at 400 MHz Daniel Golle
@ 2026-11-20 20:16 ` Diederik de Haas
2026-11-22 7:44 ` Christian Hewitt
6 siblings, 0 replies; 13+ messages in thread
From: Diederik de Haas @ 2026-11-20 20:16 UTC (permalink / raw)
To: Daniel Golle, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Shawn Lin, Michael Riesch,
David Heidelberg, Christian Hewitt, Marc Zyngier, linux-media,
linux-rockchip, devicetree, linux-arm-kernel, linux-kernel
Cc: Nicolas Dufresne, Hans Verkuil, Jonas Karlman, Diederik de Haas,
Dang Huynh, Piotr Oniszczuk
On Fri Nov 20, 2026 at 6:36 PM CET, Daniel Golle wrote:
> This series adds the VDPU346 decoder of the RK3566 and RK3568 to the
> rkvdec driver, for H.264 and HEVC. It continues Christian Hewitt's v3
> ...
> Known limits, none of them introduced here:
>
> - FFmpeg's v4l2-request hwaccel does not set the HEVC EXT_SPS_ST_RPS
> and EXT_SPS_LT_RPS controls, so HEVC through FFmpeg decodes wrongly
> on this decoder as on the VDPU381 ("Long and short term RPS not
> set"). The handling of these controls is also the subject of [6].
FWIW and IIUC, Detlev has a patch for that here:
https://gitlab.collabora.com/detlev/ffmpeg/-/commits/v4l2-request-ext-sps-rps-n8.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
` (5 preceding siblings ...)
2026-11-20 20:16 ` [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Diederik de Haas
@ 2026-11-22 7:44 ` Christian Hewitt
2026-11-22 10:57 ` Daniel Golle
6 siblings, 1 reply; 13+ messages in thread
From: Christian Hewitt @ 2026-11-22 7:44 UTC (permalink / raw)
To: Daniel Golle
Cc: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Marc Zyngier,
linux-media, linux-rockchip, devicetree, linux-arm-kernel,
linux-kernel, Nicolas Dufresne, Hans Verkuil, Jonas Karlman,
Diederik de Haas, Dang Huynh, Piotr Oniszczuk
> On 20 Nov 2026, at 9:36 pm, Daniel Golle <daniel@makrotopia.org> wrote:
>
> This series adds the VDPU346 decoder of the RK3566 and RK3568 to the
> rkvdec driver, for H.264 and HEVC. It continues Christian Hewitt's v3
> [1]; in the v2 cover letter he offered to pass the series on. The
> previous posting [2] carried no version in its subject and counts as
> v4.
The original offer was directed at Detlev based on conversations with
other Collabora folks who were hinting that he would be able to (and
it would even be desirable to) fold VDPU346 patches into his work on
VDPU381/383 which was in-flight at the time. However he didn’t take
the bait and it didn’t happen. The comment is also pre-Claude when my
coding abilities were more rudimentary. The main reason for the long
delay in following up has been the length of time it took for Detlev’s
and related DRM series that permit wider testing to land; a vacation
over the summer, and then Claude distracting me with a deep dive into
the Amlogic and Rockchip media stacks that’s resulted in 300+ patches
that need a proper plan for upstreaming else I’m going to annoy the
already-overworked media/drm maintainers.
I don’t object to someone upstreaming my patches. I do object to the
lack of outreach to check on my plans and patch status before blindly
(and wrongly) assuming there were none. You will find later versions
of my patches with fixes for changes in surrounding code (as I work
on something broadly equivalent to drm-tip not Linux 6.18) and from
further testing in my not-very-abandoned development tree:
https://github.com/chewitt/linux/commits/rockchip-7.4.y
¯\_(ツ)_/¯
> Patches 1, 2 and 4 are Christian's, with two fixups folded in that v4
> carried as separate patches. Patches 3 and 5 are new since v3 and come
> out of a comparison of the driver with the vendor kernel driver
> (rockchip-linux/kernel develop-6.6, drivers/video/rockchip/mpp) and
> the Rockchip MPP library, followed by conformance runs on hardware.
>
> Fluster on a NanoPi R5C (RK3568B2), GStreamer 1.28.7 v4l2sl decoders:
>
> JCT-VC-HEVC_V1 142/147
> JVT-AVC_V1 129/135
> JVT-FR-EXT 65/69
>
> HEVC failures: PICSIZE_A/B/C/D_Bossen_1 are coded at up to 8440 luma
> samples in one dimension, beyond the 4096x2304 limit of the decoder.
> TSUNEQBD_A_MAIN10_Technicolor_2 has unequal luma and chroma bit depth,
> which the driver rejects for every variant.
>
> H.264 failures: CVFC1_Sony_C, FM1_BT_B, FM1_FT_E, SP1_BT_A, sp2_bt_b
> and FM2_SVA_C fail in JVT-AVC_V1; the Hantro G1 of the same board
> fails the same six with the same GStreamer. In JVT-FR-EXT
> Hi422FREXT17_SONY_A, Hi422FREXT19_SONY_A, HPCAMOLQ_BRCM_B and
> HPCVMOLQ_BRCM_B fail; the two BRCM vectors fail on the Hantro G1 as
> well, the two Hi422 intra profile vectors are not understood yet.
>
> SAODBLK_A/B_MainConcept_4 and FREH10-1/2 are counted as passes: they
> decode correctly and exceed the default 60 s fluster timeout only
> because the checksum is computed from an uncached mapping of the
> capture buffers.
>
> Patch 3 is what makes the score deterministic. With the read caches
> left in their reset state, RAP_B_Bossen_2, WPP_D_ericsson_MAIN_2,
> WPP_D_ericsson_MAIN10_2, WPP_E_ericsson_MAIN_2 (HEVC) and
> CAPM3_Sony_D, MR8_BT_B, MR9_BT_B, NRF_MW_E (H.264) produce wrong
> output in three runs out of three; with the patch they pass in three
> out of three. This is likely the source of the artefacts reported
> against v3. The function is shared with the VDPU381, where the cache
> block is mapped by the binding already. The series has been run on
> the RK3588 as well as on the RK3568.
>
> Decode rates with the series: HEVC Main 2160p 92 fps, Main10 2160p
> 77 fps, Main 1080p 380 fps, H.264 High 1080p 197 fps.
>
> Patch 5 is kept apart from the node it modifies because the existing
> Tested-by tags were given at the v3 clock rates, and so that it can be
> dropped on its own.
>
> On the row and column buffer sizes raised in the v3 review [3]: the
> MPP library uses one vdpu34x HAL with one set of size formulas for the
> RK356x and the RK3588, so the variant keeps vdpu381_rcb_sizes.
>
> Known limits, none of them introduced here:
>
> - FFmpeg's v4l2-request hwaccel does not set the HEVC EXT_SPS_ST_RPS
> and EXT_SPS_LT_RPS controls, so HEVC through FFmpeg decodes wrongly
> on this decoder as on the VDPU381 ("Long and short term RPS not
> set"). The handling of these controls is also the subject of [6].
> - A decode error on such a stream ends in the IOMMU page faults and
> the oops reported against v3 [4]. The cause is in the error path
> shared by all variants: the interrupt handler restores the IOMMU
> while the watchdog is still armed, and the watchdog starts the next
> job while the IOMMU is detached. "media: rkvdec: Handle interrupts
> without a current context" [5] covers the oops; the remainder will
> be addressed separately.
> - The Sashiko review of v4 points out that rkvdec_probe() takes the
> SRAM pool without a device link to its provider. This predates the
> series, affects all variants with an sram property and will be sent
> as a separate fix.
FFmpeg: https://github.com/chewitt/FFmpeg/commits/armsoc-9.0.2/
This contains Jonas' current v4l2_request series plus Detlevs patch
and relevant work on deinterlacing and fixes for issues found from
testing on Allwinner/Amlogic/RPi/Rockchip implementations. We even
started work on UAPI for VC1. Unfortunately we are in a holding pattern
waiting patiently for Jonas to resume his series and fold fixes in
(rather than shanghai the series).
> Patches 3 and 5 were written with the help of an LLM coding assistant,
> which also performed the comparison with the vendor sources. It was
> asked to review the v3 series against the vendor driver and to
> complete it, and for v5 to go through the v4 feedback, fold the fixups
> and revise the commit messages. The conformance and A/B runs above
> were done on the board with builds of v4 on Linux 6.18; v5 differs
> from v4 in the order of two writes to the device tree source and in
> one node name, the driver code is unchanged.
IMHO there is way too much word-salad and blogging the journey in this
cover-letter. Concise text and brevity is a virtue. You should also be
working against a current kernel.
> Changes since v4:
> - Fold "media: rkvdec: vdpu346: Limit HEVC EXT SPS RPS dimensions"
> into "media: rkvdec: Add support for the VDPU346 variant", so that
> no commit registers 65 element controls
> - Fold "arm64: dts: rockchip: rk356x: Order vdec regs by address" into
> "arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X"
> - Name the SRAM pool node codec-sram as on the RK3588
> - Read caches: shorten the commit message and state that the cache
> block is mapped for the VDPU383 as well
> - 400 MHz: state that the rate applies to all streams
> - Cc the reviewers and testers of v3
>
> Changes since v3:
> - Add "media: rkvdec: vdpu381: Program the read caches"
> - Add "arm64: dts: rockchip: rk356x: Clock the vdec at 400 MHz"
> - Register the HEVC EXT SPS RPS controls with 64 and 32 elements
> - List the vdec register blocks as link, function, cache
> - Add fluster scores and failure analysis
> - Add Tested-by from Diederik de Haas
>
> v4: https://lore.kernel.org/r/cover.1794654074.git.daniel@makrotopia.org
> v3: https://lore.kernel.org/r/20260110053727.2295260-1-christianshewitt@gmail.com
> v2: https://lore.kernel.org/r/20251226113140.573759-1-christianshewitt@gmail.com
>
> [1] https://lore.kernel.org/r/20260110053727.2295260-1-christianshewitt@gmail.com
> [2] https://lore.kernel.org/r/cover.1794654074.git.daniel@makrotopia.org
> [3] https://lore.kernel.org/r/DFL5TY0QQNMN.1RS04UM9D1V8S@cknow-tech.com
> [4] https://lore.kernel.org/r/DFRU6ODDM71P.3NQGLRK8IVDUY@cknow-tech.com
> [5] https://lore.kernel.org/r/20261026124808.642373-1-a.kazinsky@ideco.ru
> [6] https://lore.kernel.org/r/cover.1794645268.git.daniel@makrotopia.org
>
> Christian Hewitt (3):
> media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings
> media: rkvdec: Add support for the VDPU346 variant
> arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X
>
> Daniel Golle (2):
> media: rkvdec: vdpu381: Program the read caches
> arm64: dts: rockchip: rk356x: Clock the vdec at 400 MHz
>
> .../bindings/media/rockchip,vdec.yaml | 2 +
> arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 49 +++++++
> .../rockchip/rkvdec/rkvdec-vdpu381-h264.c | 2 +
> .../rockchip/rkvdec/rkvdec-vdpu381-hevc.c | 2 +
> .../rockchip/rkvdec/rkvdec-vdpu381-regs.h | 9 ++
> .../media/platform/rockchip/rkvdec/rkvdec.c | 121 ++++++++++++++++++
> .../media/platform/rockchip/rkvdec/rkvdec.h | 2 +
> 7 files changed, 187 insertions(+)
>
>
> base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
> --
> 2.56.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant
2026-11-22 7:44 ` Christian Hewitt
@ 2026-11-22 10:57 ` Daniel Golle
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Golle @ 2026-11-22 10:57 UTC (permalink / raw)
To: Christian Hewitt
Cc: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Shawn Lin, Michael Riesch, David Heidelberg, Marc Zyngier,
linux-media, linux-rockchip, devicetree, linux-arm-kernel,
linux-kernel, Nicolas Dufresne, Hans Verkuil, Jonas Karlman,
Diederik de Haas, Dang Huynh, Piotr Oniszczuk
On Sun, Nov 22, 2026 at 11:44:32AM +0400, Christian Hewitt wrote:
> > On 20 Nov 2026, at 9:36 pm, Daniel Golle <daniel@makrotopia.org> wrote:
> >
> > This series adds the VDPU346 decoder of the RK3566 and RK3568 to the
> > rkvdec driver, for H.264 and HEVC. It continues Christian Hewitt's v3
> > [1]; in the v2 cover letter he offered to pass the series on. The
> > previous posting [2] carried no version in its subject and counts as
> > v4.
>
> The original offer was directed at Detlev based on conversations with
> other Collabora folks who were hinting that he would be able to (and
> it would even be desirable to) fold VDPU346 patches into his work on
> VDPU381/383 which was in-flight at the time.
VDPU381/383 has landed shortly after your initial post, 10 months ago.
Your wording, on a public mailing list, reads
> [...] would be happy to pass the series over to a more experienced
> developer.
I may not have been active in media/drm that much, but am generally very
familiar with kernel development and consider myself reasonably skilled
with C (also "pre-Claude").
As all missing was running the validation suite (and the minimal changes
such as the clock change I've appended to the series) I thought
re-submitting it with the results of the validation suite run would be
the right thing to do.
> However he didn’t take
> the bait and it didn’t happen. The comment is also pre-Claude when my
> coding abilities were more rudimentary. The main reason for the long
> delay in following up has been the length of time it took for Detlev’s
> and related DRM series that permit wider testing to land; a vacation
> over the summer, and then Claude distracting me with a deep dive into
> the Amlogic and Rockchip media stacks that’s resulted in 300+ patches
> that need a proper plan for upstreaming else I’m going to annoy the
> already-overworked media/drm maintainers.
That particular bit, making VDPU436 work, doesn't depend on any of that
future work you may still want to submit. It's immediately useful and
can be tested independently.
> I don’t object to someone upstreaming my patches. I do object to the
> lack of outreach to check on my plans and patch status before blindly
> (and wrongly) assuming there were none.
I didn't mean to overstep you here -- but 10 months of silence and an
offer to hand over the series didn't seem to require any coordination.
> You will find later versions
> of my patches with fixes for changes in surrounding code (as I work
> on something broadly equivalent to drm-tip not Linux 6.18) and from
> further testing in my not-very-abandoned development tree:
>
> https://github.com/chewitt/linux/commits/rockchip-7.4.y
I wasn't aware of yout Github tree which wasn't mentioned anywhere in
your previous submissions. It also seems that this tree has only been
published hours ago, and doesn't contain any changes related to rkvdec
beyond what is also published via the mailing lists.
^ permalink raw reply [flat|nested] 13+ messages in thread