mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Tejun Heo <tj@kernel.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: mkoutny@suse.com, axboe@kernel.dk, ming.lei@redhat.com,
	cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v7 8/9] blk-throttle: cleanup tg_update_disptime()
Date: Wed, 17 Aug 2022 09:38:45 +0800	[thread overview]
Message-ID: <b06bbbce-ffd1-4a07-3f74-eac8411edd97@huaweicloud.com> (raw)
In-Reply-To: <Yvv5as5BVuqjw6PX@slm.duckdns.org>

Hi, Tejun！

在 2022/08/17 4:09, Tejun Heo 写道:
> On Tue, Aug 02, 2022 at 10:04:14PM +0800, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> tg_update_disptime() only need to adjust postion for 'tg' in
>> 'parent_sq', there is no need to call throtl_enqueue/dequeue_tg().
>>
>> Save a little overhead in tg_update_disptime() and prepare to cleanup
>> flag 'THROTL_TG_PENDING', there are no functional changes.
> 
> Does this actually help anything? Given that the heavy part of the operation
> remains the same, this might not be much of an optimization. Is there even a
> microbench that can show the difference?

It's right heavy part remains the same, the patch just remove some
unnecessary operations. And I didn't run benchmark to test that yet.

Thanks,
Kuai
> 
> Thanks.
> 


  reply	other threads:[~2022-08-17  1:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 14:04 [PATCH v7 0/9] bugfix and cleanup for blk-throttle Yu Kuai
2022-08-02 14:04 ` [PATCH v7 1/9] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-08-16 19:37   ` Tejun Heo
2022-08-17  1:13     ` Yu Kuai
2022-08-17 17:50       ` Tejun Heo
2022-08-18  1:23         ` Yu Kuai
2022-08-22  3:06           ` Yu Kuai
2022-08-22  7:25             ` Tejun Heo
2022-08-22  7:44               ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 2/9] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-08-02 14:04 ` [PATCH v7 3/9] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-08-16 19:47   ` Tejun Heo
2022-08-17  1:32     ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 4/9] blk-throttle: fix io hung due to configuration updates Yu Kuai
2022-08-16 20:01   ` Tejun Heo
2022-08-17  1:30     ` Yu Kuai
2022-08-17 17:52       ` Tejun Heo
2022-08-18  1:16         ` Yu Kuai
2022-08-19 17:33           ` Tejun Heo
2022-08-02 14:04 ` [PATCH v7 5/9] blk-throttle: improve handling of re-entered bio for bps limit Yu Kuai
2022-08-16 20:02   ` Tejun Heo
2022-08-02 14:04 ` [PATCH v7 6/9] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-08-16 20:03   ` Tejun Heo
2022-08-17  1:33     ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 7/9] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-08-02 14:04 ` [PATCH v7 8/9] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-08-16 20:09   ` Tejun Heo
2022-08-17  1:38     ` Yu Kuai [this message]
2022-08-02 14:04 ` [PATCH v7 9/9] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai
2022-08-16 20:14   ` Tejun Heo
2022-08-17  1:45     ` Yu Kuai
2022-08-17 17:54       ` Tejun Heo
2022-08-18  9:29         ` Yu Kuai
2022-08-19 17:35           ` Tejun Heo
2022-08-13  5:59 ` [PATCH v7 0/9] bugfix and cleanup for blk-throttle Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b06bbbce-ffd1-4a07-3f74-eac8411edd97@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®