* [PATCH 4/5] drm/i915/opregion: hda: Use safer strscpy() instead of strcpy()
@ 2026-03-10 8:04 renpanpan
2026-03-10 8:34 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: renpanpan @ 2026-03-10 8:04 UTC (permalink / raw)
To: linux-kernel; +Cc: rodrigo.vivi, jani.nikula, renpanpan
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: renpanpan <renpanpan@kylinos.cn>
---
drivers/gpu/drm/i915/gvt/opregion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c
index d6e76ba31d60..e3bb7e0fcd9a 100644
--- a/drivers/gpu/drm/i915/gvt/opregion.c
+++ b/drivers/gpu/drm/i915/gvt/opregion.c
@@ -151,7 +151,7 @@ static void virt_vbt_generation(struct vbt *v)
v->header.vbt_size = sizeof(struct vbt);
v->header.bdb_offset = offsetof(struct vbt, bdb_header);
- strcpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
+ strscpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
v->bdb_header.version = 186; /* child_dev_size = 33 */
v->bdb_header.header_size = sizeof(v->bdb_header);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/5] drm/i915/opregion: hda: Use safer strscpy() instead of strcpy()
2026-03-10 8:04 [PATCH 4/5] drm/i915/opregion: hda: Use safer strscpy() instead of strcpy() renpanpan
@ 2026-03-10 8:34 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2026-03-10 8:34 UTC (permalink / raw)
To: renpanpan, linux-kernel; +Cc: rodrigo.vivi, renpanpan
On Tue, 10 Mar 2026, renpanpan <renpanpan@kylinos.cn> wrote:
> Use a safer function strscpy() instead of strcpy() for copying to
> arrays.
> Only idiomatic code replacement, and no functional changes.
This is not true, and the change introduces a bug.
BR,
Jani.
>
> Signed-off-by: renpanpan <renpanpan@kylinos.cn>
> ---
> drivers/gpu/drm/i915/gvt/opregion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c
> index d6e76ba31d60..e3bb7e0fcd9a 100644
> --- a/drivers/gpu/drm/i915/gvt/opregion.c
> +++ b/drivers/gpu/drm/i915/gvt/opregion.c
> @@ -151,7 +151,7 @@ static void virt_vbt_generation(struct vbt *v)
> v->header.vbt_size = sizeof(struct vbt);
> v->header.bdb_offset = offsetof(struct vbt, bdb_header);
>
> - strcpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
> + strscpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK");
> v->bdb_header.version = 186; /* child_dev_size = 33 */
> v->bdb_header.header_size = sizeof(v->bdb_header);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-10 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-10 8:04 [PATCH 4/5] drm/i915/opregion: hda: Use safer strscpy() instead of strcpy() renpanpan
2026-03-10 8:34 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®