mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "Okan Tümüklü" <okantumukluu@gmail.com>, brauner@kernel.org
Cc: shuah@kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	"Mickaël Salaün" <mic@digikod.net>,
	"Kees Cook" <keescook@chromium.org>,
	"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation
Date: Fri, 7 Jun 2024 15:55:46 -0600	[thread overview]
Message-ID: <b16316c9-67b8-4afa-af5c-6d3fb33c3c6f@linuxfoundation.org> (raw)
In-Reply-To: <20240606180223.5527-1-okantumukluu@gmail.com>

On 6/6/24 12:02, Okan Tümüklü wrote:
> From: Mickaël Salaün <mic@digikod.net>
> 
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
> 
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: Christian Brauner <brauner@kernel.org>
> Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

FYI - This patch is already in the mainline.

commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65
Author: Mickaël Salaün <mic@digikod.net>
Date:   Sat May 11 19:14:42 2024 +0200

     selftests/pidfd: Fix wrong expectation
     
     Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
     which will be actually tested on the parent and child sides with a
     following commit.
     
     Cc: Shuah Khan <skhan@linuxfoundation.org>
     Reviewed-by: Kees Cook <keescook@chromium.org>
     Reviewed-by: Christian Brauner <brauner@kernel.org>
     Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
     Signed-off-by: Mickaël Salaün <mic@digikod.net>


thanks,
-- Shuah

      reply	other threads:[~2024-06-07 21:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 18:02 Okan Tümüklü
2024-06-07 21:55 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b16316c9-67b8-4afa-af5c-6d3fb33c3c6f@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=brauner@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=okantumukluu@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®