[PATCH 07/10] selftests/pidfd: Fix wrong expectation

[PATCH 07/10] selftests/pidfd: Fix wrong expectation

[Okan Tümüklü]

From: Mickaël Salaün <mic@digikod.net>

Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
which will be actually tested on the parent and child sides with a
following commit.

Cc: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
Signed-off-by: Mickaël Salaün <mic@digikod.net>
---
 tools/testing/selftests/pidfd/pidfd_setns_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c
index 6e2f2cd400ca..47746b0c6acd 100644
--- a/tools/testing/selftests/pidfd/pidfd_setns_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_setns_test.c
@@ -158,7 +158,7 @@ FIXTURE_SETUP(current_nsset)
 	/* Create task that exits right away. */
 	self->child_pid_exited = create_child(&self->child_pidfd_exited,
 					      CLONE_NEWUSER | CLONE_NEWNET);
-	EXPECT_GT(self->child_pid_exited, 0);
+	EXPECT_GE(self->child_pid_exited, 0);
 
 	if (self->child_pid_exited == 0)
 		_exit(EXIT_SUCCESS);
-- 
2.39.2

Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation

[Shuah Khan]

On 6/6/24 12:02, Okan Tümüklü wrote:
> From: Mickaël Salaün <mic@digikod.net>
> 
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
> 
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: Christian Brauner <brauner@kernel.org>
> Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

FYI - This patch is already in the mainline.

commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65
Author: Mickaël Salaün <mic@digikod.net>
Date:   Sat May 11 19:14:42 2024 +0200

     selftests/pidfd: Fix wrong expectation
     
     Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
     which will be actually tested on the parent and child sides with a
     following commit.
     
     Cc: Shuah Khan <skhan@linuxfoundation.org>
     Reviewed-by: Kees Cook <keescook@chromium.org>
     Reviewed-by: Christian Brauner <brauner@kernel.org>
     Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
     Signed-off-by: Mickaël Salaün <mic@digikod.net>


thanks,
-- Shuah