Re: [PATCH v2 2/5] ASoC: dt-bindings: cs35l45: GPIOs configuration

Re: [PATCH v2 2/5] ASoC: dt-bindings: cs35l45: GPIOs configuration

[Charles Keepax]

On Fri, Mar 03, 2023 at 01:21:48PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
> 
> This adds description of CS35L45 GPIOs configuration.
> 
> Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
> ---

Your missing the DT maintainers and list from your CC list on
this patch.

Thanks,
Charles

Re: [PATCH v2 3/5] ASoC: cs35l45: IRQ support

[Charles Keepax]

On Fri, Mar 03, 2023 at 01:21:49PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
> 
> Adds IRQ handlers
> 
> Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support

[Charles Keepax]

On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
> 
> The CS35L45 digital core incorporates one programmable DSP block,
> capable of running a wide range of audio enhancement and speaker
> and battery protection functions.
> 
> Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
> ---
> +#define CS35L45_DAC_MUX_ROUTE(name) \
> +	{ name" Source", "ASP_RX1",	"ASP_RX1" }, \
> +	{ name" Source", "ASP_RX2",	"ASP_RX2" }, \
> +	{ name" Source", "DSP_TX1",	"DSP1" }, \
> +	{ name" Source", "DSP_TX2",	"DSP1" }
> +
> +

Minor nit, double blank line here.

But otherwise looks pretty good to me:

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support

[Vlad Karpovich]

On 3/6/23 03:26, Charles Keepax wrote:
> On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
>> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
>>
>> The CS35L45 digital core incorporates one programmable DSP block,
>> capable of running a wide range of audio enhancement and speaker
>> and battery protection functions.
>>
>> Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
>> ---
>> +#define CS35L45_DAC_MUX_ROUTE(name) \
>> +	{ name" Source", "ASP_RX1",	"ASP_RX1" }, \
>> +	{ name" Source", "ASP_RX2",	"ASP_RX2" }, \
>> +	{ name" Source", "DSP_TX1",	"DSP1" }, \
>> +	{ name" Source", "DSP_TX2",	"DSP1" }
>> +
>> +
> Minor nit, double blank line here.
Thanks. I will fix it
> But otherwise looks pretty good to me:
>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> Thanks,
> Charles

Re: [PATCH v2 5/5] ASoC: cs35l45: Hibernation support

[Charles Keepax]

On Fri, Mar 03, 2023 at 01:21:51PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
> 
> Adds support for a low-power Hibernation State.
> In this state, all register contents are lost, but the contents of
> RAM are retained. In the Hibernation State, only always-on digital
> functions to support wake-up are enabled.

Yeah perhaps clarify that this relates to the DSP, something like
"Add support for a low-power hibernation state for the DSP. In
this state the DSP RAM contents are maintained, such that
firmware does not need to be re-downloaded, but the rest of the
chip's register state is lost."

But rest of it looks good to me:

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles