mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Helge Deller <deller@gmx.de>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-m68k@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 03/10] video: fbdev: atari: Fix inverse handling
Date: Mon, 11 Jul 2022 17:50:27 +0200	[thread overview]
Message-ID: <b24ff02cb947e5b3a00ca74268db1b504d7346ba.1657554353.git.geert@linux-m68k.org> (raw)
In-Reply-To: <cover.1657554353.git.geert@linux-m68k.org>

Currently, the "inverse" option does not do anything, as it just sets a
flag, which is further unused.

Fix this by calling fb_invert_cmaps() instead, like other drivers do.
As this only affects the console colormap, this does not affect X.
Update the documentation to match the actual behavior.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 Documentation/m68k/kernel-options.rst | 4 ++--
 drivers/video/fbdev/atafb.c           | 4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/m68k/kernel-options.rst b/Documentation/m68k/kernel-options.rst
index cabd9419740d5ada..2008a20b43295bd5 100644
--- a/Documentation/m68k/kernel-options.rst
+++ b/Documentation/m68k/kernel-options.rst
@@ -367,8 +367,8 @@ activated by a "external:" sub-option.
 4.1.2) inverse
 --------------
 
-Invert the display. This affects both, text (consoles) and graphics
-(X) display. Usually, the background is chosen to be black. With this
+Invert the display. This affects only text consoles.
+Usually, the background is chosen to be black. With this
 option, you can make the background white.
 
 4.1.3) font
diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c
index 172ef547ff6f4883..39c3b860a797d4bc 100644
--- a/drivers/video/fbdev/atafb.c
+++ b/drivers/video/fbdev/atafb.c
@@ -236,8 +236,6 @@ static int *MV300_reg = MV300_reg_8bit;
 #endif /* ATAFB_EXT */
 
 
-static int inverse;
-
 /*
  * struct fb_ops {
  *	* open/release and usage marking
@@ -2971,7 +2969,7 @@ static int __init atafb_setup(char *options)
 			default_par = temp;
 			mode_option = this_opt;
 		} else if (!strcmp(this_opt, "inverse"))
-			inverse = 1;
+			fb_invert_cmaps();
 		else if (!strncmp(this_opt, "hwscroll_", 9)) {
 			hwscroll = simple_strtoul(this_opt + 9, NULL, 10);
 			if (hwscroll < 0)
-- 
2.25.1


  parent reply	other threads:[~2022-07-11 15:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 15:50 [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 01/10] video: fbdev: atari: Simplify atafb_pan_display() Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 02/10] video: fbdev: atari: Remove bogus FB_VMODE_YWRAP flags Geert Uytterhoeven
2022-07-11 15:50 ` Geert Uytterhoeven [this message]
2022-07-11 15:50 ` [PATCH 04/10] video: fbdev: atari: Fix ext_setcolreg() Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 05/10] video: fbdev: atari: Remove unneeded casts from void * Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 06/10] video: fbdev: atari: Remove unneeded casts to " Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 07/10] video: fbdev: atari: Fix TT High video mode vertical refresh Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 08/10] video: fbdev: atari: Fix VGA modes Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 09/10] video: fbdev: atari: Remove unused definitions and variables Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 10/10] [RFC] video: fbdev: atari: Remove backward bug-compatibility Geert Uytterhoeven
2022-07-12  8:18 ` [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups Helge Deller
2022-07-15  4:50 ` Michael Schmitz
2022-07-17 23:02 ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b24ff02cb947e5b3a00ca74268db1b504d7346ba.1657554353.git.geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=corbet@lwn.net \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®