From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Helge Deller <deller@gmx.de>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 08/10] video: fbdev: atari: Fix VGA modes
Date: Mon, 11 Jul 2022 17:50:32 +0200 [thread overview]
Message-ID: <d4366ec393e7b69a579d9aaf972d2d36734f1422.1657554353.git.geert@linux-m68k.org> (raw)
In-Reply-To: <cover.1657554353.git.geert@linux-m68k.org>
The pixclock values in the vga and vga70 modes are wrong, as they should
use the 25.175 MHz clock instead of the 32 MHz clock.
Swap the left and right margins to match f25.{right,left} (struct
pixel_clock declares them in a different order), and update the hsync
lengths to match what the driver programs by default.
Correct the (wrong) floating-point vrefresh value for the vga mode.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/video/fbdev/atafb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c
index 528478f6f30857ef..46a00e0ad5e785ac 100644
--- a/drivers/video/fbdev/atafb.c
+++ b/drivers/video/fbdev/atafb.c
@@ -494,11 +494,11 @@ static struct fb_videomode atafb_modedb[] __initdata = {
{
/* 640x480, 31 kHz, 60 Hz (VGA) */
- "vga", 63.5, 640, 480, 32000, 18, 42, 31, 11, 96, 3,
+ "vga", 60, 640, 480, 39721, 42, 18, 31, 11, 100, 3,
0, FB_VMODE_NONINTERLACED
}, {
/* 640x400, 31 kHz, 70 Hz (VGA) */
- "vga70", 70, 640, 400, 32000, 18, 42, 31, 11, 96, 3,
+ "vga70", 70, 640, 400, 39721, 42, 18, 31, 11, 100, 3,
FB_SYNC_VERT_HIGH_ACT | FB_SYNC_COMP_HIGH_ACT, FB_VMODE_NONINTERLACED
},
--
2.25.1
next prev parent reply other threads:[~2022-07-11 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 15:50 [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 01/10] video: fbdev: atari: Simplify atafb_pan_display() Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 02/10] video: fbdev: atari: Remove bogus FB_VMODE_YWRAP flags Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 03/10] video: fbdev: atari: Fix inverse handling Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 04/10] video: fbdev: atari: Fix ext_setcolreg() Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 05/10] video: fbdev: atari: Remove unneeded casts from void * Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 06/10] video: fbdev: atari: Remove unneeded casts to " Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 07/10] video: fbdev: atari: Fix TT High video mode vertical refresh Geert Uytterhoeven
2022-07-11 15:50 ` Geert Uytterhoeven [this message]
2022-07-11 15:50 ` [PATCH 09/10] video: fbdev: atari: Remove unused definitions and variables Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 10/10] [RFC] video: fbdev: atari: Remove backward bug-compatibility Geert Uytterhoeven
2022-07-12 8:18 ` [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups Helge Deller
2022-07-15 4:50 ` Michael Schmitz
2022-07-17 23:02 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4366ec393e7b69a579d9aaf972d2d36734f1422.1657554353.git.geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=corbet@lwn.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®