From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Helge Deller <deller@gmx.de>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 04/10] video: fbdev: atari: Fix ext_setcolreg()
Date: Mon, 11 Jul 2022 17:50:28 +0200 [thread overview]
Message-ID: <f807e1c6deedb2b819a309347295b0fd2f89c2c2.1657554353.git.geert@linux-m68k.org> (raw)
In-Reply-To: <cover.1657554353.git.geert@linux-m68k.org>
The red, green, and blue color values are 16-bit, while the external
graphics hardware registers are 8-bit.
Add the missing conversion from 16-bit to 8-bit.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Untested due to lack of hardware.
---
drivers/video/fbdev/atafb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c
index 39c3b860a797d4bc..a36cd8f1f4200dd5 100644
--- a/drivers/video/fbdev/atafb.c
+++ b/drivers/video/fbdev/atafb.c
@@ -2206,6 +2206,10 @@ static int ext_setcolreg(unsigned int regno, unsigned int red,
if (regno > 255)
return 1;
+ red >>= 8;
+ green >>= 8;
+ blue >>= 8;
+
switch (external_card_type) {
case IS_VGA:
OUTB(0x3c8, regno);
--
2.25.1
next prev parent reply other threads:[~2022-07-11 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 15:50 [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 01/10] video: fbdev: atari: Simplify atafb_pan_display() Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 02/10] video: fbdev: atari: Remove bogus FB_VMODE_YWRAP flags Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 03/10] video: fbdev: atari: Fix inverse handling Geert Uytterhoeven
2022-07-11 15:50 ` Geert Uytterhoeven [this message]
2022-07-11 15:50 ` [PATCH 05/10] video: fbdev: atari: Remove unneeded casts from void * Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 06/10] video: fbdev: atari: Remove unneeded casts to " Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 07/10] video: fbdev: atari: Fix TT High video mode vertical refresh Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 08/10] video: fbdev: atari: Fix VGA modes Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 09/10] video: fbdev: atari: Remove unused definitions and variables Geert Uytterhoeven
2022-07-11 15:50 ` [PATCH 10/10] [RFC] video: fbdev: atari: Remove backward bug-compatibility Geert Uytterhoeven
2022-07-12 8:18 ` [PATCH 00/10] video: fbdev: atari: Miscellaneous fixes and cleanups Helge Deller
2022-07-15 4:50 ` Michael Schmitz
2022-07-17 23:02 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f807e1c6deedb2b819a309347295b0fd2f89c2c2.1657554353.git.geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=corbet@lwn.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®