* [PATCH] acpi video: force native for some T2 macbooks
@ 2024-07-05 13:56 Aditya Garg
2024-07-08 10:13 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Aditya Garg @ 2024-07-05 13:56 UTC (permalink / raw)
To: Hans de Goede, Lukas Wunner, Rafael J . Wysocki, Len Brown
Cc: linux-acpi, Linux Kernel Mailing List, Orlando Chamberlain
From: Orlando Chamberlain <orlandoch.dev@gmail.com>
The intel backlight is needed for these, previously users had nothing in
/sys/class/backlight.
Signed-off-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
drivers/acpi/video_detect.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 442396f6ed1f..baf7264d7b94 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -513,6 +513,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"),
},
},
+ {
+ .callback = video_detect_force_native,
+ /* Apple MacBook Air 9,1 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"),
+ },
+ },
{
/* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
.callback = video_detect_force_native,
@@ -522,6 +530,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro12,1"),
},
},
+ {
+ .callback = video_detect_force_native,
+ /* Apple MacBook Pro 16,2 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,2"),
+ },
+ },
{
.callback = video_detect_force_native,
/* Dell Inspiron N4010 */
--
2.42.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] acpi video: force native for some T2 macbooks
2024-07-05 13:56 [PATCH] acpi video: force native for some T2 macbooks Aditya Garg
@ 2024-07-08 10:13 ` Hans de Goede
2024-07-09 16:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2024-07-08 10:13 UTC (permalink / raw)
To: Aditya Garg, Lukas Wunner, Rafael J . Wysocki, Len Brown
Cc: linux-acpi, Linux Kernel Mailing List, Orlando Chamberlain
Hi,
On 7/5/24 3:56 PM, Aditya Garg wrote:
> From: Orlando Chamberlain <orlandoch.dev@gmail.com>
>
> The intel backlight is needed for these, previously users had nothing in
> /sys/class/backlight.
>
> Signed-off-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/acpi/video_detect.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 442396f6ed1f..baf7264d7b94 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -513,6 +513,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"),
> },
> },
> + {
> + .callback = video_detect_force_native,
> + /* Apple MacBook Air 9,1 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"),
> + },
> + },
> {
> /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
> .callback = video_detect_force_native,
> @@ -522,6 +530,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro12,1"),
> },
> },
> + {
> + .callback = video_detect_force_native,
> + /* Apple MacBook Pro 16,2 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,2"),
> + },
> + },
> {
> .callback = video_detect_force_native,
> /* Dell Inspiron N4010 */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] acpi video: force native for some T2 macbooks
2024-07-08 10:13 ` Hans de Goede
@ 2024-07-09 16:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2024-07-09 16:08 UTC (permalink / raw)
To: Hans de Goede, Aditya Garg
Cc: Lukas Wunner, Rafael J . Wysocki, Len Brown, linux-acpi,
Linux Kernel Mailing List, Orlando Chamberlain
On Mon, Jul 8, 2024 at 12:13 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 7/5/24 3:56 PM, Aditya Garg wrote:
> > From: Orlando Chamberlain <orlandoch.dev@gmail.com>
> >
> > The intel backlight is needed for these, previously users had nothing in
> > /sys/class/backlight.
> >
> > Signed-off-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Applied as 6.11 material, thanks!
> > ---
> > drivers/acpi/video_detect.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> > index 442396f6ed1f..baf7264d7b94 100644
> > --- a/drivers/acpi/video_detect.c
> > +++ b/drivers/acpi/video_detect.c
> > @@ -513,6 +513,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"),
> > },
> > },
> > + {
> > + .callback = video_detect_force_native,
> > + /* Apple MacBook Air 9,1 */
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"),
> > + },
> > + },
> > {
> > /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
> > .callback = video_detect_force_native,
> > @@ -522,6 +530,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro12,1"),
> > },
> > },
> > + {
> > + .callback = video_detect_force_native,
> > + /* Apple MacBook Pro 16,2 */
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,2"),
> > + },
> > + },
> > {
> > .callback = video_detect_force_native,
> > /* Dell Inspiron N4010 */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-09 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-05 13:56 [PATCH] acpi video: force native for some T2 macbooks Aditya Garg
2024-07-08 10:13 ` Hans de Goede
2024-07-09 16:08 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®