* [PATCH 1/1] dt-bindings: extcon: ptn5150: add child node port
@ 2024-08-12 23:18 Frank Li
2024-08-13 5:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Frank Li @ 2024-08-12 23:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, MyungJoo Ham, Chanwoo Choi, Rob Herring,
Conor Dooley, open list:NXP PTN5150A CC LOGIC AND EXTCON DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Cc: imx
Add child node 'port' to allow connect to usb controller to do role-switch.
Fix below warning:
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
index d5cfa32ea52dd..28c34d78708cb 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
+++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
@@ -37,6 +37,11 @@ properties:
GPIO pin (output) used to control VBUS. If skipped, no such control
takes place.
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ A port node to link the usb controller for the dual role switch.
+
required:
- compatible
- interrupts
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: extcon: ptn5150: add child node port
2024-08-12 23:18 [PATCH 1/1] dt-bindings: extcon: ptn5150: add child node port Frank Li
@ 2024-08-13 5:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-13 5:39 UTC (permalink / raw)
To: Frank Li, MyungJoo Ham, Chanwoo Choi, Rob Herring, Conor Dooley,
open list:NXP PTN5150A CC LOGIC AND EXTCON DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Fabio Estevam
Cc: imx
On 13/08/2024 01:18, Frank Li wrote:
> Add child node 'port' to allow connect to usb controller to do role-switch.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
>
This looks reasonable however intention was to switch to connector node,
wasn't it? I actually wonder how the commit 095b96b2b adding connector
could fix that warning...
The binding and device driver might be incomplete. There should be a
connector somewhere.
Anyway, in any case, please extend the example.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: extcon: ptn5150: add child node port
2024-08-13 4:33 Frank Li
@ 2024-08-13 4:38 ` Frank Li
0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2024-08-13 4:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, MyungJoo Ham, Chanwoo Choi, Rob Herring,
Conor Dooley, open list:NXP PTN5150A CC LOGIC AND EXTCON DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Cc: imx
On Tue, Aug 13, 2024 at 12:33:53AM -0400, Frank Li wrote:
> Add child node 'port' to allow connect to usb controller to do role-switch.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Really sorry, mistake post this. It already post at
https://lore.kernel.org/imx/20240812231820.3838925-1-Frank.Li@nxp.com/T/#u
Frank
> Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> index d5cfa32ea52dd..28c34d78708cb 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> +++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> @@ -37,6 +37,11 @@ properties:
> GPIO pin (output) used to control VBUS. If skipped, no such control
> takes place.
>
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + A port node to link the usb controller for the dual role switch.
> +
> required:
> - compatible
> - interrupts
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] dt-bindings: extcon: ptn5150: add child node port
@ 2024-08-13 4:33 Frank Li
2024-08-13 4:38 ` Frank Li
0 siblings, 1 reply; 4+ messages in thread
From: Frank Li @ 2024-08-13 4:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, MyungJoo Ham, Chanwoo Choi, Rob Herring,
Conor Dooley, open list:NXP PTN5150A CC LOGIC AND EXTCON DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Cc: imx
Add child node 'port' to allow connect to usb controller to do role-switch.
Fix below warning:
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
index d5cfa32ea52dd..28c34d78708cb 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
+++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
@@ -37,6 +37,11 @@ properties:
GPIO pin (output) used to control VBUS. If skipped, no such control
takes place.
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ A port node to link the usb controller for the dual role switch.
+
required:
- compatible
- interrupts
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-13 5:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-12 23:18 [PATCH 1/1] dt-bindings: extcon: ptn5150: add child node port Frank Li
2024-08-13 5:39 ` Krzysztof Kozlowski
2024-08-13 4:33 Frank Li
2024-08-13 4:38 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®