Re: [RFC PATCH 09/15] virt: tdx-guest: Capture the TDI report during device lock

["Edgecombe, Rick P" <rick.p.edgecombe@intel.com>]

On Wed, 2026-10-28 at 03:23 +0000, Duan, Zhenzhong wrote:
> > -----Original Message-----
> > From: Li, Xiaoyao <xiaoyao.li@intel.com>
> > Subject: Re: [RFC PATCH 09/15] virt: tdx-guest: Capture the TDI report
> > during device lock
> > 
> > On 9/24/2026 12:10 PM, Zhenzhong Duan wrote:
> > > Retrieve the Trusted Device Interface report through
> > > TDCM_OP_GET_TDI_REPORT after binding the device.
> > > 
> > > Store the report in the PCI TSM device evidence object and free it
> > > during device unlock.
> > 
> > It doesn't talk about why the report is needed, and why it needs to be
> > stored in
> > the evidence object.
> 
> The report is used in next patch.
> 
> With below patch, I think we don't need to store report it evidence object
> in next version.
> 
> https://lore.kernel.org/all/20261005070252.84810-2-ankita@nvidia.com/

You don't want the reviewer to have to piece together a puzzle by holding a
bunch of unresolved things in their head as they read the whole thing. Seems
like a valid comment to me. But the solution is not always just to add more
things to the log.

But I think we are still going to break this series apart into subsections for
getting x86 acks. Consider what could covered in a subsection coverletter too,
for designing something with overall reviewability.