[PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE

[PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE

[Miaohe Lin]

It's introduced but never used. Remove it.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 include/linux/writeback.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/include/linux/writeback.h b/include/linux/writeback.h
index 3f045f6d6c4f..06f9291b6fd5 100644
--- a/include/linux/writeback.h
+++ b/include/linux/writeback.h
@@ -17,20 +17,12 @@ struct bio;
 DECLARE_PER_CPU(int, dirty_throttle_leaks);
 
 /*
- * The 1/4 region under the global dirty thresh is for smooth dirty throttling:
- *
- *	(thresh - thresh/DIRTY_FULL_SCOPE, thresh)
- *
- * Further beyond, all dirtier tasks will enter a loop waiting (possibly long
- * time) for the dirty pages to drop, unless written enough pages.
- *
  * The global dirty threshold is normally equal to the global dirty limit,
  * except when the system suddenly allocates a lot of anonymous memory and
  * knocks down the global dirty threshold quickly, in which case the global
  * dirty limit will follow down slowly to prevent livelocking all dirtier tasks.
  */
 #define DIRTY_SCOPE		8
-#define DIRTY_FULL_SCOPE	(DIRTY_SCOPE / 2)
 
 struct backing_dev_info;
 
-- 
2.23.0

Re: [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE

[Jan Kara]

On Fri 09-09-22 10:57:11, Miaohe Lin wrote:
> It's introduced but never used. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/writeback.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 3f045f6d6c4f..06f9291b6fd5 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -17,20 +17,12 @@ struct bio;
>  DECLARE_PER_CPU(int, dirty_throttle_leaks);
>  
>  /*
> - * The 1/4 region under the global dirty thresh is for smooth dirty throttling:
> - *
> - *	(thresh - thresh/DIRTY_FULL_SCOPE, thresh)
> - *
> - * Further beyond, all dirtier tasks will enter a loop waiting (possibly long
> - * time) for the dirty pages to drop, unless written enough pages.
> - *
>   * The global dirty threshold is normally equal to the global dirty limit,
>   * except when the system suddenly allocates a lot of anonymous memory and
>   * knocks down the global dirty threshold quickly, in which case the global
>   * dirty limit will follow down slowly to prevent livelocking all dirtier tasks.
>   */
>  #define DIRTY_SCOPE		8
> -#define DIRTY_FULL_SCOPE	(DIRTY_SCOPE / 2)
>  
>  struct backing_dev_info;
>  
> -- 
> 2.23.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE

[Jens Axboe]

On 9/8/22 8:57 PM, Miaohe Lin wrote:
> It's introduced but never used. Remove it.

Acked-by: Jens Axboe <axboe@kernel.dk>

Andrew, would you mind queueing this one up?

-- 
Jens Axboe