* [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE
@ 2022-09-09 2:57 Miaohe Lin
2022-09-09 9:36 ` Jan Kara
2022-09-10 11:37 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-09-09 2:57 UTC (permalink / raw)
To: axboe
Cc: dhowells, vbabka, willy, akpm, zhanglianjie, neilb, jack,
bvanassche, linux-kernel, linmiaohe
It's introduced but never used. Remove it.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
include/linux/writeback.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/include/linux/writeback.h b/include/linux/writeback.h
index 3f045f6d6c4f..06f9291b6fd5 100644
--- a/include/linux/writeback.h
+++ b/include/linux/writeback.h
@@ -17,20 +17,12 @@ struct bio;
DECLARE_PER_CPU(int, dirty_throttle_leaks);
/*
- * The 1/4 region under the global dirty thresh is for smooth dirty throttling:
- *
- * (thresh - thresh/DIRTY_FULL_SCOPE, thresh)
- *
- * Further beyond, all dirtier tasks will enter a loop waiting (possibly long
- * time) for the dirty pages to drop, unless written enough pages.
- *
* The global dirty threshold is normally equal to the global dirty limit,
* except when the system suddenly allocates a lot of anonymous memory and
* knocks down the global dirty threshold quickly, in which case the global
* dirty limit will follow down slowly to prevent livelocking all dirtier tasks.
*/
#define DIRTY_SCOPE 8
-#define DIRTY_FULL_SCOPE (DIRTY_SCOPE / 2)
struct backing_dev_info;
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE
2022-09-09 2:57 [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE Miaohe Lin
@ 2022-09-09 9:36 ` Jan Kara
2022-09-10 11:37 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2022-09-09 9:36 UTC (permalink / raw)
To: Miaohe Lin
Cc: axboe, dhowells, vbabka, willy, akpm, zhanglianjie, neilb, jack,
bvanassche, linux-kernel
On Fri 09-09-22 10:57:11, Miaohe Lin wrote:
> It's introduced but never used. Remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/writeback.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 3f045f6d6c4f..06f9291b6fd5 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -17,20 +17,12 @@ struct bio;
> DECLARE_PER_CPU(int, dirty_throttle_leaks);
>
> /*
> - * The 1/4 region under the global dirty thresh is for smooth dirty throttling:
> - *
> - * (thresh - thresh/DIRTY_FULL_SCOPE, thresh)
> - *
> - * Further beyond, all dirtier tasks will enter a loop waiting (possibly long
> - * time) for the dirty pages to drop, unless written enough pages.
> - *
> * The global dirty threshold is normally equal to the global dirty limit,
> * except when the system suddenly allocates a lot of anonymous memory and
> * knocks down the global dirty threshold quickly, in which case the global
> * dirty limit will follow down slowly to prevent livelocking all dirtier tasks.
> */
> #define DIRTY_SCOPE 8
> -#define DIRTY_FULL_SCOPE (DIRTY_SCOPE / 2)
>
> struct backing_dev_info;
>
> --
> 2.23.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE
2022-09-09 2:57 [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE Miaohe Lin
2022-09-09 9:36 ` Jan Kara
@ 2022-09-10 11:37 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-09-10 11:37 UTC (permalink / raw)
To: Miaohe Lin
Cc: dhowells, vbabka, willy, akpm, zhanglianjie, neilb, jack,
bvanassche, linux-kernel
On 9/8/22 8:57 PM, Miaohe Lin wrote:
> It's introduced but never used. Remove it.
Acked-by: Jens Axboe <axboe@kernel.dk>
Andrew, would you mind queueing this one up?
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-10 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 2:57 [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE Miaohe Lin
2022-09-09 9:36 ` Jan Kara
2022-09-10 11:37 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®