* [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create()
@ 2017-08-12 16:51 SF Markus Elfring
2017-08-12 21:33 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-08-12 16:51 UTC (permalink / raw)
To: alsa-devel, Arnd Bergmann, Jaroslav Kysela, Julia Lawall, Takashi Iwai
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 12 Aug 2017 18:45:42 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/pci/mixart/mixart.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index 6d7fbf30618b..84f6b2651bf3 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -1052,10 +1052,8 @@ static int snd_mixart_create(struct mixart_mgr *mgr, struct snd_card *card, int
};
chip = kzalloc(sizeof(*chip), GFP_KERNEL);
- if (! chip) {
- dev_err(card->dev, "cannot allocate chip\n");
+ if (!chip)
return -ENOMEM;
- }
chip->card = card;
chip->chip_idx = idx;
--
2.14.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create()
2017-08-12 16:51 [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() SF Markus Elfring
@ 2017-08-12 21:33 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-08-12 21:33 UTC (permalink / raw)
To: SF Markus Elfring
Cc: alsa-devel, Arnd Bergmann, Julia Lawall, Jaroslav Kysela,
kernel-janitors, LKML
On Sat, 12 Aug 2017 18:51:51 +0200,
SF Markus Elfring wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 12 Aug 2017 18:45:42 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-12 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-12 16:51 [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() SF Markus Elfring
2017-08-12 21:33 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®