From: Andrew Lunn <andrew@lunn.ch>
To: Frank Sae <Frank.Sae@motor-comm.com>
Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yuanlai.cui@motor-comm.com, hua.sun@motor-comm.com,
xiaoyong.li@motor-comm.com, suting.hu@motor-comm.com,
jie.han@motor-comm.com
Subject: Re: [PATCH net-next v3 2/2] net: phy: Add driver for Motorcomm yt8821 2.5G ethernet phy
Date: Mon, 26 Aug 2024 04:05:08 +0200 [thread overview]
Message-ID: <b64f3ec3-4497-4185-bea2-fdcb5f3f9403@lunn.ch> (raw)
In-Reply-To: <20240822114701.61967-3-Frank.Sae@motor-comm.com>
> + ret = ytphy_modify_ext(phydev, YT8821_SDS_EXT_CSR_CTRL_REG, mask,
> + set);
> + if (ret < 0)
> + goto err_restore_page;
> +
> +err_restore_page:
> + return phy_restore_page(phydev, old_page, ret);
> +}
> +
> + ret = ytphy_modify_ext(phydev,
> + YT8821_UTP_EXT_DAC_IMSB_CH_0_1_CTRL_REG,
> + mask, set);
> + if (ret < 0)
> + goto err_restore_page;
> +
> +err_restore_page:
> + return phy_restore_page(phydev, old_page, ret);
> +}
> + ret = ytphy_modify_ext(phydev,
> + YT8521_EXTREG_SLEEP_CONTROL1_REG,
> + YT8521_ESC1R_SLEEP_SW,
> + enable ? 1 : 0);
> + if (ret < 0)
> + goto err_restore_page;
> +
> +err_restore_page:
> + return phy_restore_page(phydev, old_page, ret);
> +}
Please could you remove all these pointless goto err_restore_page;
Andrew
prev parent reply other threads:[~2024-08-26 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:46 [PATCH net-next v3 0/2] " Frank Sae
2024-08-22 11:47 ` [PATCH net-next v3 1/2] net: phy: Optimize phy speed mask to be compatible to yt8821 Frank Sae
2024-08-26 1:59 ` Andrew Lunn
2024-08-26 5:56 ` Frank.Sae
2024-08-26 12:38 ` Andrew Lunn
2024-08-22 11:47 ` [PATCH net-next v3 2/2] net: phy: Add driver for Motorcomm yt8821 2.5G ethernet phy Frank Sae
2024-08-26 2:05 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64f3ec3-4497-4185-bea2-fdcb5f3f9403@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hua.sun@motor-comm.com \
--cc=jie.han@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=suting.hu@motor-comm.com \
--cc=xiaoyong.li@motor-comm.com \
--cc=yuanlai.cui@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®