From: "Frank.Sae" <Frank.Sae@motor-comm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yuanlai.cui@motor-comm.com, hua.sun@motor-comm.com,
xiaoyong.li@motor-comm.com, suting.hu@motor-comm.com,
jie.han@motor-comm.com
Subject: Re: [PATCH net-next v3 1/2] net: phy: Optimize phy speed mask to be compatible to yt8821
Date: Sun, 25 Aug 2024 22:56:54 -0700 [thread overview]
Message-ID: <cf3193b6-589f-41b7-b89a-a94ba3b751d8@motor-comm.com> (raw)
In-Reply-To: <a4fbc34b-5d87-449a-83df-db0cfc1bf3cf@lunn.ch>
On 8/25/24 18:59, Andrew Lunn wrote:
> On Thu, Aug 22, 2024 at 04:47:00AM -0700, Frank Sae wrote:
>> yt8521 and yt8531s as Gigabit transceiver use bit15:14(bit9 reserved
>> default 0) as phy speed mask, yt8821 as 2.5G transceiver uses bit9 bit15:14
>> as phy speed mask.
>>
>> Be compatible to yt8821, reform phy speed mask and phy speed macro.
>>
>> Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Ideally, your Signed-off-by: should be last. No need to repost because
> of this.
>
> Andrew
Andrew, please help to confirm that the Reviewed-by: should be followed by
Signed-off-by:?
it should be like below:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
Best Regards
next prev parent reply other threads:[~2024-08-26 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:46 [PATCH net-next v3 0/2] Add driver for Motorcomm yt8821 2.5G ethernet phy Frank Sae
2024-08-22 11:47 ` [PATCH net-next v3 1/2] net: phy: Optimize phy speed mask to be compatible to yt8821 Frank Sae
2024-08-26 1:59 ` Andrew Lunn
2024-08-26 5:56 ` Frank.Sae [this message]
2024-08-26 12:38 ` Andrew Lunn
2024-08-22 11:47 ` [PATCH net-next v3 2/2] net: phy: Add driver for Motorcomm yt8821 2.5G ethernet phy Frank Sae
2024-08-26 2:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3193b6-589f-41b7-b89a-a94ba3b751d8@motor-comm.com \
--to=frank.sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hua.sun@motor-comm.com \
--cc=jie.han@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=suting.hu@motor-comm.com \
--cc=xiaoyong.li@motor-comm.com \
--cc=yuanlai.cui@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®