Re: [PATCH net-next v3 1/2] net: phy: Optimize phy speed mask to be compatible to yt8821

[Andrew Lunn <andrew@lunn.ch>]

On Sun, Aug 25, 2024 at 10:56:54PM -0700, Frank.Sae wrote:
> 
> On 8/25/24 18:59, Andrew Lunn wrote:
> > On Thu, Aug 22, 2024 at 04:47:00AM -0700, Frank Sae wrote:
> > > yt8521 and yt8531s as Gigabit transceiver use bit15:14(bit9 reserved
> > > default 0) as phy speed mask, yt8821 as 2.5G transceiver uses bit9 bit15:14
> > > as phy speed mask.
> > > 
> > > Be compatible to yt8821, reform phy speed mask and phy speed macro.
> > > 
> > > Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Ideally, your Signed-off-by: should be last. No need to repost because
> > of this.
> > 
> > 	Andrew
> 
> Andrew, please help to confirm that the Reviewed-by: should be followed by
> Signed-off-by:?
> 
> it should be like below:
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>

It is a cosmetic thing. Each Maintainer handling the patch on it way
towards mainline will add their own Signed-off-by: to the end. By
having yours last, it keeps them all together.

Just picking a random example:

commit 5b9eebc2c7a5f0cc7950d918c1e8a4ad4bed5010
Author: Pawel Dembicki <paweldembicki@gmail.com>
Date:   Fri Aug 9 21:38:03 2024 +0200

    net: dsa: vsc73xx: pass value in phy_write operation
    
    In the 'vsc73xx_phy_write' function, the register value is missing,
    and the phy write operation always sends zeros.
    
    This commit passes the value variable into the proper register.
    
    Fixes: 05bd97fc559d ("net: dsa: Add Vitesse VSC73xx DSA router driver")
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
    Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

David added his signed-of-by. But as i said, it is purely cosmetic.

	Andrew