From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>, Like Xu <like.xu.linux@gmail.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Kim Phillips <kim.phillips@amd.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Like Xu <likexu@tencent.com>
Subject: Re: [PATCH v2 4/6] KVM: x86/pmu: Add pmc->intr to refactor kvm_perf_overflow{_intr}()
Date: Fri, 10 Dec 2021 10:35:32 +0100 [thread overview]
Message-ID: <b6c1eb18-9237-f604-9a96-9e6ca397121c@redhat.com> (raw)
In-Reply-To: <CALMp9eTtsMuEsimONp7TOjJ-uskwJBD-52kZzOefSKXeCwn_5A@mail.gmail.com>
On 12/10/21 01:54, Jim Mattson wrote:
> On Thu, Dec 9, 2021 at 12:28 AM Like Xu <like.xu.linux@gmail.com> wrote:
>>
>> On 9/12/2021 12:25 pm, Jim Mattson wrote:
>>>
>>> Not your change, but if the event is counting anything based on
>>> cycles, and the guest TSC is scaled to run at a different rate from
>>> the host TSC, doesn't the initial value of the underlying hardware
>>> counter have to be adjusted as well, so that the interrupt arrives
>>> when the guest's counter overflows rather than when the host's counter
>>> overflows?
>>
>> I've thought about this issue too and at least the Intel Specification
>> did not let me down on this detail:
>>
>> "The counter changes in the VMX non-root mode will follow
>> VMM's use of the TSC offset or TSC scaling VMX controls"
>
> Where do you see this? I see similar text regarding TSC packets in the
> section on Intel Processor Trace, but nothing about PMU counters
> advancing at a scaled TSC frequency.
Indeed it seems quite unlikely that PMU counters can count fractionally.
Even for tracing the SDM says "Like the value returned by RDTSC, TSC
packets will include these adjustments, but other timing packets (such
as MTC, CYC, and CBR) are not impacted". Considering that "stand-alone
TSC packets are typically generated only when generation of other timing
packets (MTCs and CYCs) has ceased for a period of time", I'm not even
sure it's a good thing that the values in TSC packets are scaled and offset.
Back to the PMU, for non-architectural counters it's not really possible
to know if they count in cycles or not. So it may not be a good idea to
special case the architectural counters.
Paolo
next prev parent reply other threads:[~2021-12-10 9:35 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 7:42 [PATCH v2 0/6] KVM: x86/pmu: Count two basic events for emulated instructions Like Xu
2021-11-30 7:42 ` [PATCH v2 1/6] KVM: x86/pmu: Setup pmc->eventsel for fixed PMCs Like Xu
2021-12-06 19:57 ` Jim Mattson
2021-12-09 18:49 ` Paolo Bonzini
2021-12-09 18:53 ` Jim Mattson
2021-12-09 18:57 ` Paolo Bonzini
2021-12-10 10:20 ` Like Xu
[not found] ` <CALMp9eTq8H_bJOVKwi_7j3Kum9RvW6o-G3zCLUFco1A1cvNrkQ@mail.gmail.com>
2021-12-07 6:07 ` Like Xu
2021-12-07 17:42 ` Jim Mattson
2021-11-30 7:42 ` [PATCH v2 2/6] KVM: x86/pmu: Refactoring find_arch_event() to pmc_perf_hw_id() Like Xu
2021-12-09 3:52 ` Jim Mattson
2021-12-09 8:11 ` Like Xu
2021-12-09 19:24 ` Paolo Bonzini
2022-02-05 1:55 ` Jim Mattson
2022-02-09 9:00 ` Like Xu
2022-02-09 19:30 ` Jim Mattson
2022-02-10 11:28 ` Like Xu
2022-02-11 9:56 ` Ravi Bangoria
2022-02-11 18:16 ` Jim Mattson
2022-02-14 10:14 ` Ravi Bangoria
2022-02-16 7:44 ` Like Xu
2022-02-16 11:24 ` Ravi Bangoria
2021-11-30 7:42 ` [PATCH v2 3/6] KVM: x86/pmu: Reuse pmc_perf_hw_id() and drop find_fixed_event() Like Xu
2021-12-09 3:58 ` Jim Mattson
2021-11-30 7:42 ` [PATCH v2 4/6] KVM: x86/pmu: Add pmc->intr to refactor kvm_perf_overflow{_intr}() Like Xu
2021-12-09 4:25 ` Jim Mattson
2021-12-09 8:28 ` Like Xu
2021-12-10 0:54 ` Jim Mattson
2021-12-10 9:35 ` Paolo Bonzini [this message]
2021-12-10 10:11 ` Like Xu
2021-12-10 22:55 ` Jim Mattson
2021-12-10 22:59 ` Paolo Bonzini
2021-12-10 23:31 ` Jim Mattson
2021-12-12 4:56 ` Jim Mattson
2021-12-13 6:37 ` Jim Mattson
2021-12-16 9:57 ` Like Xu
2021-12-16 17:52 ` Jim Mattson
2021-11-30 7:42 ` [PATCH v2 5/6] KVM: x86: Update vPMCs when retiring instructions Like Xu
2021-12-09 4:33 ` Jim Mattson
2021-12-09 8:44 ` Like Xu
2021-12-09 9:23 ` Like Xu
2021-11-30 7:42 ` [PATCH v2 6/6] KVM: x86: Update vPMCs when retiring branch instructions Like Xu
2021-12-09 4:40 ` Jim Mattson
2021-12-09 19:30 ` [PATCH v2 0/6] KVM: x86/pmu: Count two basic events for emulated instructions Paolo Bonzini
2021-12-16 10:14 ` Like Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c1eb18-9237-f604-9a96-9e6ca397121c@redhat.com \
--to=pbonzini@redhat.com \
--cc=ak@linux.intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®