From: Logan Gunthorpe <logang@deltatee.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Joe Perches <joe@perches.com>, Jon Mason <jdmason@kudzu.us>,
Xiangliang Yu <Xiangliang.Yu@amd.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
linux-ntb@googlegroups.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Style fixes: open code obfuscating macros
Date: Wed, 11 Jan 2017 10:48:51 -0700 [thread overview]
Message-ID: <b6de6b70-7dbd-d8e6-9967-b9590fef91ad@deltatee.com> (raw)
In-Reply-To: <20170111065036.GA4111@kroah.com>
On 10/01/17 11:50 PM, Greg Kroah-Hartman wrote:
> You should be printing against the ntb struct device, as that's the
> "correct" structure here, and not the PCI device at all, as that's too
> far up the device chain from what the driver is supposed to be doing.
Yup, agreed and thanks. My v2 patchset already makes this change.
Logan
next prev parent reply other threads:[~2017-01-11 17:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 1:30 Logan Gunthorpe
2017-01-03 1:30 ` [PATCH 1/2] ntb_hw_amd: Style fixes: open code macros that just obfuscate code Logan Gunthorpe
2017-01-03 1:30 ` [PATCH 2/2] ntb_hw_intel: " Logan Gunthorpe
2017-01-10 21:55 ` [PATCH 0/2] Style fixes: open code obfuscating macros Jon Mason
2017-01-10 21:59 ` Jon Mason
2017-01-10 23:06 ` Joe Perches
2017-01-10 23:34 ` Logan Gunthorpe
2017-01-11 6:50 ` Greg Kroah-Hartman
2017-01-11 17:48 ` Logan Gunthorpe [this message]
2017-01-15 22:38 ` jmrodriguezhw88
2017-01-11 0:32 Logan Gunthorpe
2017-01-11 0:34 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6de6b70-7dbd-d8e6-9967-b9590fef91ad@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®