From: Logan Gunthorpe <logang@deltatee.com>
To: Joe Perches <joe@perches.com>, Jon Mason <jdmason@kudzu.us>
Cc: Xiangliang Yu <Xiangliang.Yu@amd.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ntb@googlegroups.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Style fixes: open code obfuscating macros
Date: Tue, 10 Jan 2017 16:34:41 -0700 [thread overview]
Message-ID: <ebef7d4f-1e3d-b70f-741b-3f06b820289a@deltatee.com> (raw)
In-Reply-To: <1484089612.12006.11.camel@perches.com>
On 10/01/17 04:06 PM, Joe Perches wrote:
> It might also be better to add and use YA
> logging macro like ndev_dbg
>
> #define ndev_dvg(ndev, fmt, ...) \
> dev_dbg(&(ndev)->ntb.pdev->dev, fmt, ##__VA_ARGS__)
>
> so that the new temporaries that are used just
> for debugging are not required.
>
I feel like that's going in the exact opposite direction from what Greg
was looking for... I think the point is to hide less of where the device
is coming from, not to create a new and different macro that hides
things in a different way.
Or, more likely, I _think_ Greg would suggest that this is showing that
the driver model isn't really being used properly. Perhaps, we should be
printing against the ntb struct device instead of the pci device so
there is no dereferencing.
Logan
next prev parent reply other threads:[~2017-01-10 23:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 1:30 Logan Gunthorpe
2017-01-03 1:30 ` [PATCH 1/2] ntb_hw_amd: Style fixes: open code macros that just obfuscate code Logan Gunthorpe
2017-01-03 1:30 ` [PATCH 2/2] ntb_hw_intel: " Logan Gunthorpe
2017-01-10 21:55 ` [PATCH 0/2] Style fixes: open code obfuscating macros Jon Mason
2017-01-10 21:59 ` Jon Mason
2017-01-10 23:06 ` Joe Perches
2017-01-10 23:34 ` Logan Gunthorpe [this message]
2017-01-11 6:50 ` Greg Kroah-Hartman
2017-01-11 17:48 ` Logan Gunthorpe
2017-01-15 22:38 ` jmrodriguezhw88
2017-01-11 0:32 Logan Gunthorpe
2017-01-11 0:34 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebef7d4f-1e3d-b70f-741b-3f06b820289a@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®